You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@weex.apache.org by whn9527 <gi...@git.apache.org> on 2018/03/26 07:01:11 UTC
[GitHub] incubator-weex pull request #1085: [Weex-260][android]switch supports settin...
GitHub user whn9527 opened a pull request:
https://github.com/apache/incubator-weex/pull/1085
[Weex-260][android]switch supports setting color
Hi, It's solution to support setting color for `<switch>` component in android. And the api was according to [ios design](https://github.com/apache/incubator-weex/pull/1076), a slight difference is `<switch>` can accept 4 attributes in android:
||android|ios|
|---|---|---|
|tint-color|√|√|
|on-tint-color|√|√|
|thumb-tint-color|√|√|
|on-thumb-tint-color|√|×|
Weex Vue Demo: [http://dotwe.org/vue/e9d87730e016bec01225e546ff10ef0d](http://dotwe.org/vue/e9d87730e016bec01225e546ff10ef0d)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/whn9527/incubator-weex android-feature-switch
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-weex/pull/1085.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1085
----
----
---
[GitHub] incubator-weex issue #1085: [Weex-260][android]switch supports setting color
Posted by whn9527 <gi...@git.apache.org>.
Github user whn9527 commented on the issue:
https://github.com/apache/incubator-weex/pull/1085
Thanks for reminding, I will pay attention next time
---
[GitHub] incubator-weex issue #1085: [Weex-260][android]switch supports setting color
Posted by acton393 <gi...@git.apache.org>.
Github user acton393 commented on the issue:
https://github.com/apache/incubator-weex/pull/1085
hi @whn9527 maybe your commit message should be the format like
```
[WEEX-jira][iOS/Android] summary
description
Bug/ImprovementId(jira ID)
```
not just like `*[Android]` later
thanks
---
[GitHub] incubator-weex issue #1085: [Weex-260][android]switch supports setting color
Posted by weex-bot <gi...@git.apache.org>.
Github user weex-bot commented on the issue:
https://github.com/apache/incubator-weex/pull/1085
<!--
0 failure:
1 warning: No Changelog chan...
1 messages
-->
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Warnings</th>
</tr>
</thead>
<tbody><tr>
<td>:warning:</td>
<td>No Changelog changes!</td>
</tr>
</tbody>
</table>
<table>
<thead>
<tr>
<th width="50"></th>
<th width="100%" data-danger-table="true">Messages</th>
</tr>
</thead>
<tbody><tr>
<td>:book:</td>
<td>danger test finished.</td>
</tr>
</tbody>
</table>
<p align="right">
Generated by :no_entry_sign: <a href="http://github.com/danger/danger-js/">dangerJS</a>
</p>
---
[GitHub] incubator-weex issue #1085: [Weex-260][android]switch supports setting color
Posted by gubaojian <gi...@git.apache.org>.
Github user gubaojian commented on the issue:
https://github.com/apache/incubator-weex/pull/1085
switch great support, please attach dotwe.org example link
---
[GitHub] incubator-weex pull request #1085: [Weex-260][android]switch supports settin...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-weex/pull/1085
---
[GitHub] incubator-weex issue #1085: [Weex-260][android]switch supports setting color
Posted by acton393 <gi...@git.apache.org>.
Github user acton393 commented on the issue:
https://github.com/apache/incubator-weex/pull/1085
@gubaojian @misakuo please take a review
---
[GitHub] incubator-weex issue #1085: [Weex-260][android]switch supports setting color
Posted by whn9527 <gi...@git.apache.org>.
Github user whn9527 commented on the issue:
https://github.com/apache/incubator-weex/pull/1085
demo link please look at http://dotwe.org/vue/e9d87730e016bec01225e546ff10ef0d
---