[GitHub] [incubator-doris] imay commented on a change in pull request #2847: Doris support in memory olap table

[GitBox <gi...@apache.org>]

imay commented on a change in pull request #2847: Doris support in memory olap table
URL: https://github.com/apache/incubator-doris/pull/2847#discussion_r380129274
 
 

 ##########
 File path: be/src/olap/tablet_meta.h
 ##########
 @@ -155,7 +155,7 @@ class TabletMeta {
     inline const bool in_restore_mode() const;
     inline OLAPStatus set_in_restore_mode(bool in_restore_mode);
 
-    inline const TabletSchema& tablet_schema() const;
+    inline TabletSchema& tablet_schema();
 
 Review comment:
   Prefer `mutable_tablet_schema()` to return a pointer.
   Normally, const modification is required when returning a reference

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org