You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2020/03/14 03:12:50 UTC
[GitHub] [incubator-tvm] masahi commented on a change in pull request #5049:
[Relay, TOPI] Refactor Adaptive pool and add 3d support
masahi commented on a change in pull request #5049: [Relay, TOPI] Refactor Adaptive pool and add 3d support
URL: https://github.com/apache/incubator-tvm/pull/5049#discussion_r392551594
##########
File path: topi/tests/python/test_topi_pooling.py
##########
@@ -294,6 +285,11 @@ def test_adaptive_pool():
verify_adaptive_pool((1, 3, 224, 224), (1, 1), "avg")
verify_adaptive_pool((1, 14, 56, 78), (34, 13), "max")
verify_adaptive_pool((1, 5, 46, 97), (4, 96), "avg")
+ verify_adaptive_pool((1, 16, 32, 32, 32), (1, 1, 1), "max", layout="NCDHW")
+ verify_adaptive_pool((1, 16, 32, 32, 32), (1, 1, 1), "avg", layout="NCDHW")
+ verify_adaptive_pool((1, 16, 32, 32, 32), (2, 2, 2), "max", layout="NCDHW")
+ verify_adaptive_pool((1, 16, 32, 32, 32), (2, 2, 2), "avg", layout="NCDHW")
Review comment:
Added in the commit https://github.com/apache/incubator-tvm/pull/5049/commits/90c22195ec323f7606fb8c8c52f1b5bb45ab0313.
I found that other topi pool tests don't test on NHWC layout at all. Tests and numpy reference are all hard coded for NCHW.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services