You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/06/14 07:52:11 UTC
[GitHub] [pulsar] ericsyh opened a new pull request #10913: fix: quotation marks in schema-get-started docs used in Chinese style
ericsyh opened a new pull request #10913:
URL: https://github.com/apache/pulsar/pull/10913
### Why for change
In the [schema-get-started](https://pulsar.apache.org/docs/en/schema-get-started/), the Example code used the Chinese style quotation marks like
```
Producer<byte[]> producer = client.newProducer()
.topic(topic)
.create();
User user = new User(“Tom”, 28);
byte[] message = … // serialize the `user` by yourself;
producer.send(message);
```
### What did i change
I updated the sample code, and used the English style quotation marks to make a replacement.
<!--
### Contribution Checklist
- Name the pull request in the form "[Issue XYZ][component] Title of the pull request", where *XYZ* should be replaced by the actual issue number.
Skip *Issue XYZ* if there is no associated github issue for this pull request.
Skip *component* if you are unsure about which is the best component. E.g. `[docs] Fix typo in produce method`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
*(If this PR fixes a github issue, please add `Fixes #<xyz>`.)*
Fixes #<xyz>
*(or if this PR is one task of a github issue, please add `Master Issue: #<xyz>` to link to the master issue.)*
Master Issue: #<xyz>
### Motivation
*Explain here the context, and why you're making that change. What is the problem you're trying to solve.*
### Modifications
*Describe the modifications you've done.*
### Verifying this change
- [ ] Make sure that the change passes the CI checks.
*(Please pick either of the following options)*
This change is a trivial rework / code cleanup without any test coverage.
*(or)*
This change is already covered by existing tests, such as *(please describe tests)*.
*(or)*
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Does this pull request potentially affect one of the following parts:
*If `yes` was chosen, please highlight the changes*
- Dependencies (does it add or upgrade a dependency): (yes / no)
- The public API: (yes / no)
- The schema: (yes / no / don't know)
- The default values of configurations: (yes / no)
- The wire protocol: (yes / no)
- The rest endpoints: (yes / no)
- The admin cli options: (yes / no)
- Anything that affects deployment: (yes / no / don't know)
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tuhaihe commented on pull request #10913: fix: quotation marks in schema-get-started docs used in Chinese style
Posted by GitBox <gi...@apache.org>.
tuhaihe commented on pull request #10913:
URL: https://github.com/apache/pulsar/pull/10913#issuecomment-860724140
Hi, @ericsyh Thanks for your update! For the PRs in Apache/Pulsar repo, feel free to invite Pulsar committers to help review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #10913: fix: quotation marks in schema-get-started docs used in Chinese style
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #10913:
URL: https://github.com/apache/pulsar/pull/10913#issuecomment-861107561
@ericsyh `Batch Search and Replace` can fix this issue in multiple versions with just a few clicks, which is a pretty easy way.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet merged pull request #10913: fix: quotation marks in schema-get-started docs used in Chinese style
Posted by GitBox <gi...@apache.org>.
Anonymitaet merged pull request #10913:
URL: https://github.com/apache/pulsar/pull/10913
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] ericsyh commented on pull request #10913: fix: quotation marks in schema-get-started docs used in Chinese style
Posted by GitBox <gi...@apache.org>.
ericsyh commented on pull request #10913:
URL: https://github.com/apache/pulsar/pull/10913#issuecomment-861156545
@Anonymitaet Fixed in https://github.com/apache/pulsar/pull/10913/commits/6023e2f0e8c203c6315f2ccca64b1b1c38a0d425
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Anonymitaet commented on pull request #10913: fix: quotation marks in schema-get-started docs used in Chinese style
Posted by GitBox <gi...@apache.org>.
Anonymitaet commented on pull request #10913:
URL: https://github.com/apache/pulsar/pull/10913#issuecomment-861172333
@ericsyh thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] ericsyh commented on pull request #10913: fix: quotation marks in schema-get-started docs used in Chinese style
Posted by GitBox <gi...@apache.org>.
ericsyh commented on pull request #10913:
URL: https://github.com/apache/pulsar/pull/10913#issuecomment-860167668
@tuhaihe PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] ericsyh removed a comment on pull request #10913: fix: quotation marks in schema-get-started docs used in Chinese style
Posted by GitBox <gi...@apache.org>.
ericsyh removed a comment on pull request #10913:
URL: https://github.com/apache/pulsar/pull/10913#issuecomment-860167668
@tuhaihe PTAL
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] ericsyh commented on pull request #10913: fix: quotation marks in schema-get-started docs used in Chinese style
Posted by GitBox <gi...@apache.org>.
ericsyh commented on pull request #10913:
URL: https://github.com/apache/pulsar/pull/10913#issuecomment-861106261
@Anonymitaet It's ok for me, i will fix it on previous versions. But actually the current way that put all versions docs in master branch is not so friendly which means any change we need to update so many documents at same time.
Maybe we can consider to separate the docs as a new repo and manage versions by branch. After a new PR commits to the master branch, we can cherry-pick this PR to previous version branch (With a github bot, we can use comments to trigger)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] ericsyh commented on pull request #10913: fix: quotation marks in schema-get-started docs used in Chinese style
Posted by GitBox <gi...@apache.org>.
ericsyh commented on pull request #10913:
URL: https://github.com/apache/pulsar/pull/10913#issuecomment-861077203
@tuhaihe Thanks and @BewareMyPower just reviewed. BTW, pulsar committers are listed on this [Apache Phone Book](http://home.apache.org/phonebook.html?unix=committers)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org