You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/02/08 16:57:55 UTC

[GitHub] [arrow] marcprux commented on a change in pull request #9445: ARROW-11557: [Rust][Datafusion] Add deregister_table

marcprux commented on a change in pull request #9445:
URL: https://github.com/apache/arrow/pull/9445#discussion_r572207819



##########
File path: rust/datafusion/src/execution/context.rs
##########
@@ -720,6 +735,9 @@ mod tests {
         ];
         assert_batches_eq!(expected, &results);
 
+        assert_eq!(ctx.deregister_table("dual"), true);
+        assert_eq!(ctx.deregister_table("dual"), false);

Review comment:
       I'll do that. I hadn't done it originally because there is a fair amount of boilerplate to setting up a data source, but I agree that it makes sense to test is separately.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org