You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tuscany.apache.org by ant elder <an...@gmail.com> on 2011/06/03 11:06:23 UTC
[VOTE] Release Tuscany Zip Plugin Alpha3 RC2
Please vote on releasing the Tuscany Zip Plugin module (RC2).
The change over the alpha2 release is to rename the module from
maven-zip-plugin to tuscany-zip-plugin, see TUSCANY-3861. This RC2
fixes the issue Florian found with the old plugin name still being
referenced.
The tag for the release is:
https://svn.apache.org/repos/asf/tuscany/maven-plugins/tags/tuscany-zip-plugin-alpha3
The Maven staging repository is:
http://people.apache.org/~antelder/tuscany/tuscany-zip-plugin-alpha3-RC2
+1 from me.
...ant
[RESULT][VOTE] Release Tuscany Zip Plugin Alpha3 RC2
Posted by ant elder <an...@gmail.com>.
Passed with three +1s from me, Florian, and Simon Laws.
...ant
On Fri, Jun 3, 2011 at 10:06 AM, ant elder <an...@gmail.com> wrote:
> Please vote on releasing the Tuscany Zip Plugin module (RC2).
>
> The change over the alpha2 release is to rename the module from
> maven-zip-plugin to tuscany-zip-plugin, see TUSCANY-3861. This RC2
> fixes the issue Florian found with the old plugin name still being
> referenced.
>
> The tag for the release is:
> https://svn.apache.org/repos/asf/tuscany/maven-plugins/tags/tuscany-zip-plugin-alpha3
>
> The Maven staging repository is:
> http://people.apache.org/~antelder/tuscany/tuscany-zip-plugin-alpha3-RC2
>
> +1 from me.
>
> ...ant
>
Re: [VOTE] Release Tuscany Zip Plugin Alpha3 RC2
Posted by Simon Laws <si...@googlemail.com>.
On Fri, Jun 17, 2011 at 12:43 PM, ant elder <an...@gmail.com> wrote:
> There are two answers to that. Firstly the reason the files aren't
> included is because resource includes clause in the pom.xml only
> mentions the LICENSE/NOTICE but not the README so they don't get
> picked up in the built jar, the other reason of why its like that is
> because its never been called out that the jars we release must
> include doc files within them, so this plugin didn't on the previous
> releases and none of the other maven plugins of any of the module jars
> we've released have either.
>
> Its obviously just an oversight and it seems reasonable that those doc
> files would be included and so I've updated trunk for this plugin so
> that they will get included on the next release, but should this block
> this release? IMHO it shouldn't as we've not required it for any other
> jars we've released in the past, leaving this to the next release to
> fix seems ok to me. So I'm hoping someone will still give another +1
> on this vote thread.
>
> ...ant
>
> On Fri, Jun 17, 2011 at 11:59 AM, Mike Edwards
> <mi...@gmail.com> wrote:
>> Ant,
>>
>> Why is this famed README not in either of the jar files:
>>
>> tuscany-zip-plugin-alpha3.jar
>> tuscany-zip-plugin-alpha3-sources.jar
>>
>>
>> Yours, Mike.
>>
>>
>> On 17/06/2011 11:32, ant elder wrote:
>>>
>>> The most comprehensive doc is in the README file, IIRC thats mostly
>>> written by your good self Mike.
>>>
>>> ...ant
>>>
>>
>>
>>
>>
>
I've tried it and the plugin works. As for the README It is an
oversight that it's not in there but not enough for me to vote against
it so +1 for this release.
Simon
--
Apache Tuscany committer: tuscany.apache.org
Co-author of a book about Tuscany and SCA: tuscanyinaction.com
Re: [VOTE] Release Tuscany Zip Plugin Alpha3 RC2
Posted by ant elder <an...@gmail.com>.
There are two answers to that. Firstly the reason the files aren't
included is because resource includes clause in the pom.xml only
mentions the LICENSE/NOTICE but not the README so they don't get
picked up in the built jar, the other reason of why its like that is
because its never been called out that the jars we release must
include doc files within them, so this plugin didn't on the previous
releases and none of the other maven plugins of any of the module jars
we've released have either.
Its obviously just an oversight and it seems reasonable that those doc
files would be included and so I've updated trunk for this plugin so
that they will get included on the next release, but should this block
this release? IMHO it shouldn't as we've not required it for any other
jars we've released in the past, leaving this to the next release to
fix seems ok to me. So I'm hoping someone will still give another +1
on this vote thread.
...ant
On Fri, Jun 17, 2011 at 11:59 AM, Mike Edwards
<mi...@gmail.com> wrote:
> Ant,
>
> Why is this famed README not in either of the jar files:
>
> tuscany-zip-plugin-alpha3.jar
> tuscany-zip-plugin-alpha3-sources.jar
>
>
> Yours, Mike.
>
>
> On 17/06/2011 11:32, ant elder wrote:
>>
>> The most comprehensive doc is in the README file, IIRC thats mostly
>> written by your good self Mike.
>>
>> ...ant
>>
>
>
>
>
Re: [VOTE] Release Tuscany Zip Plugin Alpha3 RC2
Posted by Mike Edwards <mi...@gmail.com>.
Ant,
Why is this famed README not in either of the jar files:
tuscany-zip-plugin-alpha3.jar
tuscany-zip-plugin-alpha3-sources.jar
Yours, Mike.
On 17/06/2011 11:32, ant elder wrote:
> The most comprehensive doc is in the README file, IIRC thats mostly
> written by your good self Mike.
>
> ...ant
>
Re: [VOTE] Release Tuscany Zip Plugin Alpha3 RC2
Posted by ant elder <an...@gmail.com>.
The most comprehensive doc is in the README file, IIRC thats mostly
written by your good self Mike.
...ant
On Fri, Jun 17, 2011 at 10:31 AM, Mike Edwards
<mi...@gmail.com> wrote:
> Ant,
>
> I've taken a look - is there any documentation for this plugin somewhere?
>
> Yours, Mike.
>
> On 17/06/2011 04:37, ant elder wrote:
>>
>> Still need one more vote to be able to release this please.
>>
>> ...ant
>>
>> On Fri, Jun 3, 2011 at 11:33 AM, Florian Moga<mo...@gmail.com> wrote:
>>>
>>> No, that's not an issue. I was checking with you in case the plugin had
>>> to
>>> detect the webapp and construct the zip file in a different way so that
>>> the
>>> Node will know to start the webapp.
>>>
>>> In this case, everything seems fine, so here my +1.
>>>
>>> On Fri, Jun 3, 2011 at 1:16 PM, ant elder<an...@apache.org> wrote:
>>>>
>>>> On Fri, Jun 3, 2011 at 10:59 AM, Florian Moga<mo...@gmail.com>
>>>> wrote:
>>>>>
>>>>> Hi Ant,
>>>>> It now works fine with the helloworld sample. I've checked and it uses
>>>>> alpha3 with mvn help:describe
>>>>> -Dplugin=org.apache.tuscany.sca:tuscany-zip-plugin.
>>>>> I've tried packaging webapps as zip and running them with something
>>>>> like
>>>>> node = NodeFactory.newInstance().createNode(new Contribution("foo",
>>>>> "target/helloworld-webapp-2.0-SNAPSHOT.zip"));
>>>>> node.start();
>>>>> but the Tuscany runtime simply logs
>>>>> INFO: Loading contribution:
>>>>>
>>>>>
>>>>> file:/home/fmoga/coding/apache-tuscany/trunk/samples/getting-started/helloworld-webapp/target/helloworld-webapp-2.0-SNAPSHOT.zip
>>>>> and doesn't deploy the webapp. Is this plugin intended to support
>>>>> webapps as
>>>>> well? Couldn't find any information related to this in the README.
>>>>> Thanks,
>>>>> Florian
>>>>>
>>>>
>>>> No I don't expect that would work presently, but from what you've said
>>>> it sounds like the tuscany-zip-plugin did work ok and create a zip
>>>> contribution but the issue is that the NodeFactory Node doesn't know
>>>> who to run that as a webapp. Is this something that needs to be
>>>> supported, why would you want a webapp not packaged as a .war? Either
>>>> way, is this an issue for this plugin release or could it be left for
>>>> a later release?
>>>>
>>>> ...ant
>>>
>>>
>>
>
>
Re: [VOTE] Release Tuscany Zip Plugin Alpha3 RC2
Posted by Mike Edwards <mi...@gmail.com>.
Ant,
I've taken a look - is there any documentation for this plugin somewhere?
Yours, Mike.
On 17/06/2011 04:37, ant elder wrote:
> Still need one more vote to be able to release this please.
>
> ...ant
>
> On Fri, Jun 3, 2011 at 11:33 AM, Florian Moga<mo...@gmail.com> wrote:
>> No, that's not an issue. I was checking with you in case the plugin had to
>> detect the webapp and construct the zip file in a different way so that the
>> Node will know to start the webapp.
>>
>> In this case, everything seems fine, so here my +1.
>>
>> On Fri, Jun 3, 2011 at 1:16 PM, ant elder<an...@apache.org> wrote:
>>>
>>> On Fri, Jun 3, 2011 at 10:59 AM, Florian Moga<mo...@gmail.com> wrote:
>>>> Hi Ant,
>>>> It now works fine with the helloworld sample. I've checked and it uses
>>>> alpha3 with mvn help:describe
>>>> -Dplugin=org.apache.tuscany.sca:tuscany-zip-plugin.
>>>> I've tried packaging webapps as zip and running them with something like
>>>> node = NodeFactory.newInstance().createNode(new Contribution("foo",
>>>> "target/helloworld-webapp-2.0-SNAPSHOT.zip"));
>>>> node.start();
>>>> but the Tuscany runtime simply logs
>>>> INFO: Loading contribution:
>>>>
>>>> file:/home/fmoga/coding/apache-tuscany/trunk/samples/getting-started/helloworld-webapp/target/helloworld-webapp-2.0-SNAPSHOT.zip
>>>> and doesn't deploy the webapp. Is this plugin intended to support
>>>> webapps as
>>>> well? Couldn't find any information related to this in the README.
>>>> Thanks,
>>>> Florian
>>>>
>>>
>>> No I don't expect that would work presently, but from what you've said
>>> it sounds like the tuscany-zip-plugin did work ok and create a zip
>>> contribution but the issue is that the NodeFactory Node doesn't know
>>> who to run that as a webapp. Is this something that needs to be
>>> supported, why would you want a webapp not packaged as a .war? Either
>>> way, is this an issue for this plugin release or could it be left for
>>> a later release?
>>>
>>> ...ant
>>
>>
>
Re: [VOTE] Release Tuscany Zip Plugin Alpha3 RC2
Posted by ant elder <an...@apache.org>.
Still need one more vote to be able to release this please.
...ant
On Fri, Jun 3, 2011 at 11:33 AM, Florian Moga <mo...@gmail.com> wrote:
> No, that's not an issue. I was checking with you in case the plugin had to
> detect the webapp and construct the zip file in a different way so that the
> Node will know to start the webapp.
>
> In this case, everything seems fine, so here my +1.
>
> On Fri, Jun 3, 2011 at 1:16 PM, ant elder <an...@apache.org> wrote:
>>
>> On Fri, Jun 3, 2011 at 10:59 AM, Florian Moga <mo...@gmail.com> wrote:
>> > Hi Ant,
>> > It now works fine with the helloworld sample. I've checked and it uses
>> > alpha3 with mvn help:describe
>> > -Dplugin=org.apache.tuscany.sca:tuscany-zip-plugin.
>> > I've tried packaging webapps as zip and running them with something like
>> > node = NodeFactory.newInstance().createNode(new Contribution("foo",
>> > "target/helloworld-webapp-2.0-SNAPSHOT.zip"));
>> > node.start();
>> > but the Tuscany runtime simply logs
>> > INFO: Loading contribution:
>> >
>> > file:/home/fmoga/coding/apache-tuscany/trunk/samples/getting-started/helloworld-webapp/target/helloworld-webapp-2.0-SNAPSHOT.zip
>> > and doesn't deploy the webapp. Is this plugin intended to support
>> > webapps as
>> > well? Couldn't find any information related to this in the README.
>> > Thanks,
>> > Florian
>> >
>>
>> No I don't expect that would work presently, but from what you've said
>> it sounds like the tuscany-zip-plugin did work ok and create a zip
>> contribution but the issue is that the NodeFactory Node doesn't know
>> who to run that as a webapp. Is this something that needs to be
>> supported, why would you want a webapp not packaged as a .war? Either
>> way, is this an issue for this plugin release or could it be left for
>> a later release?
>>
>> ...ant
>
>
Re: [VOTE] Release Tuscany Zip Plugin Alpha3 RC2
Posted by Florian Moga <mo...@gmail.com>.
No, that's not an issue. I was checking with you in case the plugin had to
detect the webapp and construct the zip file in a different way so that the
Node will know to start the webapp.
In this case, everything seems fine, so here my +1.
On Fri, Jun 3, 2011 at 1:16 PM, ant elder <an...@apache.org> wrote:
> On Fri, Jun 3, 2011 at 10:59 AM, Florian Moga <mo...@gmail.com> wrote:
> > Hi Ant,
> > It now works fine with the helloworld sample. I've checked and it uses
> > alpha3 with mvn help:describe
> > -Dplugin=org.apache.tuscany.sca:tuscany-zip-plugin.
> > I've tried packaging webapps as zip and running them with something like
> > node = NodeFactory.newInstance().createNode(new Contribution("foo",
> > "target/helloworld-webapp-2.0-SNAPSHOT.zip"));
> > node.start();
> > but the Tuscany runtime simply logs
> > INFO: Loading contribution:
> >
> file:/home/fmoga/coding/apache-tuscany/trunk/samples/getting-started/helloworld-webapp/target/helloworld-webapp-2.0-SNAPSHOT.zip
> > and doesn't deploy the webapp. Is this plugin intended to support webapps
> as
> > well? Couldn't find any information related to this in the README.
> > Thanks,
> > Florian
> >
>
> No I don't expect that would work presently, but from what you've said
> it sounds like the tuscany-zip-plugin did work ok and create a zip
> contribution but the issue is that the NodeFactory Node doesn't know
> who to run that as a webapp. Is this something that needs to be
> supported, why would you want a webapp not packaged as a .war? Either
> way, is this an issue for this plugin release or could it be left for
> a later release?
>
> ...ant
>
Re: [VOTE] Release Tuscany Zip Plugin Alpha3 RC2
Posted by ant elder <an...@apache.org>.
On Fri, Jun 3, 2011 at 10:59 AM, Florian Moga <mo...@gmail.com> wrote:
> Hi Ant,
> It now works fine with the helloworld sample. I've checked and it uses
> alpha3 with mvn help:describe
> -Dplugin=org.apache.tuscany.sca:tuscany-zip-plugin.
> I've tried packaging webapps as zip and running them with something like
> node = NodeFactory.newInstance().createNode(new Contribution("foo",
> "target/helloworld-webapp-2.0-SNAPSHOT.zip"));
> node.start();
> but the Tuscany runtime simply logs
> INFO: Loading contribution:
> file:/home/fmoga/coding/apache-tuscany/trunk/samples/getting-started/helloworld-webapp/target/helloworld-webapp-2.0-SNAPSHOT.zip
> and doesn't deploy the webapp. Is this plugin intended to support webapps as
> well? Couldn't find any information related to this in the README.
> Thanks,
> Florian
>
No I don't expect that would work presently, but from what you've said
it sounds like the tuscany-zip-plugin did work ok and create a zip
contribution but the issue is that the NodeFactory Node doesn't know
who to run that as a webapp. Is this something that needs to be
supported, why would you want a webapp not packaged as a .war? Either
way, is this an issue for this plugin release or could it be left for
a later release?
...ant
Re: [VOTE] Release Tuscany Zip Plugin Alpha3 RC2
Posted by Florian Moga <mo...@gmail.com>.
Hi Ant,
It now works fine with the helloworld sample. I've checked and it uses
alpha3 with mvn help:describe
-Dplugin=org.apache.tuscany.sca:tuscany-zip-plugin.
I've tried packaging webapps as zip and running them with something like
node = NodeFactory.newInstance().createNode(new Contribution("foo",
"target/helloworld-webapp-2.0-SNAPSHOT.zip"));
node.start();
but the Tuscany runtime simply logs
INFO: Loading contribution:
file:/home/fmoga/coding/apache-tuscany/trunk/samples/getting-started/helloworld-webapp/target/helloworld-webapp-2.0-SNAPSHOT.zip
and doesn't deploy the webapp. Is this plugin intended to support webapps as
well? Couldn't find any information related to this in the README.
Thanks,
Florian
On Fri, Jun 3, 2011 at 12:06 PM, ant elder <an...@gmail.com> wrote:
> Please vote on releasing the Tuscany Zip Plugin module (RC2).
>
> The change over the alpha2 release is to rename the module from
> maven-zip-plugin to tuscany-zip-plugin, see TUSCANY-3861. This RC2
> fixes the issue Florian found with the old plugin name still being
> referenced.
>
> The tag for the release is:
>
> https://svn.apache.org/repos/asf/tuscany/maven-plugins/tags/tuscany-zip-plugin-alpha3
>
> The Maven staging repository is:
> http://people.apache.org/~antelder/tuscany/tuscany-zip-plugin-alpha3-RC2
>
> +1 from me.
>
> ...ant
>