You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by Guozhang Wang <gu...@linkedin.com> on 2014/08/08 01:18:39 UTC
Review Request 24480: Fix KAFKA-1578
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24480/
-----------------------------------------------------------
Review request for kafka.
Bugs: KAFKA-1578
https://issues.apache.org/jira/browse/KAFKA-1578
Repository: kafka
Description
-------
De-register all listeners on controller designation
Diffs
-----
core/src/main/scala/kafka/controller/KafkaController.scala a7a21df685e01b41154d52614f62d16759adeec2
core/src/main/scala/kafka/controller/PartitionStateMachine.scala 34c70b69dc63bcc9d04633da095f9fef1e0f0fe0
Diff: https://reviews.apache.org/r/24480/diff/
Testing
-------
Thanks,
Guozhang Wang
Re: Review Request 24480: Fix KAFKA-1578
Posted by Jun Rao <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24480/#review50001
-----------------------------------------------------------
Thanks for the patch. Should we unregister the BrokerChangeListener in ReplicaStateMachine too?
- Jun Rao
On Aug. 7, 2014, 11:18 p.m., Guozhang Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24480/
> -----------------------------------------------------------
>
> (Updated Aug. 7, 2014, 11:18 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1578
> https://issues.apache.org/jira/browse/KAFKA-1578
>
>
> Repository: kafka
>
>
> Description
> -------
>
> De-register all listeners on controller designation
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/controller/KafkaController.scala a7a21df685e01b41154d52614f62d16759adeec2
> core/src/main/scala/kafka/controller/PartitionStateMachine.scala 34c70b69dc63bcc9d04633da095f9fef1e0f0fe0
>
> Diff: https://reviews.apache.org/r/24480/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guozhang Wang
>
>
Re: Review Request 24480: Fix KAFKA-1578
Posted by Guozhang Wang <gu...@linkedin.com>.
> On Aug. 8, 2014, 6:10 p.m., Joel Koshy wrote:
> > I don't see a diff with v1 - did you mean to update the diff to deregister the broker change listener as well?
>
> Guozhang Wang wrote:
> You can clikc on "Diff r2" of the previous tab of Review request changed.
My bad actually. The RB is updated now.
- Guozhang
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24480/#review50055
-----------------------------------------------------------
On Aug. 8, 2014, 6:39 p.m., Guozhang Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24480/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2014, 6:39 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1578
> https://issues.apache.org/jira/browse/KAFKA-1578
>
>
> Repository: kafka
>
>
> Description
> -------
>
> De-register all listeners on controller designation
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/controller/KafkaController.scala a7a21df685e01b41154d52614f62d16759adeec2
> core/src/main/scala/kafka/controller/PartitionStateMachine.scala 34c70b69dc63bcc9d04633da095f9fef1e0f0fe0
> core/src/main/scala/kafka/controller/ReplicaStateMachine.scala ad9c7c4001ef13f6e1bbb6334febf31c04724f46
>
> Diff: https://reviews.apache.org/r/24480/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guozhang Wang
>
>
Re: Review Request 24480: Fix KAFKA-1578
Posted by Guozhang Wang <gu...@linkedin.com>.
> On Aug. 8, 2014, 6:10 p.m., Joel Koshy wrote:
> > I don't see a diff with v1 - did you mean to update the diff to deregister the broker change listener as well?
You can clikc on "Diff r2" of the previous tab of Review request changed.
- Guozhang
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24480/#review50055
-----------------------------------------------------------
On Aug. 8, 2014, 5:28 p.m., Guozhang Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24480/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2014, 5:28 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1578
> https://issues.apache.org/jira/browse/KAFKA-1578
>
>
> Repository: kafka
>
>
> Description
> -------
>
> De-register all listeners on controller designation
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/controller/KafkaController.scala a7a21df685e01b41154d52614f62d16759adeec2
> core/src/main/scala/kafka/controller/PartitionStateMachine.scala 34c70b69dc63bcc9d04633da095f9fef1e0f0fe0
>
> Diff: https://reviews.apache.org/r/24480/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guozhang Wang
>
>
Re: Review Request 24480: Fix KAFKA-1578
Posted by Joel Koshy <jj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24480/#review50055
-----------------------------------------------------------
I don't see a diff with v1 - did you mean to update the diff to deregister the broker change listener as well?
- Joel Koshy
On Aug. 8, 2014, 5:28 p.m., Guozhang Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24480/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2014, 5:28 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1578
> https://issues.apache.org/jira/browse/KAFKA-1578
>
>
> Repository: kafka
>
>
> Description
> -------
>
> De-register all listeners on controller designation
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/controller/KafkaController.scala a7a21df685e01b41154d52614f62d16759adeec2
> core/src/main/scala/kafka/controller/PartitionStateMachine.scala 34c70b69dc63bcc9d04633da095f9fef1e0f0fe0
>
> Diff: https://reviews.apache.org/r/24480/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guozhang Wang
>
>
Re: Review Request 24480: Fix KAFKA-1578
Posted by Jun Rao <ju...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24480/#review50069
-----------------------------------------------------------
Looks good. Just a couple of minor comments below.
core/src/main/scala/kafka/controller/ReplicaStateMachine.scala
<https://reviews.apache.org/r/24480/#comment87591>
Ditto as below.
core/src/main/scala/kafka/controller/ReplicaStateMachine.scala
<https://reviews.apache.org/r/24480/#comment87590>
This is not the replica manager.
- Jun Rao
On Aug. 8, 2014, 6:39 p.m., Guozhang Wang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24480/
> -----------------------------------------------------------
>
> (Updated Aug. 8, 2014, 6:39 p.m.)
>
>
> Review request for kafka.
>
>
> Bugs: KAFKA-1578
> https://issues.apache.org/jira/browse/KAFKA-1578
>
>
> Repository: kafka
>
>
> Description
> -------
>
> De-register all listeners on controller designation
>
>
> Diffs
> -----
>
> core/src/main/scala/kafka/controller/KafkaController.scala a7a21df685e01b41154d52614f62d16759adeec2
> core/src/main/scala/kafka/controller/PartitionStateMachine.scala 34c70b69dc63bcc9d04633da095f9fef1e0f0fe0
> core/src/main/scala/kafka/controller/ReplicaStateMachine.scala ad9c7c4001ef13f6e1bbb6334febf31c04724f46
>
> Diff: https://reviews.apache.org/r/24480/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Guozhang Wang
>
>
Re: Review Request 24480: Fix KAFKA-1578
Posted by Guozhang Wang <gu...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24480/
-----------------------------------------------------------
(Updated Aug. 8, 2014, 8:13 p.m.)
Review request for kafka.
Bugs: KAFKA-1578
https://issues.apache.org/jira/browse/KAFKA-1578
Repository: kafka
Description
-------
De-register all listeners on controller designation
Diffs (updated)
-----
core/src/main/scala/kafka/controller/KafkaController.scala a7a21df685e01b41154d52614f62d16759adeec2
core/src/main/scala/kafka/controller/PartitionStateMachine.scala 34c70b69dc63bcc9d04633da095f9fef1e0f0fe0
core/src/main/scala/kafka/controller/ReplicaStateMachine.scala ad9c7c4001ef13f6e1bbb6334febf31c04724f46
Diff: https://reviews.apache.org/r/24480/diff/
Testing
-------
Thanks,
Guozhang Wang
Re: Review Request 24480: Fix KAFKA-1578
Posted by Guozhang Wang <gu...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24480/
-----------------------------------------------------------
(Updated Aug. 8, 2014, 6:39 p.m.)
Review request for kafka.
Bugs: KAFKA-1578
https://issues.apache.org/jira/browse/KAFKA-1578
Repository: kafka
Description
-------
De-register all listeners on controller designation
Diffs (updated)
-----
core/src/main/scala/kafka/controller/KafkaController.scala a7a21df685e01b41154d52614f62d16759adeec2
core/src/main/scala/kafka/controller/PartitionStateMachine.scala 34c70b69dc63bcc9d04633da095f9fef1e0f0fe0
core/src/main/scala/kafka/controller/ReplicaStateMachine.scala ad9c7c4001ef13f6e1bbb6334febf31c04724f46
Diff: https://reviews.apache.org/r/24480/diff/
Testing
-------
Thanks,
Guozhang Wang
Re: Review Request 24480: Fix KAFKA-1578
Posted by Guozhang Wang <gu...@linkedin.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24480/
-----------------------------------------------------------
(Updated Aug. 8, 2014, 5:28 p.m.)
Review request for kafka.
Bugs: KAFKA-1578
https://issues.apache.org/jira/browse/KAFKA-1578
Repository: kafka
Description
-------
De-register all listeners on controller designation
Diffs (updated)
-----
core/src/main/scala/kafka/controller/KafkaController.scala a7a21df685e01b41154d52614f62d16759adeec2
core/src/main/scala/kafka/controller/PartitionStateMachine.scala 34c70b69dc63bcc9d04633da095f9fef1e0f0fe0
Diff: https://reviews.apache.org/r/24480/diff/
Testing
-------
Thanks,
Guozhang Wang