You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2023/01/10 19:49:18 UTC
[GitHub] [nuttx] xiaoxiang781216 commented on a diff in pull request #5999: fs/sync: add sync and syncfs api
xiaoxiang781216 commented on code in PR #5999:
URL: https://github.com/apache/nuttx/pull/5999#discussion_r1066247349
##########
libs/libc/unistd/lib_sync.c:
##########
@@ -0,0 +1,85 @@
+/****************************************************************************
+ * libs/libc/unistd/lib_sync.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+/****************************************************************************
+ * Pre-processor Definitions
+ ****************************************************************************/
+
+/****************************************************************************
+ * Private Type Definitions
+ ****************************************************************************/
+
+/****************************************************************************
+ * Public Data
+ ****************************************************************************/
+
+/****************************************************************************
+ * Private Data
+ ****************************************************************************/
+
+/****************************************************************************
+ * Private Function Prototypes
+ ****************************************************************************/
+
+/****************************************************************************
+ * Public Functions
+ ****************************************************************************/
+
+/****************************************************************************
+ * Name: sync
+ *
+ * Description:
+ * sync() causes all pending modifications to filesystem metadata and
+ * cached file data to be written to the underlying filesystems.
+ *
+ * Returned Value:
+ * sync() is always successful.
+ *
+ * Assumptions:
+ *
+ ****************************************************************************/
+
+void sync(void)
+{
+}
+
+/****************************************************************************
+ * Name: syncfs
+ *
+ * Description:
+ * syncfs() is like sync(), but synchronizes just the filesystem
+ * containing file referred to by the open file descriptor fd.
+ *
+ * Returned Value:
+ * syncfs() returns 0 on success; on error, it returns -1 and sets
+ * errno to indicate the error.
+ *
+ * Assumptions:
+ *
+ ****************************************************************************/
+
+int syncfs(int fd)
+{
+ return 0;
Review Comment:
@Donny9 we can forward to fsync directly
##########
libs/libc/unistd/lib_sync.c:
##########
@@ -0,0 +1,85 @@
+/****************************************************************************
+ * libs/libc/unistd/lib_sync.c
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership. The
+ * ASF licenses this file to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
+ * License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT
+ * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+ * License for the specific language governing permissions and limitations
+ * under the License.
+ *
+ ****************************************************************************/
+
+/****************************************************************************
+ * Included Files
+ ****************************************************************************/
+
+/****************************************************************************
+ * Pre-processor Definitions
+ ****************************************************************************/
+
+/****************************************************************************
+ * Private Type Definitions
+ ****************************************************************************/
+
+/****************************************************************************
+ * Public Data
+ ****************************************************************************/
+
+/****************************************************************************
+ * Private Data
+ ****************************************************************************/
+
+/****************************************************************************
+ * Private Function Prototypes
+ ****************************************************************************/
+
+/****************************************************************************
+ * Public Functions
+ ****************************************************************************/
+
+/****************************************************************************
+ * Name: sync
+ *
+ * Description:
+ * sync() causes all pending modifications to filesystem metadata and
+ * cached file data to be written to the underlying filesystems.
+ *
+ * Returned Value:
+ * sync() is always successful.
+ *
+ * Assumptions:
+ *
+ ****************************************************************************/
+
+void sync(void)
+{
Review Comment:
maybe we can iterate through all process and then file table
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org