You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "Ngone51 (via GitHub)" <gi...@apache.org> on 2023/02/07 13:44:50 UTC
[GitHub] [spark] Ngone51 commented on a diff in pull request #39903: [SPARK-42358][CORE] Send ExecutorUpdated with the message argument in Master.removeWorker
Ngone51 commented on code in PR #39903:
URL: https://github.com/apache/spark/pull/39903#discussion_r1098678730
##########
core/src/main/scala/org/apache/spark/deploy/master/Master.scala:
##########
@@ -962,7 +962,7 @@ private[deploy] class Master(
for (exec <- worker.executors.values) {
logInfo("Telling app of lost executor: " + exec.id)
exec.application.driver.send(ExecutorUpdated(
- exec.id, ExecutorState.LOST, Some("worker lost"), None, Some(worker.host)))
+ exec.id, ExecutorState.LOST, Some(msg), None, Some(worker.host)))
Review Comment:
How about
```suggestion
exec.id, ExecutorState.LOST, Some(s"worker lost: $msg"), None, Some(worker.host)))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org