You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2019/11/08 21:39:51 UTC
[GitHub] [incubator-druid] surekhasaharan commented on issue #8810: Make
submit task API similar to supervisor API
surekhasaharan commented on issue #8810: Make submit task API similar to supervisor API
URL: https://github.com/apache/incubator-druid/pull/8810#issuecomment-551999456
> Please fix LGTM alert.
Yeah, i looked at that, it thinks `dataSchema` can be null [here](https://github.com/apache/incubator-druid/pull/8810/files#diff-0ce554adcd07cc3ea613b457eb800164R208) because of test cases, where null is passed for `dataSchema`, though those tests pass a valid `ingestionSchema`, and it's already checked in [here](https://github.com/apache/incubator-druid/pull/8810/files#diff-0ce554adcd07cc3ea613b457eb800164R133). Not sure how to make lgtm ignore that or fix otherwise.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org