You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Marton Greber (Code Review)" <ge...@cloudera.org> on 2023/12/18 18:52:04 UTC
[kudu-CR](gh-pages) Add blog post about Prometheus/Grafana
Marton Greber has uploaded this change for review. ( http://gerrit.cloudera.org:8080/20814
Change subject: Add blog post about Prometheus/Grafana
......................................................................
Add blog post about Prometheus/Grafana
While the review is ongoing I'm hosting this patch on my GitHub page:
https://martongreber.github.io/2023/12/18/kudu-prometheus-grafana.html
Change-Id: I85878378f883b2cc1f8136bde2c9f0db7ceccd8f
---
A _posts/2023-12-18-kudu-prometheus-grafana.md
A img/2023-12-18-kudu-prometheus-grafana/master-tserver-memory.png
A img/2023-12-18-kudu-prometheus-grafana/metrics-explorer.png
A img/2023-12-18-kudu-prometheus-grafana/prometheus-targets.png
4 files changed, 176 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/14/20814/1
--
To view, visit http://gerrit.cloudera.org:8080/20814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: newchange
Gerrit-Change-Id: I85878378f883b2cc1f8136bde2c9f0db7ceccd8f
Gerrit-Change-Number: 20814
Gerrit-PatchSet: 1
Gerrit-Owner: Marton Greber <gr...@gmail.com>
[kudu-CR](gh-pages) Add blog post about Prometheus/Grafana
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20814 )
Change subject: Add blog post about Prometheus/Grafana
......................................................................
Patch Set 1:
(3 comments)
Thank you for working on a blog post! That's been quite long time since last blog posted at Apache Kudu website.
http://gerrit.cloudera.org:8080/#/c/20814/1/_posts/2023-12-18-kudu-prometheus-grafana.md
File _posts/2023-12-18-kudu-prometheus-grafana.md:
http://gerrit.cloudera.org:8080/#/c/20814/1/_posts/2023-12-18-kudu-prometheus-grafana.md@18
PS1, Line 18: JMX format
I'm not sure what 'JMX format' means, but I might be missing something. Could you provide a few references, so I could learn about the 'JMX format'?
As we discussed offline already, I don't think mentioning JMX framework is quite relevant in this context. If there is an idea to point that there is no need to perform any transformations for Kudu metrics produced by the '/metrics' kudu-master/kudu-tserver endpoints, let's do so in a more generic way, maybe?
If it's desirable to add more specifics (which I'm not sure about, frankly: why to so that in this blog?), maybe mention a few common ways how people usually build bridges between metric sources of arbitrary formats and Prometheus. But mentioning only the JMX framework (which is Java-specific) seems to be irrelevant both to Prometheus as a consumer (Go) and Kudu server-side as a producer (C++).
http://gerrit.cloudera.org:8080/#/c/20814/1/_posts/2023-12-18-kudu-prometheus-grafana.md@17
PS1, Line 17: to add
: custom jars
Add custom JARs where?
http://gerrit.cloudera.org:8080/#/c/20814/1/_posts/2023-12-18-kudu-prometheus-grafana.md@172
PS1, Line 172: can create a script which parses the TServer addresses
Consider mentioning KUDU-3538: ideally, Kudu masters could implement HTTP Service Discovery for Prometheus. Once implemented, it will be enough to specify the SD URL(s) in the Prometheus config file.
Alternatively, you could try to implement that trivial enhancement first, and then update this blog post :)
--
To view, visit http://gerrit.cloudera.org:8080/20814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I85878378f883b2cc1f8136bde2c9f0db7ceccd8f
Gerrit-Change-Number: 20814
Gerrit-PatchSet: 1
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 Jan 2024 04:10:48 +0000
Gerrit-HasComments: Yes
[kudu-CR](gh-pages) Add blog post about Prometheus/Grafana
Posted by "Gabriella Lotz (Code Review)" <ge...@cloudera.org>.
Gabriella Lotz has posted comments on this change. ( http://gerrit.cloudera.org:8080/20814 )
Change subject: Add blog post about Prometheus/Grafana
......................................................................
Patch Set 5: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/20814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I85878378f883b2cc1f8136bde2c9f0db7ceccd8f
Gerrit-Change-Number: 20814
Gerrit-PatchSet: 5
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yan-Daojiang <ya...@163.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 13 Jul 2026 08:46:28 +0000
Gerrit-HasComments: No
[kudu-CR](gh-pages) Add blog post about Prometheus/Grafana
Posted by "Zoltan Chovan (Code Review)" <ge...@cloudera.org>.
Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/20814 )
Change subject: Add blog post about Prometheus/Grafana
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit http://gerrit.cloudera.org:8080/20814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I85878378f883b2cc1f8136bde2c9f0db7ceccd8f
Gerrit-Change-Number: 20814
Gerrit-PatchSet: 2
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 06 Jul 2026 07:08:07 +0000
Gerrit-HasComments: No
[kudu-CR](gh-pages) Add blog post about Prometheus/Grafana
Posted by "Yan-Daojiang (Code Review)" <ge...@cloudera.org>.
Yan-Daojiang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20814 )
Change subject: Add blog post about Prometheus/Grafana
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/20814/1/_posts/2023-12-18-kudu-prometheus-grafana.md
File _posts/2023-12-18-kudu-prometheus-grafana.md:
http://gerrit.cloudera.org:8080/#/c/20814/1/_posts/2023-12-18-kudu-prometheus-grafana.md@24
PS1, Line 24:
> I posted my original comment on PS1 in January 2024. As of July 2026 the t
I have one question I'd like to ask. Now that tablet-level metrics are fully supported in Prometheus format, has the community evaluated their impact in deployments with a very large number of tablets? In particular, I'm wondering whether metric cardinality has been a concern in practice, since a large number of tablets could result in a large number of unique label combinations and potentially increase the load on both Kudu Tablet Servers and Prometheus.
--
To view, visit http://gerrit.cloudera.org:8080/20814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I85878378f883b2cc1f8136bde2c9f0db7ceccd8f
Gerrit-Change-Number: 20814
Gerrit-PatchSet: 2
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yan-Daojiang <ya...@163.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 07 Jul 2026 03:33:32 +0000
Gerrit-HasComments: Yes
[kudu-CR](gh-pages) Add blog post about Prometheus/Grafana
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/20814 )
Change subject: Add blog post about Prometheus/Grafana
......................................................................
Patch Set 5: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/20814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I85878378f883b2cc1f8136bde2c9f0db7ceccd8f
Gerrit-Change-Number: 20814
Gerrit-PatchSet: 5
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yan-Daojiang <ya...@163.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Thu, 16 Jul 2026 12:01:52 +0000
Gerrit-HasComments: No
[kudu-CR](gh-pages) Add blog post about Prometheus/Grafana
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/20814 )
Change subject: Add blog post about Prometheus/Grafana
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/20814/2/_posts/2026-07-03-kudu-prometheus-grafana.md
File _posts/2026-07-03-kudu-prometheus-grafana.md:
http://gerrit.cloudera.org:8080/#/c/20814/2/_posts/2026-07-03-kudu-prometheus-grafana.md@42
PS2, Line 42:
:
:
:
:
:
:
:
:
:
:
:
:
:
:
:
> Thanks for fixing that! One more though: under scrape_configs, the keys in
Makes sense it was inconsistent. Ran the two ymls through a formatter, now they should be good.
--
To view, visit http://gerrit.cloudera.org:8080/20814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I85878378f883b2cc1f8136bde2c9f0db7ceccd8f
Gerrit-Change-Number: 20814
Gerrit-PatchSet: 1
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yan-Daojiang <ya...@163.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Fri, 10 Jul 2026 10:10:20 +0000
Gerrit-HasComments: Yes
[kudu-CR](gh-pages) Add blog post about Prometheus/Grafana
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/20814 )
Change subject: Add blog post about Prometheus/Grafana
......................................................................
Patch Set 1:
(8 comments)
Removed self hosted website url, adding it here in the comments for easier review:
https://kudu-site-659861.gitlab.io/2026/07/03/kudu-prometheus-grafana.html
http://gerrit.cloudera.org:8080/#/c/20814/1/_posts/2023-12-18-kudu-prometheus-grafana.md
File _posts/2023-12-18-kudu-prometheus-grafana.md:
http://gerrit.cloudera.org:8080/#/c/20814/1/_posts/2023-12-18-kudu-prometheus-grafana.md@24
PS1, Line 24:
> I have one question I'd like to ask. Now that tablet-level metrics are full
Added a small capability section where `prometheus_use_entity_labels` is mentioned.
Regarding metric cardinality and load: I dont think we've any reports/measurements for that so far. But its a valid point that we could keep in mind for testing etc.
http://gerrit.cloudera.org:8080/#/c/20814/2/_posts/2026-07-03-kudu-prometheus-grafana.md
File _posts/2026-07-03-kudu-prometheus-grafana.md:
http://gerrit.cloudera.org:8080/#/c/20814/2/_posts/2026-07-03-kudu-prometheus-grafana.md@8
PS2, Line 8:
> nit: the outer parentheses around the link read like a typo. I think withou
Done
http://gerrit.cloudera.org:8080/#/c/20814/2/_posts/2026-07-03-kudu-prometheus-grafana.md@20
PS2, Line 20:
> web server
Done
http://gerrit.cloudera.org:8080/#/c/20814/2/_posts/2026-07-03-kudu-prometheus-grafana.md@21
PS2, Line 21:
> Does it make sense to mention tweaking --prometheus_use_entity_labels flag
Yes, added a section at the very end "Capability Notes" where i outlined this flag.
http://gerrit.cloudera.org:8080/#/c/20814/2/_posts/2026-07-03-kudu-prometheus-grafana.md@42
PS2, Line 42:
:
:
:
:
:
:
:
:
:
:
:
:
:
:
:
> I think this YAML isn't valid: scrape_interval/evaluation_interval are at t
Done
http://gerrit.cloudera.org:8080/#/c/20814/2/_posts/2026-07-03-kudu-prometheus-grafana.md@80
PS2, Line 80:
> nit: trailing whitespace.
Yes the numbering was not working as expected here, fixed.
http://gerrit.cloudera.org:8080/#/c/20814/2/_posts/2026-07-03-kudu-prometheus-grafana.md@107
PS2, Line 107:
:
:
:
:
:
:
:
:
:
:
:
:
> same as the other yaml.
Done
http://gerrit.cloudera.org:8080/#/c/20814/2/_posts/2026-07-03-kudu-prometheus-grafana.md@154
PS2, Line 154:
> nit: missing trailing newline at the end of the file.
Done
--
To view, visit http://gerrit.cloudera.org:8080/20814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I85878378f883b2cc1f8136bde2c9f0db7ceccd8f
Gerrit-Change-Number: 20814
Gerrit-PatchSet: 1
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yan-Daojiang <ya...@163.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 08 Jul 2026 09:38:16 +0000
Gerrit-HasComments: Yes
[kudu-CR](gh-pages) Add blog post about Prometheus/Grafana
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20814 )
Change subject: Add blog post about Prometheus/Grafana
......................................................................
Patch Set 2: Code-Review+1
(3 comments)
Thank you for revving the patch!
http://gerrit.cloudera.org:8080/#/c/20814/1/_posts/2023-12-18-kudu-prometheus-grafana.md
File _posts/2023-12-18-kudu-prometheus-grafana.md:
http://gerrit.cloudera.org:8080/#/c/20814/1/_posts/2023-12-18-kudu-prometheus-grafana.md@24
PS1, Line 24:
> I agree with Alexey that we should document the current capability limits i
I posted my original comment on PS1 in January 2024. As of July 2026 the tablet-level metrics are now available in Prometheus format since KUDU-3563 had been implemented and then refined with KUDU-3692.
IIUC, with KUDU-3563 and KUDU-3692 implemented, tablet-level metrics are available in Prometheus format. The --prometheus_use_entity_labels flag controls the way they are represented in the output. Please correct me if I'm wrong.
In this context, I'd also consider informing the reader that --prometheus_use_entity_labels stays 'false' by default due to backward compatibility reasons, and it's necessary to tweak the flag to allow for natural aggregation of the metrics.
http://gerrit.cloudera.org:8080/#/c/20814/2/_posts/2026-07-03-kudu-prometheus-grafana.md
File _posts/2026-07-03-kudu-prometheus-grafana.md:
http://gerrit.cloudera.org:8080/#/c/20814/2/_posts/2026-07-03-kudu-prometheus-grafana.md@20
PS2, Line 20: web UI
web server
http://gerrit.cloudera.org:8080/#/c/20814/2/_posts/2026-07-03-kudu-prometheus-grafana.md@21
PS2, Line 21: aggregation
Does it make sense to mention tweaking --prometheus_use_entity_labels flag to enable various levels of aggregation for the exposed metrics? I'd also think of mentioning that the current default value of --prometheus_use_entity_labels is chosen to preserve backwards compatibility with the legacy naming scheme of the Kudu's metrics in Prometheus format.
I guess it's also worth it recommending to set --prometheus_use_entity_labels=1 when starting from scratch, i.e. if there aren't any components that expect the legacy format of the Kudu's metrics exposed in Prometheus format.
--
To view, visit http://gerrit.cloudera.org:8080/20814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I85878378f883b2cc1f8136bde2c9f0db7ceccd8f
Gerrit-Change-Number: 20814
Gerrit-PatchSet: 2
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yan-Daojiang <ya...@163.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 06 Jul 2026 22:34:30 +0000
Gerrit-HasComments: Yes
[kudu-CR](gh-pages) Add blog post about Prometheus/Grafana
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Chovan, Alexey Serbin, Gabriella Lotz, Attila Bukor, Yan-Daojiang,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20814
to look at the new patch set (#3).
Change subject: Add blog post about Prometheus/Grafana
......................................................................
Add blog post about Prometheus/Grafana
Change-Id: I85878378f883b2cc1f8136bde2c9f0db7ceccd8f
---
A _posts/2026-07-03-kudu-prometheus-grafana.md
A img/2026-07-03-kudu-prometheus-grafana/master-tserver-memory.png
A img/2026-07-03-kudu-prometheus-grafana/metrics-browser.png
A img/2026-07-03-kudu-prometheus-grafana/prometheus-targets.png
4 files changed, 165 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/14/20814/3
--
To view, visit http://gerrit.cloudera.org:8080/20814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I85878378f883b2cc1f8136bde2c9f0db7ceccd8f
Gerrit-Change-Number: 20814
Gerrit-PatchSet: 3
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yan-Daojiang <ya...@163.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR](gh-pages) Add blog post about Prometheus/Grafana
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/20814 )
Change subject: Add blog post about Prometheus/Grafana
......................................................................
Add blog post about Prometheus/Grafana
Change-Id: I85878378f883b2cc1f8136bde2c9f0db7ceccd8f
Reviewed-on: http://gerrit.cloudera.org:8080/20814
Reviewed-by: Alexey Serbin <al...@apache.org>
Reviewed-by: Yan-Daojiang <ya...@163.com>
Reviewed-by: Gabriella Lotz <lo...@gmail.com>
Tested-by: Marton Greber <gr...@gmail.com>
---
A _posts/2026-07-03-kudu-prometheus-grafana.md
A img/2026-07-03-kudu-prometheus-grafana/master-tserver-memory.png
A img/2026-07-03-kudu-prometheus-grafana/metrics-browser.png
A img/2026-07-03-kudu-prometheus-grafana/prometheus-targets.png
4 files changed, 163 insertions(+), 0 deletions(-)
Approvals:
Alexey Serbin: Looks good to me, approved
Yan-Daojiang: Looks good to me, but someone else must approve
Gabriella Lotz: Looks good to me, but someone else must approve
Marton Greber: Verified
--
To view, visit http://gerrit.cloudera.org:8080/20814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: merged
Gerrit-Change-Id: I85878378f883b2cc1f8136bde2c9f0db7ceccd8f
Gerrit-Change-Number: 20814
Gerrit-PatchSet: 6
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yan-Daojiang <ya...@163.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR](gh-pages) Add blog post about Prometheus/Grafana
Posted by "Yan-Daojiang (Code Review)" <ge...@cloudera.org>.
Yan-Daojiang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20814 )
Change subject: Add blog post about Prometheus/Grafana
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/20814/1/_posts/2023-12-18-kudu-prometheus-grafana.md
File _posts/2023-12-18-kudu-prometheus-grafana.md:
http://gerrit.cloudera.org:8080/#/c/20814/1/_posts/2023-12-18-kudu-prometheus-grafana.md@24
PS1, Line 24:
> Not sure if its worth calling out with all the improvements. It comes in 'h
I agree with Alexey that we should document the current capability limits in the blog.
One follow-up question: what's the community roadmap for tablet-level Prometheus metrics? Tablet-level metrics were introduced in Kudu 1.18, and I refined their Prometheus compatibility in KUDU-3692 [1]. Does this mean that tablet-level metrics are now fully available through Kudu's Prometheus endpoint?
[1] https://issues.apache.org/jira/browse/KUDU-3692
--
To view, visit http://gerrit.cloudera.org:8080/20814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I85878378f883b2cc1f8136bde2c9f0db7ceccd8f
Gerrit-Change-Number: 20814
Gerrit-PatchSet: 2
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yan-Daojiang <ya...@163.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 06 Jul 2026 11:05:21 +0000
Gerrit-HasComments: Yes
[kudu-CR](gh-pages) Add blog post about Prometheus/Grafana
Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/20814 )
Change subject: Add blog post about Prometheus/Grafana
......................................................................
Patch Set 1:
(4 comments)
http://gerrit.cloudera.org:8080/#/c/20814/1/_posts/2023-12-18-kudu-prometheus-grafana.md
File _posts/2023-12-18-kudu-prometheus-grafana.md:
http://gerrit.cloudera.org:8080/#/c/20814/1/_posts/2023-12-18-kudu-prometheus-grafana.md@44
PS1, Line 44: # Set the interval at which Prometheus will scrape metrics for this job (5 seconds in this case)
nit: break the line
http://gerrit.cloudera.org:8080/#/c/20814/1/_posts/2023-12-18-kudu-prometheus-grafana.md@55
PS1, Line 55: - targets: ['localhost:8765', 'localhost:8767', 'localhost:8769']
how about using master1.example.com:8765 etc or some such instead of varying the ports? I think it's best to use examples similar to real-word setups rather than localhost/dev setups.
http://gerrit.cloudera.org:8080/#/c/20814/1/_posts/2023-12-18-kudu-prometheus-grafana.md@63
PS1, Line 63: - targets: ['localhost:9871', 'localhost:9873', 'localhost:9875']
same here
http://gerrit.cloudera.org:8080/#/c/20814/1/_posts/2023-12-18-kudu-prometheus-grafana.md@93
PS1, Line 93: <div align="center">
do we need the div etc here? can we get away with markdown tags only?
--
To view, visit http://gerrit.cloudera.org:8080/20814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I85878378f883b2cc1f8136bde2c9f0db7ceccd8f
Gerrit-Change-Number: 20814
Gerrit-PatchSet: 1
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Tue, 02 Jan 2024 10:07:14 +0000
Gerrit-HasComments: Yes
[kudu-CR](gh-pages) Add blog post about Prometheus/Grafana
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/20814 )
Change subject: Add blog post about Prometheus/Grafana
......................................................................
Patch Set 1:
(8 comments)
After a while, with Prometheus features done I've sat down to revise this blog post.
If you have time please take a look.
Thank you!
http://gerrit.cloudera.org:8080/#/c/20814/1/_posts/2023-12-18-kudu-prometheus-grafana.md
File _posts/2023-12-18-kudu-prometheus-grafana.md:
http://gerrit.cloudera.org:8080/#/c/20814/1/_posts/2023-12-18-kudu-prometheus-grafana.md@18
PS1, Line 18: JMX format
> I'm not sure what 'JMX format' means, but I might be missing something. Co
Removed this part.
http://gerrit.cloudera.org:8080/#/c/20814/1/_posts/2023-12-18-kudu-prometheus-grafana.md@24
PS1, Line 24:
> Do you think it's worth mentioning that currently Kudu exports only server-
Not sure if its worth calling out with all the improvements. It comes in 'handy' that since 2023 a bunch of improvements went in for Prometheus, making it more feature complete. Hence the blog post can carry this notification signal.
Anyway let me know if you think its worthwhile to call out what we have in the current state in terms of Prometheus features.
http://gerrit.cloudera.org:8080/#/c/20814/1/_posts/2023-12-18-kudu-prometheus-grafana.md@33
PS1, Line 33: ## Prometheus Configuration for Kudu
> As a side note, it would be much easier to integrate with Prometheus if Kud
Done
http://gerrit.cloudera.org:8080/#/c/20814/1/_posts/2023-12-18-kudu-prometheus-grafana.md@44
PS1, Line 44: # Set the interval at which Prometheus will scrape metrics for this job (5 seconds in this case)
> nit: break the line
Done
http://gerrit.cloudera.org:8080/#/c/20814/1/_posts/2023-12-18-kudu-prometheus-grafana.md@55
PS1, Line 55: - targets: ['localhost:8765', 'localhost:8767', 'localhost:8769']
> how about using master1.example.com:8765 etc or some such instead of varyin
Done
http://gerrit.cloudera.org:8080/#/c/20814/1/_posts/2023-12-18-kudu-prometheus-grafana.md@63
PS1, Line 63: - targets: ['localhost:9871', 'localhost:9873', 'localhost:9875']
> same here
Done
http://gerrit.cloudera.org:8080/#/c/20814/1/_posts/2023-12-18-kudu-prometheus-grafana.md@93
PS1, Line 93: <div align="center">
> do we need the div etc here? can we get away with markdown tags only?
Done
http://gerrit.cloudera.org:8080/#/c/20814/1/_posts/2023-12-18-kudu-prometheus-grafana.md@172
PS1, Line 172: can create a script which parses the TServer addresses
> Consider mentioning KUDU-3538: ideally, Kudu masters could implement HTTP S
Removed this old approach, and replaced this section with SD details.
--
To view, visit http://gerrit.cloudera.org:8080/20814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I85878378f883b2cc1f8136bde2c9f0db7ceccd8f
Gerrit-Change-Number: 20814
Gerrit-PatchSet: 1
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Fri, 03 Jul 2026 16:59:31 +0000
Gerrit-HasComments: Yes
[kudu-CR](gh-pages) Add blog post about Prometheus/Grafana
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/20814 )
Change subject: Add blog post about Prometheus/Grafana
......................................................................
Patch Set 1:
Thanks everyone for the reviews!
I also think it makes sense to first implement the SD: KUDU-3538.
I will do that, once it is merged I will circle back to update the blog post.
--
To view, visit http://gerrit.cloudera.org:8080/20814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I85878378f883b2cc1f8136bde2c9f0db7ceccd8f
Gerrit-Change-Number: 20814
Gerrit-PatchSet: 1
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 Jan 2024 16:50:50 +0000
Gerrit-HasComments: No
[kudu-CR](gh-pages) Add blog post about Prometheus/Grafana
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Chovan, Alexey Serbin, Gabriella Lotz, Attila Bukor, Yan-Daojiang,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20814
to look at the new patch set (#4).
Change subject: Add blog post about Prometheus/Grafana
......................................................................
Add blog post about Prometheus/Grafana
Change-Id: I85878378f883b2cc1f8136bde2c9f0db7ceccd8f
---
A _posts/2026-07-03-kudu-prometheus-grafana.md
A img/2026-07-03-kudu-prometheus-grafana/master-tserver-memory.png
A img/2026-07-03-kudu-prometheus-grafana/metrics-browser.png
A img/2026-07-03-kudu-prometheus-grafana/prometheus-targets.png
4 files changed, 163 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/14/20814/4
--
To view, visit http://gerrit.cloudera.org:8080/20814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I85878378f883b2cc1f8136bde2c9f0db7ceccd8f
Gerrit-Change-Number: 20814
Gerrit-PatchSet: 4
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yan-Daojiang <ya...@163.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR](gh-pages) Add blog post about Prometheus/Grafana
Posted by "Gabriella Lotz (Code Review)" <ge...@cloudera.org>.
Gabriella Lotz has posted comments on this change. ( http://gerrit.cloudera.org:8080/20814 )
Change subject: Add blog post about Prometheus/Grafana
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/20814/2/_posts/2026-07-03-kudu-prometheus-grafana.md
File _posts/2026-07-03-kudu-prometheus-grafana.md:
http://gerrit.cloudera.org:8080/#/c/20814/2/_posts/2026-07-03-kudu-prometheus-grafana.md@42
PS2, Line 42: ```yaml
: global:
: scrape_interval: 15s
: evaluation_interval: 15s
:
: scrape_configs:
: - job_name: 'kudu'
: metrics_path: '/metrics_prometheus'
: static_configs:
: - targets: ['master-1:8051', 'master-2:8051', 'master-3:8051']
: labels:
: group: 'masters'
: - targets: ['tserver-1:8050', 'tserver-2:8050', 'tserver-3:8050']
: labels:
: group: 'tservers'
: ```
> Done
Thanks for fixing that! One more though: under scrape_configs, the keys in the list item (metrics_path, static_configs) have two extra spaces. They should line up with job_name rather than being indented past it, otherwise it doesn't parse. Same in the snippet below.
--
To view, visit http://gerrit.cloudera.org:8080/20814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I85878378f883b2cc1f8136bde2c9f0db7ceccd8f
Gerrit-Change-Number: 20814
Gerrit-PatchSet: 3
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yan-Daojiang <ya...@163.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 08 Jul 2026 13:59:05 +0000
Gerrit-HasComments: Yes
[kudu-CR](gh-pages) Add blog post about Prometheus/Grafana
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20814 )
Change subject: Add blog post about Prometheus/Grafana
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/20814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I85878378f883b2cc1f8136bde2c9f0db7ceccd8f
Gerrit-Change-Number: 20814
Gerrit-PatchSet: 5
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yan-Daojiang <ya...@163.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Fri, 10 Jul 2026 16:26:04 +0000
Gerrit-HasComments: No
[kudu-CR](gh-pages) Add blog post about Prometheus/Grafana
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Chovan, Alexey Serbin, Gabriella Lotz, Attila Bukor, Yan-Daojiang,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20814
to look at the new patch set (#5).
Change subject: Add blog post about Prometheus/Grafana
......................................................................
Add blog post about Prometheus/Grafana
Change-Id: I85878378f883b2cc1f8136bde2c9f0db7ceccd8f
---
A _posts/2026-07-03-kudu-prometheus-grafana.md
A img/2026-07-03-kudu-prometheus-grafana/master-tserver-memory.png
A img/2026-07-03-kudu-prometheus-grafana/metrics-browser.png
A img/2026-07-03-kudu-prometheus-grafana/prometheus-targets.png
4 files changed, 163 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/14/20814/5
--
To view, visit http://gerrit.cloudera.org:8080/20814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I85878378f883b2cc1f8136bde2c9f0db7ceccd8f
Gerrit-Change-Number: 20814
Gerrit-PatchSet: 5
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yan-Daojiang <ya...@163.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR](gh-pages) Add blog post about Prometheus/Grafana
Posted by "Marton Greber (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Chovan, Alexey Serbin, Attila Bukor,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/20814
to look at the new patch set (#2).
Change subject: Add blog post about Prometheus/Grafana
......................................................................
Add blog post about Prometheus/Grafana
While the review is ongoing I'm hosting this patch on my Gitlab page:
https://kudu-site-659861.gitlab.io/2026/07/03/kudu-prometheus-grafana.html
Change-Id: I85878378f883b2cc1f8136bde2c9f0db7ceccd8f
---
A _posts/2026-07-03-kudu-prometheus-grafana.md
A img/2026-07-03-kudu-prometheus-grafana/master-tserver-memory.png
A img/2026-07-03-kudu-prometheus-grafana/metrics-browser.png
A img/2026-07-03-kudu-prometheus-grafana/prometheus-targets.png
4 files changed, 154 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/14/20814/2
--
To view, visit http://gerrit.cloudera.org:8080/20814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I85878378f883b2cc1f8136bde2c9f0db7ceccd8f
Gerrit-Change-Number: 20814
Gerrit-PatchSet: 2
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
[kudu-CR](gh-pages) Add blog post about Prometheus/Grafana
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/20814 )
Change subject: Add blog post about Prometheus/Grafana
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/20814/1/_posts/2023-12-18-kudu-prometheus-grafana.md
File _posts/2023-12-18-kudu-prometheus-grafana.md:
http://gerrit.cloudera.org:8080/#/c/20814/1/_posts/2023-12-18-kudu-prometheus-grafana.md@24
PS1, Line 24:
Do you think it's worth mentioning that currently Kudu exports only server-level metrics in Prometheus format? I'm concerned that people might read this blog and think that following these steps they are about to get all the Kudu metrics (as available at /metrics end-point), but just in Prometheus format. However, that's not so -- tablet-level metrics aren't available in Prometheus format as of now. To avoid disappointment and confusion, I'd suggest to explicitly mention this in this blog, adding that future Kudu versions should eventually expose all the metrics available.
http://gerrit.cloudera.org:8080/#/c/20814/1/_posts/2023-12-18-kudu-prometheus-grafana.md@33
PS1, Line 33: ## Prometheus Configuration for Kudu
As a side note, it would be much easier to integrate with Prometheus if Kudu provided HTTP Service Discovery mechanismter. I filed KUDU-3538 to track that.
--
To view, visit http://gerrit.cloudera.org:8080/20814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I85878378f883b2cc1f8136bde2c9f0db7ceccd8f
Gerrit-Change-Number: 20814
Gerrit-PatchSet: 1
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Wed, 03 Jan 2024 01:26:23 +0000
Gerrit-HasComments: Yes
[kudu-CR](gh-pages) Add blog post about Prometheus/Grafana
Posted by "Yan-Daojiang (Code Review)" <ge...@cloudera.org>.
Yan-Daojiang has posted comments on this change. ( http://gerrit.cloudera.org:8080/20814 )
Change subject: Add blog post about Prometheus/Grafana
......................................................................
Patch Set 5: Code-Review+1
Looks good to me!
--
To view, visit http://gerrit.cloudera.org:8080/20814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I85878378f883b2cc1f8136bde2c9f0db7ceccd8f
Gerrit-Change-Number: 20814
Gerrit-PatchSet: 5
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Yan-Daojiang <ya...@163.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Sat, 11 Jul 2026 04:25:49 +0000
Gerrit-HasComments: No
[kudu-CR](gh-pages) Add blog post about Prometheus/Grafana
Posted by "Gabriella Lotz (Code Review)" <ge...@cloudera.org>.
Gabriella Lotz has posted comments on this change. ( http://gerrit.cloudera.org:8080/20814 )
Change subject: Add blog post about Prometheus/Grafana
......................................................................
Patch Set 2:
(5 comments)
http://gerrit.cloudera.org:8080/#/c/20814/2/_posts/2026-07-03-kudu-prometheus-grafana.md
File _posts/2026-07-03-kudu-prometheus-grafana.md:
http://gerrit.cloudera.org:8080/#/c/20814/2/_posts/2026-07-03-kudu-prometheus-grafana.md@8
PS2, Line 8: ([KUDU-3691](https://issues.apache.org/jira/browse/KUDU-3691))
nit: the outer parentheses around the link read like a typo. I think without the outside wrapping ( ) reads cleaner.
http://gerrit.cloudera.org:8080/#/c/20814/2/_posts/2026-07-03-kudu-prometheus-grafana.md@42
PS2, Line 42: ```yaml
: global:
: scrape_interval: 15s
: evaluation_interval: 15s
:
: scrape_configs:
: - job_name: 'kudu'
: metrics_path: '/metrics_prometheus'
: static_configs:
: - targets: ['master-1:8051', 'master-2:8051', 'master-3:8051']
: labels:
: group: 'masters'
: - targets: ['tserver-1:8050', 'tserver-2:8050', 'tserver-3:8050']
: labels:
: group: 'tservers'
: ```
I think this YAML isn't valid: scrape_interval/evaluation_interval are at the same indent as global. Since readers will copy-paste this, could you verify this is correct?
http://gerrit.cloudera.org:8080/#/c/20814/2/_posts/2026-07-03-kudu-prometheus-grafana.md@80
PS2, Line 80:
nit: trailing whitespace.
http://gerrit.cloudera.org:8080/#/c/20814/2/_posts/2026-07-03-kudu-prometheus-grafana.md@107
PS2, Line 107: ```yaml
: global:
: scrape_interval: 15s
: evaluation_interval: 15s
:
: scrape_configs:
: - job_name: 'kudu'
: metrics_path: '/metrics_prometheus'
: http_sd_configs:
: - url: 'http://master-1:8051/prometheus-sd'
: - url: 'http://master-2:8051/prometheus-sd'
: - url: 'http://master-3:8051/prometheus-sd'
: ```
same as the other yaml.
http://gerrit.cloudera.org:8080/#/c/20814/2/_posts/2026-07-03-kudu-prometheus-grafana.md@154
PS2, Line 154: [Prometheus documentation](https://prometheus.io/docs/prometheus/latest/configuration/configuration/#http_sd_config).
nit: missing trailing newline at the end of the file.
--
To view, visit http://gerrit.cloudera.org:8080/20814
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-MessageType: comment
Gerrit-Change-Id: I85878378f883b2cc1f8136bde2c9f0db7ceccd8f
Gerrit-Change-Number: 20814
Gerrit-PatchSet: 2
Gerrit-Owner: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Gabriella Lotz <lo...@gmail.com>
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Zoltan Chovan <zc...@cloudera.com>
Gerrit-Comment-Date: Mon, 06 Jul 2026 08:09:18 +0000
Gerrit-HasComments: Yes