You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/10/17 19:04:18 UTC
[GitHub] [helix] pkuwm opened a new issue #1476: Instance not active log is confusing
pkuwm opened a new issue #1476:
URL: https://github.com/apache/helix/issues/1476
### Description
In Helix REST, when we call stoppable api, helix own custom health check is performed. And there is a warn log:
`[WARN ] 2020-10-17 11:45:19,355 org.apache.helix.util.InstanceValidationUtil - The instance <instance> is not active`
And then custom instance health is also checked by calling the external custom REST.
So this is confusing: if the instance is checked to be inactive, why do we still call the custom instance health check?
### Analysis
The check is actually in `hasErrorPartitions()`. If the instance doesn't have error partitions, the warn message is logged. This is inaccurate. We should remove this warn log.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] pkuwm closed issue #1476: Instance not active log is confusing
Posted by GitBox <gi...@apache.org>.
pkuwm closed issue #1476:
URL: https://github.com/apache/helix/issues/1476
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] pkuwm commented on issue #1476: Instance not active log is confusing
Posted by GitBox <gi...@apache.org>.
pkuwm commented on issue #1476:
URL: https://github.com/apache/helix/issues/1476#issuecomment-718268615
Fixed by #1490
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org