You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Harikrishna Patnala <ha...@citrix.com> on 2014/02/11 10:15:44 UTC
Review Request 17941: CLOUDSTACK-6075: Increase the ram size for router
service offering
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17941/
-----------------------------------------------------------
Review request for cloudstack and Jayapal Reddy.
Bugs: CLOUDSTACK-6075
https://issues.apache.org/jira/browse/CLOUDSTACK-6075
Repository: cloudstack-git
Description
-------
CLOUDSTACK-6075: Increase the ram size for router service offering
Increased the ram size of Internal load balancer vm service offering also
Diffs
-----
engine/schema/src/com/cloud/upgrade/dao/Upgrade421to430.java 7e26132
plugins/network-elements/internal-loadbalancer/src/org/apache/cloudstack/network/lb/InternalLoadBalancerVMManager.java efd5bf5
server/src/com/cloud/configuration/Config.java 2d55f46
server/src/com/cloud/network/router/VirtualNetworkApplianceManager.java 4ea09e5
setup/db/db/schema-421to430.sql b55e388
Diff: https://reviews.apache.org/r/17941/diff/
Testing
-------
tested locally
Thanks,
Harikrishna Patnala
Re: Review Request 17941: CLOUDSTACK-6075: Increase the ram size for router
service offering
Posted by daan Hoogland <da...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17941/#review40646
-----------------------------------------------------------
please update or submit this review request. It will be discarded when it stays in to long
- daan Hoogland
On Feb. 11, 2014, 9:15 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17941/
> -----------------------------------------------------------
>
> (Updated Feb. 11, 2014, 9:15 a.m.)
>
>
> Review request for cloudstack and Jayapal Reddy.
>
>
> Bugs: CLOUDSTACK-6075
> https://issues.apache.org/jira/browse/CLOUDSTACK-6075
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-6075: Increase the ram size for router service offering
> Increased the ram size of Internal load balancer vm service offering also
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/upgrade/dao/Upgrade421to430.java 7e26132
> plugins/network-elements/internal-loadbalancer/src/org/apache/cloudstack/network/lb/InternalLoadBalancerVMManager.java efd5bf5
> server/src/com/cloud/configuration/Config.java 2d55f46
> server/src/com/cloud/network/router/VirtualNetworkApplianceManager.java 4ea09e5
> setup/db/db/schema-421to430.sql b55e388
>
> Diff: https://reviews.apache.org/r/17941/diff/
>
>
> Testing
> -------
>
> tested locally
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 17941: CLOUDSTACK-6075: Increase the ram size for
router service offering
Posted by Rohit Yadav <bh...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17941/#review62958
-----------------------------------------------------------
LGTM.
- Rohit Yadav
On Nov. 25, 2014, 6:07 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17941/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2014, 6:07 a.m.)
>
>
> Review request for cloudstack, Jayapal Reddy, Kishan Kavala, and Rajani Karuturi.
>
>
> Bugs: CLOUDSTACK-6075
> https://issues.apache.org/jira/browse/CLOUDSTACK-6075
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-6075: Increase the ram size for router service offering
> Increased the ram size of Internal load balancer vm service offering also
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/upgrade/dao/Upgrade441to450.java cde661b
> plugins/network-elements/internal-loadbalancer/src/org/apache/cloudstack/network/lb/InternalLoadBalancerVMManager.java 803d3a5
> server/src/com/cloud/configuration/Config.java 517c76c
> server/src/com/cloud/network/router/VirtualNetworkApplianceManager.java 85ce8b9
> setup/db/db/schema-441to450.sql c899289
>
> Diff: https://reviews.apache.org/r/17941/diff/
>
>
> Testing
> -------
>
> tested locally
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 17941: CLOUDSTACK-6075: Increase the ram size for
router service offering
Posted by Rohit Yadav <bh...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17941/#review62957
-----------------------------------------------------------
I tried to merge it on 4.5/master, there were few issues. There is a PR to merge 4.5 on master, so you may need to redo the patch once that is done.
- Rohit Yadav
On Nov. 25, 2014, 6:07 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17941/
> -----------------------------------------------------------
>
> (Updated Nov. 25, 2014, 6:07 a.m.)
>
>
> Review request for cloudstack, Jayapal Reddy, Kishan Kavala, and Rajani Karuturi.
>
>
> Bugs: CLOUDSTACK-6075
> https://issues.apache.org/jira/browse/CLOUDSTACK-6075
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-6075: Increase the ram size for router service offering
> Increased the ram size of Internal load balancer vm service offering also
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/upgrade/dao/Upgrade441to450.java cde661b
> plugins/network-elements/internal-loadbalancer/src/org/apache/cloudstack/network/lb/InternalLoadBalancerVMManager.java 803d3a5
> server/src/com/cloud/configuration/Config.java 517c76c
> server/src/com/cloud/network/router/VirtualNetworkApplianceManager.java 85ce8b9
> setup/db/db/schema-441to450.sql c899289
>
> Diff: https://reviews.apache.org/r/17941/diff/
>
>
> Testing
> -------
>
> tested locally
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 17941: CLOUDSTACK-6075: Increase the ram size for
router service offering
Posted by Rajani Karuturi <ra...@apache.org>.
> On Nov. 27, 2014, 10:15 a.m., Rohit Yadav wrote:
> > +1
> > LGTM, if any of the other designated reviewers don't object let's merge this on master/4.5; I've already picked/fixed this for 4.3 branch.
> >
> > Hari - thanks for the patch, I encourage you to use Github Pull Requests in future which I find is less painful than using reviewboard.
and also on 4.4 please. since its already on 4.3, it should goto all 4.3+ releases.
- Rajani
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17941/#review63196
-----------------------------------------------------------
On Nov. 27, 2014, 9:22 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17941/
> -----------------------------------------------------------
>
> (Updated Nov. 27, 2014, 9:22 a.m.)
>
>
> Review request for cloudstack, Jayapal Reddy, Kishan Kavala, and Rajani Karuturi.
>
>
> Bugs: CLOUDSTACK-6075
> https://issues.apache.org/jira/browse/CLOUDSTACK-6075
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-6075: Increase the ram size for router service offering
> Increased the ram size of Internal load balancer vm service offering also
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/upgrade/dao/Upgrade442to450.java dc1057f
> plugins/network-elements/internal-loadbalancer/src/org/apache/cloudstack/network/lb/InternalLoadBalancerVMManager.java 803d3a5
> server/src/com/cloud/configuration/Config.java cd0824e
> server/src/com/cloud/network/router/VirtualNetworkApplianceManager.java 9fb47fd
> setup/db/db/schema-442to450.sql 107f10c
>
> Diff: https://reviews.apache.org/r/17941/diff/
>
>
> Testing
> -------
>
> tested locally
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 17941: CLOUDSTACK-6075: Increase the ram size for
router service offering
Posted by Rohit Yadav <bh...@apache.org>.
> On Nov. 27, 2014, 10:15 a.m., Rohit Yadav wrote:
> > +1
> > LGTM, if any of the other designated reviewers don't object let's merge this on master/4.5; I've already picked/fixed this for 4.3 branch.
> >
> > Hari - thanks for the patch, I encourage you to use Github Pull Requests in future which I find is less painful than using reviewboard.
>
> Rajani Karuturi wrote:
> and also on 4.4 please. since its already on 4.3, it should goto all 4.3+ releases.
Yes, Hari please send another patch (maybe via Github PR) for 4.4 branch as well? I'll help merging this on 4.5/master in the meanwhile.
- Rohit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17941/#review63196
-----------------------------------------------------------
On Nov. 27, 2014, 9:22 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17941/
> -----------------------------------------------------------
>
> (Updated Nov. 27, 2014, 9:22 a.m.)
>
>
> Review request for cloudstack, Jayapal Reddy, Kishan Kavala, and Rajani Karuturi.
>
>
> Bugs: CLOUDSTACK-6075
> https://issues.apache.org/jira/browse/CLOUDSTACK-6075
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-6075: Increase the ram size for router service offering
> Increased the ram size of Internal load balancer vm service offering also
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/upgrade/dao/Upgrade442to450.java dc1057f
> plugins/network-elements/internal-loadbalancer/src/org/apache/cloudstack/network/lb/InternalLoadBalancerVMManager.java 803d3a5
> server/src/com/cloud/configuration/Config.java cd0824e
> server/src/com/cloud/network/router/VirtualNetworkApplianceManager.java 9fb47fd
> setup/db/db/schema-442to450.sql 107f10c
>
> Diff: https://reviews.apache.org/r/17941/diff/
>
>
> Testing
> -------
>
> tested locally
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 17941: CLOUDSTACK-6075: Increase the ram size for
router service offering
Posted by Daan Hoogland <da...@gmail.com>.
Hari, I added the 443 upgrade path, feel free to commit on the 4.4 branch.
On Fri, Nov 28, 2014 at 9:17 PM, Rohit Yadav <bh...@apache.org> wrote:
>
> On Sat, Nov 29, 2014 at 12:49 AM, Daan Hoogland <da...@gmail.com>
> wrote:
>>
>> Rohit, is this really needed in 4.3? We are throwing away our agreed
>> policies on db changes here. When talking on customers that kind of
>> masquerades the upgrade dilemma they have with a minor version in a
>> tiny version.
>
>
> Yes, there is no db schema change, only data migration and updates. Talk is
> cheap, go see the code:
> https://github.com/apache/cloudstack/commit/6d31aca25cd5848272aaa190581f1f7c2bc00729
>
>> @Hari I'll find some time to add the 442to443 path
>>
>> On Fri, Nov 28, 2014 at 6:59 AM, Harikrishna Patnala
>> <ha...@citrix.com> wrote:
>> > Hi,
>> >
>> > This patch was only intended to put in 4.5 and master and later it was
>> > back
>> > ported to 4.3.
>> > If you can help me adding the upgrade path from 4.4.2 to 4.4.3, I’ll put
>> > the
>> > PR for back porting to 4.4.3
>> >
>> > Thanks,
>> > Harikrishna
>> >
>> > On 27-Nov-2014, at 8:59 pm, Rohit Yadav <bh...@apache.org> wrote:
>> >
>> > Hi Rajani,
>> >
>> > I've already started a thread on user/dev ML around LTS releases, we
>> > should
>> > have discussion there.
>> >
>> > On Thu, Nov 27, 2014 at 6:26 PM, Rajani Karuturi <ra...@apache.org>
>> > wrote:
>> >>
>> >> I dont like the idea of release manager cherry-picking/backporting the
>> >> fixes to the release branches.
>> >>
>> >> As a community we are supporting past two releases. ie) at this point
>> >> we
>> >> have to support 4.3 and 4.4
>> >> As a developer/contributor, if I feel a bug is relevant for 4.3 I
>> >> should
>> >> be committing it to all the 4.3+ releases. Otherwise it would be a
>> >> nightmare
>> >> for people trying to upgrade later.
>> >> If and when a release is required, we should release from that branch.
>> >
>> >
>> > +1 that's the ideal case and everyone should do it but since I had to
>> > backport more than 90 fixes from 4.4/4.5/master to 4.3 many of us were
>> > clearly not doing that.
>> >
>> > In many opensource projects such as Linux, it's common to see different
>> > people maintaining a certain branch or major release. I want to do the
>> > same
>> > for 4.3 until a stable 4.5.x or 4.6.x is out that is fairly tested and
>> > used
>> > in the wild. Everyone is welcome to do it for any branches they do.
>> >
>> > Regards.
>> >
>> >>
>> >>
>> >> ~Rajani
>> >>
>> >> On Thu, Nov 27, 2014 at 6:13 PM, Rohit Yadav <bh...@apache.org>
>> >> wrote:
>> >>>
>> >>>
>> >>> On Thu, Nov 27, 2014 at 5:30 PM, Daan Hoogland
>> >>> <da...@gmail.com>
>> >>> wrote:
>> >>>>
>> >>>> ok, so that would go in 442to443?
>> >>>
>> >>>
>> >>> Yes, but do you plan to do a 4.4.3? The whole debate around
>> >>> maintaining
>> >>> 4.3 vs 4.4 comes down to stakeholder's interests, you've shared that
>> >>> you may
>> >>> not want to put a lot of efforts on 4.4 branch since 4.5.0 is around
>> >>> but if
>> >>> I'm mistaken and since you're the release manager you should backport
>> >>> changes applicable on 4.4 and do a 4.4.3 release. That would be great
>> >>> for
>> >>> 4.4.x users.
>> >>>
>> >>> Before the patch could be ported, Hari will need to use an empty
>> >>> upgrade
>> >>> path from 4.4.2 to 4.4.3 and change versions in pom files etc. Hari
>> >>> let me
>> >>> know if you can do that in your backport or if Daan or I need to add
>> >>> that
>> >>> for you. Thanks.
>> >>>
>> >>>>
>> >>>>
>> >>>> On Thu, Nov 27, 2014 at 12:52 PM, Rohit Yadav <bh...@apache.org>
>> >>>> wrote:
>> >>>> > Daan,
>> >>>> >
>> >>>> > On Thu, Nov 27, 2014 at 4:17 PM, Daan Hoogland
>> >>>> > <da...@gmail.com>
>> >>>> > wrote:
>> >>>> >>
>> >>>> >> If this contains db upgrade code, where did this go in 4.3? In the
>> >>>> >> review request I see changes to 442to450 upgrade files so this
>> >>>> >> should
>> >>>> >> not go in 4.3 or 4.4. What am I missing?
>> >>>> >
>> >>>> >
>> >>>> > For 4.3, the upgrade path (it's just data migration no schema
>> >>>> > changes
>> >>>> > so
>> >>>> > easily backportable) is from 4.3.1 to 4.3.2 in Upgrade431to432
>> >>>> > class.
>> >>>> >
>> >>>> > The fix simply goes through existing VRs and updates their RAM
>> >>>> > size,
>> >>>> > no
>> >>>> > schema changes here only data migrations.
>> >>>> >
>> >>>> > Regards.
>> >>>> >
>> >>>>
>> >>>>
>> >>>>
>> >>>> --
>> >>>> Daan
>> >>>
>> >>>
>> >>
>> >
>> >
>>
>>
>>
>> --
>> Daan
>
>
--
Daan
Re: Review Request 17941: CLOUDSTACK-6075: Increase the ram size for
router service offering
Posted by Rohit Yadav <bh...@apache.org>.
On Sat, Nov 29, 2014 at 12:49 AM, Daan Hoogland <da...@gmail.com>
wrote:
> Rohit, is this really needed in 4.3? We are throwing away our agreed
> policies on db changes here. When talking on customers that kind of
> masquerades the upgrade dilemma they have with a minor version in a
> tiny version.
>
Yes, there is no db schema change, only data migration and updates. Talk is
cheap, go see the code:
https://github.com/apache/cloudstack/commit/6d31aca25cd5848272aaa190581f1f7c2bc00729
@Hari I'll find some time to add the 442to443 path
>
> On Fri, Nov 28, 2014 at 6:59 AM, Harikrishna Patnala
> <ha...@citrix.com> wrote:
> > Hi,
> >
> > This patch was only intended to put in 4.5 and master and later it was
> back
> > ported to 4.3.
> > If you can help me adding the upgrade path from 4.4.2 to 4.4.3, I'll put
> the
> > PR for back porting to 4.4.3
> >
> > Thanks,
> > Harikrishna
> >
> > On 27-Nov-2014, at 8:59 pm, Rohit Yadav <bh...@apache.org> wrote:
> >
> > Hi Rajani,
> >
> > I've already started a thread on user/dev ML around LTS releases, we
> should
> > have discussion there.
> >
> > On Thu, Nov 27, 2014 at 6:26 PM, Rajani Karuturi <ra...@apache.org>
> wrote:
> >>
> >> I dont like the idea of release manager cherry-picking/backporting the
> >> fixes to the release branches.
> >>
> >> As a community we are supporting past two releases. ie) at this point we
> >> have to support 4.3 and 4.4
> >> As a developer/contributor, if I feel a bug is relevant for 4.3 I should
> >> be committing it to all the 4.3+ releases. Otherwise it would be a
> nightmare
> >> for people trying to upgrade later.
> >> If and when a release is required, we should release from that branch.
> >
> >
> > +1 that's the ideal case and everyone should do it but since I had to
> > backport more than 90 fixes from 4.4/4.5/master to 4.3 many of us were
> > clearly not doing that.
> >
> > In many opensource projects such as Linux, it's common to see different
> > people maintaining a certain branch or major release. I want to do the
> same
> > for 4.3 until a stable 4.5.x or 4.6.x is out that is fairly tested and
> used
> > in the wild. Everyone is welcome to do it for any branches they do.
> >
> > Regards.
> >
> >>
> >>
> >> ~Rajani
> >>
> >> On Thu, Nov 27, 2014 at 6:13 PM, Rohit Yadav <bh...@apache.org>
> wrote:
> >>>
> >>>
> >>> On Thu, Nov 27, 2014 at 5:30 PM, Daan Hoogland <
> daan.hoogland@gmail.com>
> >>> wrote:
> >>>>
> >>>> ok, so that would go in 442to443?
> >>>
> >>>
> >>> Yes, but do you plan to do a 4.4.3? The whole debate around maintaining
> >>> 4.3 vs 4.4 comes down to stakeholder's interests, you've shared that
> you may
> >>> not want to put a lot of efforts on 4.4 branch since 4.5.0 is around
> but if
> >>> I'm mistaken and since you're the release manager you should backport
> >>> changes applicable on 4.4 and do a 4.4.3 release. That would be great
> for
> >>> 4.4.x users.
> >>>
> >>> Before the patch could be ported, Hari will need to use an empty
> upgrade
> >>> path from 4.4.2 to 4.4.3 and change versions in pom files etc. Hari
> let me
> >>> know if you can do that in your backport or if Daan or I need to add
> that
> >>> for you. Thanks.
> >>>
> >>>>
> >>>>
> >>>> On Thu, Nov 27, 2014 at 12:52 PM, Rohit Yadav <bh...@apache.org>
> >>>> wrote:
> >>>> > Daan,
> >>>> >
> >>>> > On Thu, Nov 27, 2014 at 4:17 PM, Daan Hoogland
> >>>> > <da...@gmail.com>
> >>>> > wrote:
> >>>> >>
> >>>> >> If this contains db upgrade code, where did this go in 4.3? In the
> >>>> >> review request I see changes to 442to450 upgrade files so this
> should
> >>>> >> not go in 4.3 or 4.4. What am I missing?
> >>>> >
> >>>> >
> >>>> > For 4.3, the upgrade path (it's just data migration no schema
> changes
> >>>> > so
> >>>> > easily backportable) is from 4.3.1 to 4.3.2 in Upgrade431to432
> class.
> >>>> >
> >>>> > The fix simply goes through existing VRs and updates their RAM size,
> >>>> > no
> >>>> > schema changes here only data migrations.
> >>>> >
> >>>> > Regards.
> >>>> >
> >>>>
> >>>>
> >>>>
> >>>> --
> >>>> Daan
> >>>
> >>>
> >>
> >
> >
>
>
>
> --
> Daan
>
Re: Review Request 17941: CLOUDSTACK-6075: Increase the ram size for
router service offering
Posted by Daan Hoogland <da...@gmail.com>.
Rohit, is this really needed in 4.3? We are throwing away our agreed
policies on db changes here. When talking on customers that kind of
masquerades the upgrade dilemma they have with a minor version in a
tiny version.
@Hari I'll find some time to add the 442to443 path
On Fri, Nov 28, 2014 at 6:59 AM, Harikrishna Patnala
<ha...@citrix.com> wrote:
> Hi,
>
> This patch was only intended to put in 4.5 and master and later it was back
> ported to 4.3.
> If you can help me adding the upgrade path from 4.4.2 to 4.4.3, I’ll put the
> PR for back porting to 4.4.3
>
> Thanks,
> Harikrishna
>
> On 27-Nov-2014, at 8:59 pm, Rohit Yadav <bh...@apache.org> wrote:
>
> Hi Rajani,
>
> I've already started a thread on user/dev ML around LTS releases, we should
> have discussion there.
>
> On Thu, Nov 27, 2014 at 6:26 PM, Rajani Karuturi <ra...@apache.org> wrote:
>>
>> I dont like the idea of release manager cherry-picking/backporting the
>> fixes to the release branches.
>>
>> As a community we are supporting past two releases. ie) at this point we
>> have to support 4.3 and 4.4
>> As a developer/contributor, if I feel a bug is relevant for 4.3 I should
>> be committing it to all the 4.3+ releases. Otherwise it would be a nightmare
>> for people trying to upgrade later.
>> If and when a release is required, we should release from that branch.
>
>
> +1 that's the ideal case and everyone should do it but since I had to
> backport more than 90 fixes from 4.4/4.5/master to 4.3 many of us were
> clearly not doing that.
>
> In many opensource projects such as Linux, it's common to see different
> people maintaining a certain branch or major release. I want to do the same
> for 4.3 until a stable 4.5.x or 4.6.x is out that is fairly tested and used
> in the wild. Everyone is welcome to do it for any branches they do.
>
> Regards.
>
>>
>>
>> ~Rajani
>>
>> On Thu, Nov 27, 2014 at 6:13 PM, Rohit Yadav <bh...@apache.org> wrote:
>>>
>>>
>>> On Thu, Nov 27, 2014 at 5:30 PM, Daan Hoogland <da...@gmail.com>
>>> wrote:
>>>>
>>>> ok, so that would go in 442to443?
>>>
>>>
>>> Yes, but do you plan to do a 4.4.3? The whole debate around maintaining
>>> 4.3 vs 4.4 comes down to stakeholder's interests, you've shared that you may
>>> not want to put a lot of efforts on 4.4 branch since 4.5.0 is around but if
>>> I'm mistaken and since you're the release manager you should backport
>>> changes applicable on 4.4 and do a 4.4.3 release. That would be great for
>>> 4.4.x users.
>>>
>>> Before the patch could be ported, Hari will need to use an empty upgrade
>>> path from 4.4.2 to 4.4.3 and change versions in pom files etc. Hari let me
>>> know if you can do that in your backport or if Daan or I need to add that
>>> for you. Thanks.
>>>
>>>>
>>>>
>>>> On Thu, Nov 27, 2014 at 12:52 PM, Rohit Yadav <bh...@apache.org>
>>>> wrote:
>>>> > Daan,
>>>> >
>>>> > On Thu, Nov 27, 2014 at 4:17 PM, Daan Hoogland
>>>> > <da...@gmail.com>
>>>> > wrote:
>>>> >>
>>>> >> If this contains db upgrade code, where did this go in 4.3? In the
>>>> >> review request I see changes to 442to450 upgrade files so this should
>>>> >> not go in 4.3 or 4.4. What am I missing?
>>>> >
>>>> >
>>>> > For 4.3, the upgrade path (it's just data migration no schema changes
>>>> > so
>>>> > easily backportable) is from 4.3.1 to 4.3.2 in Upgrade431to432 class.
>>>> >
>>>> > The fix simply goes through existing VRs and updates their RAM size,
>>>> > no
>>>> > schema changes here only data migrations.
>>>> >
>>>> > Regards.
>>>> >
>>>>
>>>>
>>>>
>>>> --
>>>> Daan
>>>
>>>
>>
>
>
--
Daan
Re: Review Request 17941: CLOUDSTACK-6075: Increase the ram size
for router service offering
Posted by Harikrishna Patnala <ha...@citrix.com>.
Hi,
This patch was only intended to put in 4.5 and master and later it was back ported to 4.3.
If you can help me adding the upgrade path from 4.4.2 to 4.4.3, I’ll put the PR for back porting to 4.4.3
Thanks,
Harikrishna
On 27-Nov-2014, at 8:59 pm, Rohit Yadav <bh...@apache.org>> wrote:
Hi Rajani,
I've already started a thread on user/dev ML around LTS releases, we should have discussion there.
On Thu, Nov 27, 2014 at 6:26 PM, Rajani Karuturi <ra...@apache.org>> wrote:
I dont like the idea of release manager cherry-picking/backporting the fixes to the release branches.
As a community we are supporting past two releases. ie) at this point we have to support 4.3 and 4.4
As a developer/contributor, if I feel a bug is relevant for 4.3 I should be committing it to all the 4.3+ releases. Otherwise it would be a nightmare for people trying to upgrade later.
If and when a release is required, we should release from that branch.
+1 that's the ideal case and everyone should do it but since I had to backport more than 90 fixes from 4.4/4.5/master to 4.3 many of us were clearly not doing that.
In many opensource projects such as Linux, it's common to see different people maintaining a certain branch or major release. I want to do the same for 4.3 until a stable 4.5.x or 4.6.x is out that is fairly tested and used in the wild. Everyone is welcome to do it for any branches they do.
Regards.
~Rajani
On Thu, Nov 27, 2014 at 6:13 PM, Rohit Yadav <bh...@apache.org>> wrote:
On Thu, Nov 27, 2014 at 5:30 PM, Daan Hoogland <da...@gmail.com>> wrote:
ok, so that would go in 442to443?
Yes, but do you plan to do a 4.4.3? The whole debate around maintaining 4.3 vs 4.4 comes down to stakeholder's interests, you've shared that you may not want to put a lot of efforts on 4.4 branch since 4.5.0 is around but if I'm mistaken and since you're the release manager you should backport changes applicable on 4.4 and do a 4.4.3 release. That would be great for 4.4.x users.
Before the patch could be ported, Hari will need to use an empty upgrade path from 4.4.2 to 4.4.3 and change versions in pom files etc. Hari let me know if you can do that in your backport or if Daan or I need to add that for you. Thanks.
On Thu, Nov 27, 2014 at 12:52 PM, Rohit Yadav <bh...@apache.org>> wrote:
> Daan,
>
> On Thu, Nov 27, 2014 at 4:17 PM, Daan Hoogland <da...@gmail.com>>
> wrote:
>>
>> If this contains db upgrade code, where did this go in 4.3? In the
>> review request I see changes to 442to450 upgrade files so this should
>> not go in 4.3 or 4.4. What am I missing?
>
>
> For 4.3, the upgrade path (it's just data migration no schema changes so
> easily backportable) is from 4.3.1 to 4.3.2 in Upgrade431to432 class.
>
> The fix simply goes through existing VRs and updates their RAM size, no
> schema changes here only data migrations.
>
> Regards.
>
--
Daan
Re: Review Request 17941: CLOUDSTACK-6075: Increase the ram size for
router service offering
Posted by Rohit Yadav <bh...@apache.org>.
Hi Rajani,
I've already started a thread on user/dev ML around LTS releases, we should
have discussion there.
On Thu, Nov 27, 2014 at 6:26 PM, Rajani Karuturi <ra...@apache.org> wrote:
> I dont like the idea of release manager cherry-picking/backporting the
> fixes to the release branches.
>
> As a community we are supporting past two releases. ie) at this point we
> have to support 4.3 and 4.4
> As a developer/contributor, if I feel a bug is relevant for 4.3 I should
> be committing it to all the 4.3+ releases. Otherwise it would be a
> nightmare for people trying to upgrade later.
> If and when a release is required, we should release from that branch.
>
+1 that's the ideal case and everyone should do it but since I had to
backport more than 90 fixes from 4.4/4.5/master to 4.3 many of us were
clearly not doing that.
In many opensource projects such as Linux, it's common to see different
people maintaining a certain branch or major release. I want to do the same
for 4.3 until a stable 4.5.x or 4.6.x is out that is fairly tested and used
in the wild. Everyone is welcome to do it for any branches they do.
Regards.
>
> ~Rajani
>
> On Thu, Nov 27, 2014 at 6:13 PM, Rohit Yadav <bh...@apache.org> wrote:
>
>>
>> On Thu, Nov 27, 2014 at 5:30 PM, Daan Hoogland <da...@gmail.com>
>> wrote:
>>
>>> ok, so that would go in 442to443?
>>>
>>
>> Yes, but do you plan to do a 4.4.3? The whole debate around maintaining
>> 4.3 vs 4.4 comes down to stakeholder's interests, you've shared that you
>> may not want to put a lot of efforts on 4.4 branch since 4.5.0 is around
>> but if I'm mistaken and since you're the release manager you should
>> backport changes applicable on 4.4 and do a 4.4.3 release. That would be
>> great for 4.4.x users.
>>
>> Before the patch could be ported, Hari will need to use an empty upgrade
>> path from 4.4.2 to 4.4.3 and change versions in pom files etc. Hari let me
>> know if you can do that in your backport or if Daan or I need to add that
>> for you. Thanks.
>>
>>
>>>
>>> On Thu, Nov 27, 2014 at 12:52 PM, Rohit Yadav <bh...@apache.org>
>>> wrote:
>>> > Daan,
>>> >
>>> > On Thu, Nov 27, 2014 at 4:17 PM, Daan Hoogland <
>>> daan.hoogland@gmail.com>
>>> > wrote:
>>> >>
>>> >> If this contains db upgrade code, where did this go in 4.3? In the
>>> >> review request I see changes to 442to450 upgrade files so this should
>>> >> not go in 4.3 or 4.4. What am I missing?
>>> >
>>> >
>>> > For 4.3, the upgrade path (it's just data migration no schema changes
>>> so
>>> > easily backportable) is from 4.3.1 to 4.3.2 in Upgrade431to432 class.
>>> >
>>> > The fix simply goes through existing VRs and updates their RAM size, no
>>> > schema changes here only data migrations.
>>> >
>>> > Regards.
>>> >
>>>
>>>
>>>
>>> --
>>> Daan
>>>
>>
>>
>
Re: Review Request 17941: CLOUDSTACK-6075: Increase the ram size for
router service offering
Posted by Rajani Karuturi <ra...@apache.org>.
I dont like the idea of release manager cherry-picking/backporting the
fixes to the release branches.
As a community we are supporting past two releases. ie) at this point we
have to support 4.3 and 4.4
As a developer/contributor, if I feel a bug is relevant for 4.3 I should be
committing it to all the 4.3+ releases. Otherwise it would be a nightmare
for people trying to upgrade later.
If and when a release is required, we should release from that branch.
~Rajani
On Thu, Nov 27, 2014 at 6:13 PM, Rohit Yadav <bh...@apache.org> wrote:
>
> On Thu, Nov 27, 2014 at 5:30 PM, Daan Hoogland <da...@gmail.com>
> wrote:
>
>> ok, so that would go in 442to443?
>>
>
> Yes, but do you plan to do a 4.4.3? The whole debate around maintaining
> 4.3 vs 4.4 comes down to stakeholder's interests, you've shared that you
> may not want to put a lot of efforts on 4.4 branch since 4.5.0 is around
> but if I'm mistaken and since you're the release manager you should
> backport changes applicable on 4.4 and do a 4.4.3 release. That would be
> great for 4.4.x users.
>
> Before the patch could be ported, Hari will need to use an empty upgrade
> path from 4.4.2 to 4.4.3 and change versions in pom files etc. Hari let me
> know if you can do that in your backport or if Daan or I need to add that
> for you. Thanks.
>
>
>>
>> On Thu, Nov 27, 2014 at 12:52 PM, Rohit Yadav <bh...@apache.org>
>> wrote:
>> > Daan,
>> >
>> > On Thu, Nov 27, 2014 at 4:17 PM, Daan Hoogland <daan.hoogland@gmail.com
>> >
>> > wrote:
>> >>
>> >> If this contains db upgrade code, where did this go in 4.3? In the
>> >> review request I see changes to 442to450 upgrade files so this should
>> >> not go in 4.3 or 4.4. What am I missing?
>> >
>> >
>> > For 4.3, the upgrade path (it's just data migration no schema changes so
>> > easily backportable) is from 4.3.1 to 4.3.2 in Upgrade431to432 class.
>> >
>> > The fix simply goes through existing VRs and updates their RAM size, no
>> > schema changes here only data migrations.
>> >
>> > Regards.
>> >
>>
>>
>>
>> --
>> Daan
>>
>
>
Re: Review Request 17941: CLOUDSTACK-6075: Increase the ram size for
router service offering
Posted by Rohit Yadav <bh...@apache.org>.
On Thu, Nov 27, 2014 at 5:30 PM, Daan Hoogland <da...@gmail.com>
wrote:
> ok, so that would go in 442to443?
>
Yes, but do you plan to do a 4.4.3? The whole debate around maintaining 4.3
vs 4.4 comes down to stakeholder's interests, you've shared that you may
not want to put a lot of efforts on 4.4 branch since 4.5.0 is around but if
I'm mistaken and since you're the release manager you should backport
changes applicable on 4.4 and do a 4.4.3 release. That would be great for
4.4.x users.
Before the patch could be ported, Hari will need to use an empty upgrade
path from 4.4.2 to 4.4.3 and change versions in pom files etc. Hari let me
know if you can do that in your backport or if Daan or I need to add that
for you. Thanks.
>
> On Thu, Nov 27, 2014 at 12:52 PM, Rohit Yadav <bh...@apache.org> wrote:
> > Daan,
> >
> > On Thu, Nov 27, 2014 at 4:17 PM, Daan Hoogland <da...@gmail.com>
> > wrote:
> >>
> >> If this contains db upgrade code, where did this go in 4.3? In the
> >> review request I see changes to 442to450 upgrade files so this should
> >> not go in 4.3 or 4.4. What am I missing?
> >
> >
> > For 4.3, the upgrade path (it's just data migration no schema changes so
> > easily backportable) is from 4.3.1 to 4.3.2 in Upgrade431to432 class.
> >
> > The fix simply goes through existing VRs and updates their RAM size, no
> > schema changes here only data migrations.
> >
> > Regards.
> >
>
>
>
> --
> Daan
>
Re: Review Request 17941: CLOUDSTACK-6075: Increase the ram size for
router service offering
Posted by Daan Hoogland <da...@gmail.com>.
ok, so that would go in 442to443?
On Thu, Nov 27, 2014 at 12:52 PM, Rohit Yadav <bh...@apache.org> wrote:
> Daan,
>
> On Thu, Nov 27, 2014 at 4:17 PM, Daan Hoogland <da...@gmail.com>
> wrote:
>>
>> If this contains db upgrade code, where did this go in 4.3? In the
>> review request I see changes to 442to450 upgrade files so this should
>> not go in 4.3 or 4.4. What am I missing?
>
>
> For 4.3, the upgrade path (it's just data migration no schema changes so
> easily backportable) is from 4.3.1 to 4.3.2 in Upgrade431to432 class.
>
> The fix simply goes through existing VRs and updates their RAM size, no
> schema changes here only data migrations.
>
> Regards.
>
--
Daan
Re: Review Request 17941: CLOUDSTACK-6075: Increase the ram size for
router service offering
Posted by Rohit Yadav <bh...@apache.org>.
Daan,
On Thu, Nov 27, 2014 at 4:17 PM, Daan Hoogland <da...@gmail.com>
wrote:
> If this contains db upgrade code, where did this go in 4.3? In the
> review request I see changes to 442to450 upgrade files so this should
> not go in 4.3 or 4.4. What am I missing?
>
For 4.3, the upgrade path (it's just data migration no schema changes so
easily backportable) is from 4.3.1 to 4.3.2 in Upgrade431to432 class.
The fix simply goes through existing VRs and updates their RAM size, no
schema changes here only data migrations.
Regards.
Re: Review Request 17941: CLOUDSTACK-6075: Increase the ram size for
router service offering
Posted by Daan Hoogland <da...@gmail.com>.
If this contains db upgrade code, where did this go in 4.3? In the
review request I see changes to 442to450 upgrade files so this should
not go in 4.3 or 4.4. What am I missing?
On Thu, Nov 27, 2014 at 11:40 AM, Rohit Yadav <bh...@apache.org> wrote:
>
>
>> On Nov. 27, 2014, 10:15 a.m., Rohit Yadav wrote:
>> > +1
>> > LGTM, if any of the other designated reviewers don't object let's merge this on master/4.5; I've already picked/fixed this for 4.3 branch.
>> >
>> > Hari - thanks for the patch, I encourage you to use Github Pull Requests in future which I find is less painful than using reviewboard.
>>
>> Rajani Karuturi wrote:
>> and also on 4.4 please. since its already on 4.3, it should goto all 4.3+ releases.
>>
>> Rohit Yadav wrote:
>> Yes, Hari please send another patch (maybe via Github PR) for 4.4 branch as well? I'll help merging this on 4.5/master in the meanwhile.
>>
>> Harikrishna Patnala wrote:
>> Thanks Rohit, I'll put github PR for 4.4 branch
>
> Maybe check with Daan on this as 4.4.2 release/tag is public now. This involves DB upgrade/migration paths (just to update the settings and change router ram size) so I don't know where you should put the upgrade paths.
>
>
> - Rohit
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17941/#review63196
> -----------------------------------------------------------
>
>
> On Nov. 27, 2014, 9:22 a.m., Harikrishna Patnala wrote:
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/17941/
>> -----------------------------------------------------------
>>
>> (Updated Nov. 27, 2014, 9:22 a.m.)
>>
>>
>> Review request for cloudstack, Jayapal Reddy, Kishan Kavala, and Rajani Karuturi.
>>
>>
>> Bugs: CLOUDSTACK-6075
>> https://issues.apache.org/jira/browse/CLOUDSTACK-6075
>>
>>
>> Repository: cloudstack-git
>>
>>
>> Description
>> -------
>>
>> CLOUDSTACK-6075: Increase the ram size for router service offering
>> Increased the ram size of Internal load balancer vm service offering also
>>
>>
>> Diffs
>> -----
>>
>> engine/schema/src/com/cloud/upgrade/dao/Upgrade442to450.java dc1057f
>> plugins/network-elements/internal-loadbalancer/src/org/apache/cloudstack/network/lb/InternalLoadBalancerVMManager.java 803d3a5
>> server/src/com/cloud/configuration/Config.java cd0824e
>> server/src/com/cloud/network/router/VirtualNetworkApplianceManager.java 9fb47fd
>> setup/db/db/schema-442to450.sql 107f10c
>>
>> Diff: https://reviews.apache.org/r/17941/diff/
>>
>>
>> Testing
>> -------
>>
>> tested locally
>>
>>
>> Thanks,
>>
>> Harikrishna Patnala
>>
>>
>
--
Daan
Re: Review Request 17941: CLOUDSTACK-6075: Increase the ram size for
router service offering
Posted by Rohit Yadav <bh...@apache.org>.
> On Nov. 27, 2014, 10:15 a.m., Rohit Yadav wrote:
> > +1
> > LGTM, if any of the other designated reviewers don't object let's merge this on master/4.5; I've already picked/fixed this for 4.3 branch.
> >
> > Hari - thanks for the patch, I encourage you to use Github Pull Requests in future which I find is less painful than using reviewboard.
>
> Rajani Karuturi wrote:
> and also on 4.4 please. since its already on 4.3, it should goto all 4.3+ releases.
>
> Rohit Yadav wrote:
> Yes, Hari please send another patch (maybe via Github PR) for 4.4 branch as well? I'll help merging this on 4.5/master in the meanwhile.
>
> Harikrishna Patnala wrote:
> Thanks Rohit, I'll put github PR for 4.4 branch
Maybe check with Daan on this as 4.4.2 release/tag is public now. This involves DB upgrade/migration paths (just to update the settings and change router ram size) so I don't know where you should put the upgrade paths.
- Rohit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17941/#review63196
-----------------------------------------------------------
On Nov. 27, 2014, 9:22 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17941/
> -----------------------------------------------------------
>
> (Updated Nov. 27, 2014, 9:22 a.m.)
>
>
> Review request for cloudstack, Jayapal Reddy, Kishan Kavala, and Rajani Karuturi.
>
>
> Bugs: CLOUDSTACK-6075
> https://issues.apache.org/jira/browse/CLOUDSTACK-6075
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-6075: Increase the ram size for router service offering
> Increased the ram size of Internal load balancer vm service offering also
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/upgrade/dao/Upgrade442to450.java dc1057f
> plugins/network-elements/internal-loadbalancer/src/org/apache/cloudstack/network/lb/InternalLoadBalancerVMManager.java 803d3a5
> server/src/com/cloud/configuration/Config.java cd0824e
> server/src/com/cloud/network/router/VirtualNetworkApplianceManager.java 9fb47fd
> setup/db/db/schema-442to450.sql 107f10c
>
> Diff: https://reviews.apache.org/r/17941/diff/
>
>
> Testing
> -------
>
> tested locally
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 17941: CLOUDSTACK-6075: Increase the ram size for
router service offering
Posted by Harikrishna Patnala <ha...@citrix.com>.
> On Nov. 27, 2014, 10:15 a.m., Rohit Yadav wrote:
> > +1
> > LGTM, if any of the other designated reviewers don't object let's merge this on master/4.5; I've already picked/fixed this for 4.3 branch.
> >
> > Hari - thanks for the patch, I encourage you to use Github Pull Requests in future which I find is less painful than using reviewboard.
>
> Rajani Karuturi wrote:
> and also on 4.4 please. since its already on 4.3, it should goto all 4.3+ releases.
>
> Rohit Yadav wrote:
> Yes, Hari please send another patch (maybe via Github PR) for 4.4 branch as well? I'll help merging this on 4.5/master in the meanwhile.
Thanks Rohit, I'll put github PR for 4.4 branch
- Harikrishna
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17941/#review63196
-----------------------------------------------------------
On Nov. 27, 2014, 9:22 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17941/
> -----------------------------------------------------------
>
> (Updated Nov. 27, 2014, 9:22 a.m.)
>
>
> Review request for cloudstack, Jayapal Reddy, Kishan Kavala, and Rajani Karuturi.
>
>
> Bugs: CLOUDSTACK-6075
> https://issues.apache.org/jira/browse/CLOUDSTACK-6075
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-6075: Increase the ram size for router service offering
> Increased the ram size of Internal load balancer vm service offering also
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/upgrade/dao/Upgrade442to450.java dc1057f
> plugins/network-elements/internal-loadbalancer/src/org/apache/cloudstack/network/lb/InternalLoadBalancerVMManager.java 803d3a5
> server/src/com/cloud/configuration/Config.java cd0824e
> server/src/com/cloud/network/router/VirtualNetworkApplianceManager.java 9fb47fd
> setup/db/db/schema-442to450.sql 107f10c
>
> Diff: https://reviews.apache.org/r/17941/diff/
>
>
> Testing
> -------
>
> tested locally
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 17941: CLOUDSTACK-6075: Increase the ram size for
router service offering
Posted by Rohit Yadav <bh...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17941/#review63196
-----------------------------------------------------------
Ship it!
+1
LGTM, if any of the other designated reviewers don't object let's merge this on master/4.5; I've already picked/fixed this for 4.3 branch.
Hari - thanks for the patch, I encourage you to use Github Pull Requests in future which I find is less painful than using reviewboard.
- Rohit Yadav
On Nov. 27, 2014, 9:22 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17941/
> -----------------------------------------------------------
>
> (Updated Nov. 27, 2014, 9:22 a.m.)
>
>
> Review request for cloudstack, Jayapal Reddy, Kishan Kavala, and Rajani Karuturi.
>
>
> Bugs: CLOUDSTACK-6075
> https://issues.apache.org/jira/browse/CLOUDSTACK-6075
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-6075: Increase the ram size for router service offering
> Increased the ram size of Internal load balancer vm service offering also
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/upgrade/dao/Upgrade442to450.java dc1057f
> plugins/network-elements/internal-loadbalancer/src/org/apache/cloudstack/network/lb/InternalLoadBalancerVMManager.java 803d3a5
> server/src/com/cloud/configuration/Config.java cd0824e
> server/src/com/cloud/network/router/VirtualNetworkApplianceManager.java 9fb47fd
> setup/db/db/schema-442to450.sql 107f10c
>
> Diff: https://reviews.apache.org/r/17941/diff/
>
>
> Testing
> -------
>
> tested locally
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 17941: CLOUDSTACK-6075: Increase the ram size for
router service offering
Posted by Harikrishna Patnala <ha...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17941/
-----------------------------------------------------------
(Updated Nov. 27, 2014, 9:22 a.m.)
Review request for cloudstack, Jayapal Reddy, Kishan Kavala, and Rajani Karuturi.
Bugs: CLOUDSTACK-6075
https://issues.apache.org/jira/browse/CLOUDSTACK-6075
Repository: cloudstack-git
Description
-------
CLOUDSTACK-6075: Increase the ram size for router service offering
Increased the ram size of Internal load balancer vm service offering also
Diffs (updated)
-----
engine/schema/src/com/cloud/upgrade/dao/Upgrade442to450.java dc1057f
plugins/network-elements/internal-loadbalancer/src/org/apache/cloudstack/network/lb/InternalLoadBalancerVMManager.java 803d3a5
server/src/com/cloud/configuration/Config.java cd0824e
server/src/com/cloud/network/router/VirtualNetworkApplianceManager.java 9fb47fd
setup/db/db/schema-442to450.sql 107f10c
Diff: https://reviews.apache.org/r/17941/diff/
Testing
-------
tested locally
Thanks,
Harikrishna Patnala
Re: Review Request 17941: CLOUDSTACK-6075: Increase the ram size for
router service offering
Posted by Harikrishna Patnala <ha...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17941/
-----------------------------------------------------------
(Updated Nov. 25, 2014, 6:07 a.m.)
Review request for cloudstack, Jayapal Reddy, Kishan Kavala, and Rajani Karuturi.
Bugs: CLOUDSTACK-6075
https://issues.apache.org/jira/browse/CLOUDSTACK-6075
Repository: cloudstack-git
Description
-------
CLOUDSTACK-6075: Increase the ram size for router service offering
Increased the ram size of Internal load balancer vm service offering also
Diffs
-----
engine/schema/src/com/cloud/upgrade/dao/Upgrade441to450.java cde661b
plugins/network-elements/internal-loadbalancer/src/org/apache/cloudstack/network/lb/InternalLoadBalancerVMManager.java 803d3a5
server/src/com/cloud/configuration/Config.java 517c76c
server/src/com/cloud/network/router/VirtualNetworkApplianceManager.java 85ce8b9
setup/db/db/schema-441to450.sql c899289
Diff: https://reviews.apache.org/r/17941/diff/
Testing
-------
tested locally
Thanks,
Harikrishna Patnala
Re: Review Request 17941: CLOUDSTACK-6075: Increase the ram size for
router service offering
Posted by Harikrishna Patnala <ha...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17941/
-----------------------------------------------------------
(Updated Nov. 10, 2014, 10:20 a.m.)
Review request for cloudstack, Jayapal Reddy and Kishan Kavala.
Bugs: CLOUDSTACK-6075
https://issues.apache.org/jira/browse/CLOUDSTACK-6075
Repository: cloudstack-git
Description
-------
CLOUDSTACK-6075: Increase the ram size for router service offering
Increased the ram size of Internal load balancer vm service offering also
Diffs
-----
engine/schema/src/com/cloud/upgrade/dao/Upgrade441to450.java cde661b
plugins/network-elements/internal-loadbalancer/src/org/apache/cloudstack/network/lb/InternalLoadBalancerVMManager.java 803d3a5
server/src/com/cloud/configuration/Config.java 517c76c
server/src/com/cloud/network/router/VirtualNetworkApplianceManager.java 85ce8b9
setup/db/db/schema-441to450.sql c899289
Diff: https://reviews.apache.org/r/17941/diff/
Testing
-------
tested locally
Thanks,
Harikrishna Patnala
Re: Review Request 17941: CLOUDSTACK-6075: Increase the ram size for
router service offering
Posted by Harikrishna Patnala <ha...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17941/
-----------------------------------------------------------
(Updated Nov. 10, 2014, 10:18 a.m.)
Review request for cloudstack and Jayapal Reddy.
Bugs: CLOUDSTACK-6075
https://issues.apache.org/jira/browse/CLOUDSTACK-6075
Repository: cloudstack-git
Description
-------
CLOUDSTACK-6075: Increase the ram size for router service offering
Increased the ram size of Internal load balancer vm service offering also
Diffs (updated)
-----
engine/schema/src/com/cloud/upgrade/dao/Upgrade441to450.java cde661b
plugins/network-elements/internal-loadbalancer/src/org/apache/cloudstack/network/lb/InternalLoadBalancerVMManager.java 803d3a5
server/src/com/cloud/configuration/Config.java 517c76c
server/src/com/cloud/network/router/VirtualNetworkApplianceManager.java 85ce8b9
setup/db/db/schema-441to450.sql c899289
Diff: https://reviews.apache.org/r/17941/diff/
Testing
-------
tested locally
Thanks,
Harikrishna Patnala
Re: Review Request 17941: CLOUDSTACK-6075: Increase the ram size for router
service offering
Posted by Rohit Yadav <bh...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17941/#review50172
-----------------------------------------------------------
Looks GTM, but we'll wait for Jayapal to test/review it.
- Rohit Yadav
On Aug. 11, 2014, 9:24 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17941/
> -----------------------------------------------------------
>
> (Updated Aug. 11, 2014, 9:24 a.m.)
>
>
> Review request for cloudstack and Jayapal Reddy.
>
>
> Bugs: CLOUDSTACK-6075
> https://issues.apache.org/jira/browse/CLOUDSTACK-6075
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> CLOUDSTACK-6075: Increase the ram size for router service offering
> Increased the ram size of Internal load balancer vm service offering also
>
>
> Diffs
> -----
>
> engine/schema/src/com/cloud/upgrade/dao/Upgrade441to450.java 21b2e13
> plugins/network-elements/internal-loadbalancer/src/org/apache/cloudstack/network/lb/InternalLoadBalancerVMManager.java 803d3a5
> server/src/com/cloud/configuration/Config.java b499df5
> server/src/com/cloud/network/router/VirtualNetworkApplianceManager.java 85ce8b9
> setup/db/db/schema-441to450.sql 34d5f88
>
> Diff: https://reviews.apache.org/r/17941/diff/
>
>
> Testing
> -------
>
> tested locally
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request 17941: CLOUDSTACK-6075: Increase the ram size for router
service offering
Posted by Harikrishna Patnala <ha...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17941/
-----------------------------------------------------------
(Updated Aug. 11, 2014, 9:24 a.m.)
Review request for cloudstack and Jayapal Reddy.
Bugs: CLOUDSTACK-6075
https://issues.apache.org/jira/browse/CLOUDSTACK-6075
Repository: cloudstack-git
Description
-------
CLOUDSTACK-6075: Increase the ram size for router service offering
Increased the ram size of Internal load balancer vm service offering also
Diffs (updated)
-----
engine/schema/src/com/cloud/upgrade/dao/Upgrade441to450.java 21b2e13
plugins/network-elements/internal-loadbalancer/src/org/apache/cloudstack/network/lb/InternalLoadBalancerVMManager.java 803d3a5
server/src/com/cloud/configuration/Config.java b499df5
server/src/com/cloud/network/router/VirtualNetworkApplianceManager.java 85ce8b9
setup/db/db/schema-441to450.sql 34d5f88
Diff: https://reviews.apache.org/r/17941/diff/
Testing
-------
tested locally
Thanks,
Harikrishna Patnala