You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/04/29 02:42:18 UTC

[GitHub] [shardingsphere] zhaoguhong opened a new issue, #17196: encrypt config queryWithCipherColumn is support column levels?

zhaoguhong opened a new issue, #17196:
URL: https://github.com/apache/shardingsphere/issues/17196

   ## current
   
   ```bash
   # glable level
   spring.shardingsphere.rules.encrypt.queryWithCipherColumn=true
   # table level
   spring.shardingsphere.rules.encrypt.tables.t_encrypt.queryWithCipherColumn=true
   ```
   ## expect
   
   ```bash
   # glable level
   spring.shardingsphere.rules.encrypt.queryWithCipherColumn=true
   # table level
   spring.shardingsphere.rules.encrypt.tables.t_encrypt.queryWithCipherColumn=true
   # column level
   spring.shardingsphere.rules.encrypt.tables.t_encrypt.columns.phone.queryWithCipherColumn=true
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] cheese8 commented on issue #17196: encrypt config queryWithCipherColumn is support column levels?

Posted by GitBox <gi...@apache.org>.
cheese8 commented on issue #17196:
URL: https://github.com/apache/shardingsphere/issues/17196#issuecomment-1119225344

   > > Hi @zhaoguhong what is your business scenario, and you need to switch between encryption and decryption at the column level?
   > 
   > My table, contains historical data
   > 
   > ```sql
   > create table t_encrypt
   > (
   >     id           bigint unsigned auto_increment primary key,
   >     phone        varchar(100) null,
   >     address       varchar(100) null
   > );
   > ```
   > 
   > After encryption the phone column
   > 
   > now `queryWithCipherColumn` is true
   > 
   > but my boss say address also need to encrypt,What should I do?
   
   As now `queryWithCipherColumn `  effected on global and table level, maybe you can rollback the `phone` column, when the whole table finished encryption, then commit the whole table. @zhaoguhong


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] cheese8 commented on issue #17196: encrypt config queryWithCipherColumn is support column levels?

Posted by GitBox <gi...@apache.org>.
cheese8 commented on issue #17196:
URL: https://github.com/apache/shardingsphere/issues/17196#issuecomment-1113130109

   OK, I got it. I think it should be supported, what do you think? @strongduanmu 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] strongduanmu commented on issue #17196: encrypt config queryWithCipherColumn is support column levels?

Posted by GitBox <gi...@apache.org>.
strongduanmu commented on issue #17196:
URL: https://github.com/apache/shardingsphere/issues/17196#issuecomment-1113239042

   From this scenario, it is indeed necessary, but this solution will make the encrypt rewrite logic more complicated, and we need to evaluate all possible problems in detail, such as performance and code maintainability.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] zhaoguhong commented on issue #17196: encrypt config queryWithCipherColumn is support column levels?

Posted by GitBox <gi...@apache.org>.
zhaoguhong commented on issue #17196:
URL: https://github.com/apache/shardingsphere/issues/17196#issuecomment-1112842489

   > Hi @zhaoguhong what is your business scenario, and you need to switch between encryption and decryption at the column level?
   
   My table, contains historical data
   
   ```sql
   create table t_encrypt
   (
       id           bigint unsigned auto_increment primary key,
       phone        varchar(100) null,
       address       varchar(100) null
   );
   ```
   After encryption the phone column
   
   now  `queryWithCipherColumn` is true
   
   ---
   
   but my boss say address also need to encrypt,What should I do?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] strongduanmu commented on issue #17196: encrypt config queryWithCipherColumn is support column levels?

Posted by GitBox <gi...@apache.org>.
strongduanmu commented on issue #17196:
URL: https://github.com/apache/shardingsphere/issues/17196#issuecomment-1112832527

   Hi @zhaoguhong what is your business scenario, and you need to switch between encryption and decryption at the column level?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] cheese8 closed issue #17196: encrypt config queryWithCipherColumn is support column levels?

Posted by GitBox <gi...@apache.org>.
cheese8 closed issue #17196: encrypt config  queryWithCipherColumn is  support column levels?
URL: https://github.com/apache/shardingsphere/issues/17196


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] zhaoguhong commented on issue #17196: encrypt config queryWithCipherColumn is support column levels?

Posted by GitBox <gi...@apache.org>.
zhaoguhong commented on issue #17196:
URL: https://github.com/apache/shardingsphere/issues/17196#issuecomment-1113033832

   > Your `address` column need to be encrypted too , do it need to be queryed in `where condition`?@zhaoguhong
   
   yes, not only address, other fields also need to encrypt


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] zhaoguhong commented on issue #17196: encrypt config queryWithCipherColumn is support column levels?

Posted by GitBox <gi...@apache.org>.
zhaoguhong commented on issue #17196:
URL: https://github.com/apache/shardingsphere/issues/17196#issuecomment-1120797202

   > > > Hi @zhaoguhong what is your business scenario, and you need to switch between encryption and decryption at the column level?
   > > 
   > > 
   > > My table, contains historical data
   > > ```sql
   > > create table t_encrypt
   > > (
   > >     id           bigint unsigned auto_increment primary key,
   > >     phone        varchar(100) null,
   > >     address       varchar(100) null
   > > );
   > > ```
   > > 
   > > 
   > >     
   > >       
   > >     
   > > 
   > >       
   > >     
   > > 
   > >     
   > >   
   > > After encryption the phone column
   > > now `queryWithCipherColumn` is true
   > > but my boss say address also need to encrypt,What should I do?
   > 
   > As now `queryWithCipherColumn ` effected on global and table level, maybe you can rollback the `phone` column, when the whole table finished encryption, then commit the whole table. @zhaoguhong
   
   ok,I see


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] cheese8 commented on issue #17196: encrypt config queryWithCipherColumn is support column levels?

Posted by GitBox <gi...@apache.org>.
cheese8 commented on issue #17196:
URL: https://github.com/apache/shardingsphere/issues/17196#issuecomment-1112991047

   Your `address` column need to be encrypted too , do it need to be queryed in `where condition`?@zhaoguhong


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] cheese8 commented on issue #17196: encrypt config queryWithCipherColumn is support column levels?

Posted by GitBox <gi...@apache.org>.
cheese8 commented on issue #17196:
URL: https://github.com/apache/shardingsphere/issues/17196#issuecomment-1112832486

   What kind of scene the column level `queryWithCipherColumn`  is needed?It feels just too fine-grained on column level.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [shardingsphere] cheese8 commented on issue #17196: encrypt config queryWithCipherColumn is support column levels?

Posted by GitBox <gi...@apache.org>.
cheese8 commented on issue #17196:
URL: https://github.com/apache/shardingsphere/issues/17196#issuecomment-1113919914

   Assign me please , I am following it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org