[GitHub] [druid] jihoonson commented on a change in pull request #11123: Avoid memory mapping hydrants after they are persisted & after they are merged for native batch ingestion

[GitBox <gi...@apache.org>]

jihoonson commented on a change in pull request #11123:
URL: https://github.com/apache/druid/pull/11123#discussion_r626027999



##########
File path: server/src/main/java/org/apache/druid/segment/realtime/appenderator/AppenderatorImpl.java
##########
@@ -558,35 +570,44 @@ public void clear() throws InterruptedException
     final List<Pair<FireHydrant, SegmentIdWithShardSpec>> indexesToPersist = new ArrayList<>();
     int numPersistedRows = 0;
     long bytesPersisted = 0L;
+    AtomicLong totalHydrantsCount = new AtomicLong();

Review comment:
       Please do not use concurrent data structures where there is no concurrent access from multiple threads. It makes code very confusing. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org