You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iceberg.apache.org by li...@apache.org on 2026/08/21 09:43:18 UTC

(iceberg-rust) branch main updated: chore: Enable automatic review by GitHub Copilot on PRs on behalf of author (#3031)

This is an automated email from the ASF dual-hosted git repository.

blackmwk pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/iceberg-rust.git


The following commit(s) were added to refs/heads/main by this push:
     new c77de4a70 chore: Enable automatic review by GitHub Copilot on PRs on behalf of author (#3031)
c77de4a70 is described below

commit c77de4a7099f229ea51c50853bffec0ecba2d3c8
Author: Daniel Carl Jones <dj...@amazon.com>
AuthorDate: Fri Aug 21 10:43:13 2026 +0100

    chore: Enable automatic review by GitHub Copilot on PRs on behalf of author (#3031)
    
    * chore: Enable automatic review by GitHub Copilot on PRs on behalf of author
    
    Co-Authored-By: Gang Wu <us...@gmail.com>
    
    * Disable Copilot review on new pushes
    
    * Remove license header from copilot-instructions.md
    
    ---------
    
    Co-authored-by: Gang Wu <us...@gmail.com>
---
 .asf.yaml                       |  4 ++++
 .github/copilot-instructions.md | 21 +++++++++++++++++++++
 .licenserc.yaml                 |  2 ++
 3 files changed, 27 insertions(+)

diff --git a/.asf.yaml b/.asf.yaml
index 2bfcb74dd..1b32ea013 100644
--- a/.asf.yaml
+++ b/.asf.yaml
@@ -59,6 +59,10 @@ github:
     - CTTY
   ghp_branch: gh-pages
   ghp_path: /
+  copilot_code_review:
+    enabled: true
+    review_drafts: false
+    review_on_push: false
 
 notifications:
   commits: commits@iceberg.apache.org
diff --git a/.github/copilot-instructions.md b/.github/copilot-instructions.md
new file mode 100644
index 000000000..3744d6f43
--- /dev/null
+++ b/.github/copilot-instructions.md
@@ -0,0 +1,21 @@
+# Instructions
+
+## Code review
+
+You are a pragmatic senior Rust developer.
+When reviewing pull requests, follow these rules to avoid noise and redundancy:
+
+- Be concise: Keep comments brief and to the point. Avoid
+  conversational filler or praising the code unless it's exceptional.
+- High-impact only: Focus on logic errors, security vulnerabilities,
+  performance bottlenecks, and breaking changes.
+- Skip the Obvious: Do not describe what the code is doing. Assume the
+  reader understands the code.
+- Ignore trivialities: Do not comment on minor style issues or things
+  that an automated linter should catch.
+- Single comment per issue: If the same pattern occurs multiple times,
+  mention it once and suggest a global fix instead of commenting on
+  every line.
+- First-time contributors: For users new to this repository,
+  explicitly instruct them to "Please check and address all review
+  comments in this PR."
diff --git a/.licenserc.yaml b/.licenserc.yaml
index b25fbaceb..9959b0be4 100644
--- a/.licenserc.yaml
+++ b/.licenserc.yaml
@@ -38,7 +38,9 @@ header:
     - "target"
     - "Cargo.lock"
     - "bindings/python/uv.lock"
+    # GitHub configuration
     - ".github/PULL_REQUEST_TEMPLATE.md"
+    - ".github/copilot-instructions.md"
     # Python environment
     - "bindings/python/.venv/"
     - "bindings/python/.pytest_cache/"