You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/07/22 12:18:04 UTC
[GitHub] [airflow] potiuk opened a new pull request, #25231: Fix order of returned rows in a flaky test_outlets_dataset test
potiuk opened a new pull request, #25231:
URL: https://github.com/apache/airflow/pull/25231
In Postgres especially (but in generaly in all databases, if
there is no order specified in select query, the rows might
come in random order. It depends on many factors.
The test query here retrieved the dags without any order but
expected the list to be in specific order.
This PR adds ordering.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] blag commented on pull request #25231: Fix order of returned rows in a flaky test_outlets_dataset test
Posted by GitBox <gi...@apache.org>.
blag commented on PR #25231:
URL: https://github.com/apache/airflow/pull/25231#issuecomment-1192845884
LGTM, thanks! 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25231: Fix order of returned rows in a flaky test_outlets_dataset test
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25231:
URL: https://github.com/apache/airflow/pull/25231#issuecomment-1192553561
Looks green.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish commented on pull request #25231: Fix order of returned rows in a flaky test_outlets_dataset test
Posted by GitBox <gi...@apache.org>.
dstandish commented on PR #25231:
URL: https://github.com/apache/airflow/pull/25231#issuecomment-1192727307
> cc: @dstandish - mental note (also to self, been there done that). Order every query :)
thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25231: Fix order of returned rows in a flaky test_outlets_dataset test
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25231:
URL: https://github.com/apache/airflow/pull/25231#issuecomment-1192514680
cc: @dstandish - mental note (also to self, been there done that). Order every query :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #25231: Fix order of returned rows in a flaky test_outlets_dataset test
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #25231:
URL: https://github.com/apache/airflow/pull/25231
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25231: Fix order of returned rows in a flaky test_outlets_dataset test
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25231:
URL: https://github.com/apache/airflow/pull/25231#issuecomment-1192855346
> LGTM, thanks! 😄
Yeah. Flaky tests are the worst and the sooner we kill them the better :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25231: Fix order of returned rows in a flaky test_outlets_dataset test
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25231:
URL: https://github.com/apache/airflow/pull/25231#issuecomment-1192563380
> Unordered queries; recipe for a race condition :)
Indeed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org