You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/18 19:11:21 UTC
[GitHub] [superset] ktmud opened a new pull request #13221: refactor(explore): convert ControlPanelsContainer to typescript
ktmud opened a new pull request #13221:
URL: https://github.com/apache/superset/pull/13221
### SUMMARY
Convert ControlPanelsContainer and some other related components to TypeScript.
Big refactoring are coming to chart controls and the Explore page, in order to support reading query results in controls, which is needed for things like ad-hoc column formatting in table chart.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
There should be no visible change.
### TEST PLAN
CI and manual testing the chart control area.
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13221: refactor(explore): convert ControlPanelsContainer to typescript
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13221:
URL: https://github.com/apache/superset/pull/13221#issuecomment-784956394
# [Codecov](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=h1) Report
> Merging [#13221](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=desc) (e1a27cf) into [master](https://codecov.io/gh/apache/superset/commit/0b114fcbc58751c84b5e0c1f1a1024e6adf1bed7?el=desc) (0b114fc) will **decrease** coverage by `18.69%`.
> The diff coverage is `80.89%`.
[](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13221 +/- ##
===========================================
- Coverage 77.21% 58.51% -18.70%
===========================================
Files 872 481 -391
Lines 45140 15977 -29163
Branches 5435 4124 -1311
===========================================
- Hits 34854 9349 -25505
+ Misses 10163 6628 -3535
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `58.51% <80.89%> (-0.02%)` | :arrow_down: |
| javascript | `?` | |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/constants.ts](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbnN0YW50cy50cw==) | `100.00% <ø> (ø)` | |
| [...nd/src/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlVmlld0NvbnRhaW5lci5qc3g=) | `79.50% <ø> (+1.32%)` | :arrow_up: |
| [.../explore/components/controls/CollectionControl.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Db2xsZWN0aW9uQ29udHJvbC5qc3g=) | `45.45% <ø> (+3.78%)` | :arrow_up: |
| [.../controls/MetricControl/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIuanN4) | `77.09% <ø> (-2.01%)` | :arrow_down: |
| [...nents/controls/MetricControl/AdhocMetricOption.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
| [...ntrols/MetricControl/AdhocMetricPopoverTrigger.tsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljUG9wb3ZlclRyaWdnZXIudHN4) | `88.00% <ø> (-6.74%)` | :arrow_down: |
| [...mponents/controls/MetricControl/MetricsControl.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL01ldHJpY3NDb250cm9sLmpzeA==) | `57.05% <0.00%> (-33.06%)` | :arrow_down: |
| [...uperset-frontend/src/explore/controlUtils/index.js](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFV0aWxzL2luZGV4Lmpz) | `74.31% <ø> (ø)` | |
| [superset-frontend/src/explore/controls.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbHMuanN4) | `16.45% <0.00%> (-10.38%)` | :arrow_down: |
| [...et-frontend/src/explore/reducers/exploreReducer.js](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZXhwbG9yZVJlZHVjZXIuanM=) | `33.33% <0.00%> (-11.67%)` | :arrow_down: |
| ... and [754 more](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=footer). Last update [0b114fc...cb1dd58](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #13221: refactor(explore): convert ControlPanelsContainer to typescript
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on pull request #13221:
URL: https://github.com/apache/superset/pull/13221#issuecomment-787964924
@ktmud I found this typescript error:
<img width="1333" alt="Screen Shot 2021-03-01 at 8 17 06 AM" src="https://user-images.githubusercontent.com/70410625/109493393-312c2c80-7a6b-11eb-9f41-47e5367c9fd4.png">
<img width="1316" alt="Screen Shot 2021-03-01 at 8 17 23 AM" src="https://user-images.githubusercontent.com/70410625/109493430-40ab7580-7a6b-11eb-86bc-63ca257f3664.png">
<img width="1242" alt="Screen Shot 2021-03-01 at 8 17 46 AM" src="https://user-images.githubusercontent.com/70410625/109493436-430dcf80-7a6b-11eb-8954-8366f13f1e0c.png">
It's happening because `tooltip` is declared as a `string` in `InfoTooltipWithTrigger` but the description is declared as `ReactNode` in `ControlPanelSectionConfig`.
I was going to fix it, but I was afraid of not having all the necessary context since this touches `superset-ui` plugins.
Shouldn't CI catch this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on a change in pull request #13221: refactor(explore): convert ControlPanelsContainer to typescript
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #13221:
URL: https://github.com/apache/superset/pull/13221#discussion_r581535633
##########
File path: superset-frontend/.eslintrc.js
##########
@@ -226,6 +227,7 @@ module.exports = {
'no-mixed-operators': 0,
'no-multi-assign': 0,
'no-multi-spaces': 0,
+ 'no-nested-ternary': 0,
Review comment:
nested ternary was used in this code:
```ts
const controlName =
typeof item === 'string'
? item
: item && 'name' in item
? item.name
: null;
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #13221: refactor(explore): convert ControlPanelsContainer to typescript
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on pull request #13221:
URL: https://github.com/apache/superset/pull/13221#issuecomment-788238232
@ktmud Strangely I ran `npm install` and it didn't work. It only worked after deleting `@superset-ui` in `node_modules` and reinstalling it. At least it's working now. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud merged pull request #13221: refactor(explore): convert ControlPanelsContainer to typescript
Posted by GitBox <gi...@apache.org>.
ktmud merged pull request #13221:
URL: https://github.com/apache/superset/pull/13221
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13221: refactor(explore): convert ControlPanelsContainer to typescript
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13221:
URL: https://github.com/apache/superset/pull/13221#issuecomment-784956394
# [Codecov](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=h1) Report
> Merging [#13221](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=desc) (e1a27cf) into [master](https://codecov.io/gh/apache/superset/commit/0b114fcbc58751c84b5e0c1f1a1024e6adf1bed7?el=desc) (0b114fc) will **decrease** coverage by `18.69%`.
> The diff coverage is `80.89%`.
[](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13221 +/- ##
===========================================
- Coverage 77.21% 58.51% -18.70%
===========================================
Files 872 481 -391
Lines 45140 15977 -29163
Branches 5435 4124 -1311
===========================================
- Hits 34854 9349 -25505
+ Misses 10163 6628 -3535
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `58.51% <80.89%> (-0.02%)` | :arrow_down: |
| javascript | `?` | |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/constants.ts](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbnN0YW50cy50cw==) | `100.00% <ø> (ø)` | |
| [...nd/src/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlVmlld0NvbnRhaW5lci5qc3g=) | `79.50% <ø> (+1.32%)` | :arrow_up: |
| [.../explore/components/controls/CollectionControl.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Db2xsZWN0aW9uQ29udHJvbC5qc3g=) | `45.45% <ø> (+3.78%)` | :arrow_up: |
| [.../controls/MetricControl/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIuanN4) | `77.09% <ø> (-2.01%)` | :arrow_down: |
| [...nents/controls/MetricControl/AdhocMetricOption.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
| [...ntrols/MetricControl/AdhocMetricPopoverTrigger.tsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljUG9wb3ZlclRyaWdnZXIudHN4) | `88.00% <ø> (-6.74%)` | :arrow_down: |
| [...mponents/controls/MetricControl/MetricsControl.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL01ldHJpY3NDb250cm9sLmpzeA==) | `57.05% <0.00%> (-33.06%)` | :arrow_down: |
| [...uperset-frontend/src/explore/controlUtils/index.js](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFV0aWxzL2luZGV4Lmpz) | `74.31% <ø> (ø)` | |
| [superset-frontend/src/explore/controls.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbHMuanN4) | `16.45% <0.00%> (-10.38%)` | :arrow_down: |
| [...et-frontend/src/explore/reducers/exploreReducer.js](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZXhwbG9yZVJlZHVjZXIuanM=) | `33.33% <0.00%> (-11.67%)` | :arrow_down: |
| ... and [754 more](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=footer). Last update [0b114fc...cb1dd58](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on pull request #13221: refactor(explore): convert ControlPanelsContainer to typescript
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #13221:
URL: https://github.com/apache/superset/pull/13221#issuecomment-786401870
> I also noticed a few usages of type assertion throughout. I assume they were there for a good reason, but it makes me a bit nervous. Maybe go through one more time to ensure they're all needed?
Good call. I did a sweep and managed to find one place that I could optimize: https://github.com/apache/superset/pull/13221/commits/caf3b60b895126d524f2a4a601530ada1c1d399b
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on pull request #13221: refactor(explore): convert ControlPanelsContainer to typescript
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #13221:
URL: https://github.com/apache/superset/pull/13221#issuecomment-785560975
Close to re-trigger full CI to fix test coverage report.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on a change in pull request #13221: refactor(explore): convert ControlPanelsContainer to typescript
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #13221:
URL: https://github.com/apache/superset/pull/13221#discussion_r578685551
##########
File path: superset-frontend/src/visualizations/FilterBox/FilterBox.jsx
##########
@@ -298,7 +298,6 @@ class FilterBox extends React.PureComponent {
datasourceFilters.push(
<ControlRow
key="sqla-filters"
- className="control-row"
Review comment:
This prop is not used in the `ControlRow` component.
##########
File path: superset-frontend/src/explore/actions/exploreActions.ts
##########
@@ -109,11 +109,6 @@ export function setExploreControls(formData: QueryFormData) {
return { type: SET_EXPLORE_CONTROLS, formData };
}
-export const REMOVE_CONTROL_PANEL_ALERT = 'REMOVE_CONTROL_PANEL_ALERT';
-export function removeControlPanelAlert() {
- return { type: REMOVE_CONTROL_PANEL_ALERT };
-}
Review comment:
Cleaning up dead code.
<img width="530" alt="alert-deprecated" src="https://user-images.githubusercontent.com/335541/108408702-391dde00-71da-11eb-811e-ffdaf3be596a.png">
This is the alert this action is trying to clear, which we are not using anymore.
##########
File path: superset-frontend/src/explore/controls.jsx
##########
@@ -355,8 +355,9 @@ export const controls = {
"using the engine's local timezone. Note one can explicitly set the timezone " +
'per the ISO 8601 format if specifying either the start and/or end time.',
),
- mapStateToProps: state => ({
- endpoints: state.form_data ? state.form_data.time_range_endpoints : null,
+ provideFormDataToProps: true,
Review comment:
Need to add this in `superset-ui/chart-controls`, too.
##########
File path: superset-frontend/src/explore/components/ControlPanelsContainer.tsx
##########
@@ -161,29 +178,39 @@ class ControlPanelsContainer extends React.Component {
validationErrors={validationErrors}
actions={actions}
formData={provideFormDataToProps ? formData : null}
- datasource={formData?.datasource}
Review comment:
Remove this exposed `datasource` prop from #12609 since it's already available in `formData`, plus The typing would not conform with `datasource` for `DatasourceControl`, which uses the whole metadata of a datasource.
cc @pkdotson @zhaoyongjie
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on a change in pull request #13221: refactor(explore): convert ControlPanelsContainer to typescript
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #13221:
URL: https://github.com/apache/superset/pull/13221#discussion_r579570782
##########
File path: superset-frontend/src/explore/components/controls/TextControl.tsx
##########
@@ -102,26 +86,26 @@ export default class TextControl extends React.Component<
parsedValue = parseInt(inputValue, 10);
}
}
- this.props.onChange?.(parsedValue, errors);
+ this.props.onChange?.(parsedValue as T, errors);
};
- onChangeWrapper = (event: any) => {
- const { value } = event.target;
- this.setState({ value });
+ debouncedOnChange = debounce((inputValue: string) => {
+ this.onChange(inputValue);
+ }, FAST_DEBOUNCE);
- // use debounce when change takes effect immediately after user starts typing
- const onChange = this.props.renderTrigger
- ? this.debouncedOnChange
- : this.onChange;
- onChange(value);
+ onChangeWrapper: FormControlProps['onChange'] = event => {
+ const { value } = event.target as HTMLInputElement;
+ this.setState({ value }, () => {
+ this.debouncedOnChange(value);
+ });
Review comment:
Did more refactoring based on: https://github.com/apache/superset/pull/13211#issuecomment-782418459
##########
File path: superset-frontend/src/explore/components/controls/FilterControl/AdhocFilterControl.jsx
##########
@@ -270,7 +262,7 @@ class AdhocFilterControl extends React.Component {
optionsForSelect(props) {
const options = [
...props.columns,
- ...[...(props.formData.metrics || []), props.formData.metric].map(
+ ...[...(props.selectedMetrics || [])].map(
Review comment:
This is used for allowing selecting adhoc metrics in adhoc filters, but it has stopping working:
https://github.com/apache/superset/issues/13249
The new `selectedMetrics` will be added by a `superset-ui` PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] etr2460 commented on a change in pull request #13221: refactor(explore): convert ControlPanelsContainer to typescript
Posted by GitBox <gi...@apache.org>.
etr2460 commented on a change in pull request #13221:
URL: https://github.com/apache/superset/pull/13221#discussion_r583311405
##########
File path: superset-frontend/.eslintrc.js
##########
@@ -226,6 +227,7 @@ module.exports = {
'no-mixed-operators': 0,
'no-multi-assign': 0,
'no-multi-spaces': 0,
+ 'no-nested-ternary': 0,
Review comment:
Yeah, I'm a fan of nested ternaries when used sparingly. however, couldn't this be simplified to:
```typescript
const controlName =
typeof item === 'string'
? item
: (item || {})?.name ?? null;
```
or something like that?
##########
File path: superset-frontend/.eslintrc.js
##########
@@ -226,6 +227,7 @@ module.exports = {
'no-mixed-operators': 0,
'no-multi-assign': 0,
'no-multi-spaces': 0,
+ 'no-nested-ternary': 0,
Review comment:
Not sure if that's really cleaner, but it doesn't use a nested ternary
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on a change in pull request #13221: refactor(explore): convert ControlPanelsContainer to typescript
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #13221:
URL: https://github.com/apache/superset/pull/13221#discussion_r581793246
##########
File path: superset-frontend/cypress-base/cypress/integration/explore/visualizations/pivot_table.test.js
##########
@@ -28,7 +28,7 @@ describe('Visualization > Pivot Table', () => {
adhoc_filters: [],
groupby: ['name'],
columns: ['state'],
- row_limit: 50000,
+ row_limit: 5000,
Review comment:
Reduce row limit to speed up the test (a little bit)
##########
File path: superset-frontend/src/explore/components/ControlPanelsContainer.tsx
##########
@@ -80,60 +94,56 @@ const ControlPanelsTabs = styled(Tabs)`
height: 100%;
}
`;
-class ControlPanelsContainer extends React.Component {
+
+class ControlPanelsContainer extends React.Component<ControlPanelsContainerProps> {
// trigger updates to the component when async plugins load
static contextType = PluginContext;
- constructor(props) {
+ constructor(props: ControlPanelsContainerProps) {
super(props);
-
- this.removeAlert = this.removeAlert.bind(this);
this.renderControl = this.renderControl.bind(this);
this.renderControlPanelSection = this.renderControlPanelSection.bind(this);
}
- componentDidUpdate(prevProps) {
+ componentDidUpdate(prevProps: ControlPanelsContainerProps) {
const {
actions: { setControlValue },
} = this.props;
+ // reset controls using column info (metric, group by, sort by, filter, etc.)
+ // to default values when datasource changes.
if (this.props.form_data.datasource !== prevProps.form_data.datasource) {
- const defaultValues = [
- 'MetricsControl',
- 'AdhocFilterControl',
- 'TextControl',
- 'SelectControl',
- 'CheckboxControl',
- 'AnnotationLayerControl',
- ];
- Object.entries(this.props.controls).forEach(([controlName, control]) => {
- const { type, default: defaultValue } = control;
- if (defaultValues.includes(type)) {
- setControlValue(controlName, defaultValue);
- }
- });
+ Object.entries(this.props.controls).forEach(
+ ([controlName, controlState]) => {
+ if (
+ // for direct column select controls
+ controlState.valueKey === 'column_name' ||
+ // for all other controls
+ 'columns' in controlState
Review comment:
Instead of check control types, I check whether the control uses column select.
##########
File path: superset-frontend/src/explore/components/controls/DateFilterControl/DateFilterControl.tsx
##########
@@ -205,9 +207,9 @@ export default function DateFilterControl(props: DateFilterLabelProps) {
+--------------+------+----------+--------+----------+-----------+
*/
if (
- frame === 'Common' ||
- frame === 'Calendar' ||
- frame === 'No filter'
+ guessedFrame === 'Common' ||
+ guessedFrame === 'Calendar' ||
+ guessedFrame === 'No filter'
Review comment:
Always use `guessedFrame` to tooltip and actual time range display because when passing in a new `value` and the popover is not open, the current frame may be inconsistent with the actual value.
This makes sure `Last week` is always displayed in the pill instead of tooltip.
##########
File path: superset-frontend/src/explore/components/controls/MetricControl/AdhocMetricEditPopover.jsx
##########
@@ -123,9 +123,6 @@ export default class AdhocMetricEditPopover extends React.PureComponent {
adhocMetricLabel: this.state.adhocMetric?.getDefaultLabel(),
});
}
- if (prevProps.datasource !== this.props.datasource) {
- this.props.onChange(null);
- }
Review comment:
Clean up the `datasource` prop from adhoc metric popovers as they don't seem to affect the ability of the controls to reset values when changing datasource.
@pkdotson do you remember what was these for when you added them?
##########
File path: superset-frontend/src/explore/components/controls/CollectionControl.jsx
##########
@@ -69,12 +69,6 @@ export default class CollectionControl extends React.Component {
this.onAdd = this.onAdd.bind(this);
}
- componentDidUpdate(prevProps) {
- if (prevProps.datasource.name !== this.props.datasource.name) {
Review comment:
This one does not work anyway (i.e. change datasource will not reset Time-series Table columns, and the filters collection in FilterBox) since previously `props.datasource` is passed as a string.
I don't plan to implement this reset because these control values should not be reset when changing datasource.
##########
File path: superset-frontend/src/explore/constants.ts
##########
@@ -55,12 +55,7 @@ export const HAVING_OPERATORS = [
OPERATORS['>='],
OPERATORS['<='],
];
-export const MULTI_OPERATORS = new Set([
- OPERATORS.in,
Review comment:
`OPERATORS.in` and `OPERATORS['not in']` are `undefined`, as identified by converting to typescript, so cleaning them up. `AchocFilter` already always convert the operator into uppercase.
##########
File path: superset-frontend/src/explore/reducers/exploreReducer.js
##########
@@ -61,6 +62,12 @@ export default function exploreReducer(state = {}, action) {
delete newFormData.time_grain_sqla;
}
}
+ if (
+ action.datasource.id !== state.datasource.id ||
+ action.datasource.type !== state.datasource.type
+ ) {
+ newFormData.time_range = DEFAULT_TIME_RANGE;
+ }
Review comment:
Instead of checking control types, I now check whether a control depends on datasource columns.
##########
File path: superset-frontend/src/explore/controlUtils/getFormDataFromControls.ts
##########
@@ -0,0 +1,34 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import { QueryFormData } from '@superset-ui/core';
+import { ControlStateMapping } from '@superset-ui/chart-controls';
+
+export function getFormDataFromControls(
+ controlsState: ControlStateMapping,
+): QueryFormData {
+ const formData: QueryFormData = {
+ viz_type: 'table',
+ datasource: '',
+ };
+ Object.keys(controlsState).forEach(controlName => {
+ const control = controlsState[controlName];
+ formData[controlName] = control.value;
+ });
+ return formData;
+}
Review comment:
Split functions in `controlUtils` to TypeScript one by one...
##########
File path: superset-frontend/src/explore/components/ControlPanelsContainer.tsx
##########
@@ -80,60 +94,34 @@ const ControlPanelsTabs = styled(Tabs)`
height: 100%;
}
`;
-class ControlPanelsContainer extends React.Component {
+
+class ControlPanelsContainer extends React.Component<ControlPanelsContainerProps> {
// trigger updates to the component when async plugins load
static contextType = PluginContext;
- constructor(props) {
+ constructor(props: ControlPanelsContainerProps) {
super(props);
-
- this.removeAlert = this.removeAlert.bind(this);
this.renderControl = this.renderControl.bind(this);
this.renderControlPanelSection = this.renderControlPanelSection.bind(this);
}
- componentDidUpdate(prevProps) {
- const {
- actions: { setControlValue },
- } = this.props;
- if (this.props.form_data.datasource !== prevProps.form_data.datasource) {
- const defaultValues = [
- 'MetricsControl',
- 'AdhocFilterControl',
- 'TextControl',
- 'SelectControl',
- 'CheckboxControl',
- 'AnnotationLayerControl',
- ];
- Object.entries(this.props.controls).forEach(([controlName, control]) => {
- const { type, default: defaultValue } = control;
- if (defaultValues.includes(type)) {
- setControlValue(controlName, defaultValue);
- }
- });
- }
- }
Review comment:
Moved the resetting logic to reducers as each of these `setControlValue` call here will cause another re-rendering.
##########
File path: superset-frontend/src/explore/components/ControlPanelsContainer.tsx
##########
@@ -318,26 +328,19 @@ class ControlPanelsContainer extends React.Component {
}
}
-ControlPanelsContainer.propTypes = propTypes;
-
-function mapStateToProps({ explore }) {
- return {
- alert: explore.controlPanelAlert,
- isDatasourceMetaLoading: explore.isDatasourceMetaLoading,
- controls: explore.controls,
- exploreState: explore,
- };
-}
Review comment:
Move to inline function to use inferred types.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13221: refactor(explore): convert ControlPanelsContainer to typescript
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13221:
URL: https://github.com/apache/superset/pull/13221#issuecomment-784956394
# [Codecov](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=h1) Report
> Merging [#13221](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=desc) (a700205) into [master](https://codecov.io/gh/apache/superset/commit/0b114fcbc58751c84b5e0c1f1a1024e6adf1bed7?el=desc) (0b114fc) will **decrease** coverage by `14.86%`.
> The diff coverage is `57.98%`.
[](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13221 +/- ##
===========================================
- Coverage 77.21% 62.35% -14.87%
===========================================
Files 872 577 -295
Lines 45140 20989 -24151
Branches 5435 5438 +3
===========================================
- Hits 34854 13087 -21767
+ Misses 10163 7692 -2471
- Partials 123 210 +87
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.35% <57.98%> (+0.01%)` | :arrow_up: |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...et-frontend/src/components/Icons/icons.stories.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbnMvaWNvbnMuc3Rvcmllcy5qc3g=) | `0.00% <0.00%> (ø)` | |
| [...c/components/ListViewCard/ListViewCard.stories.tsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXdDYXJkL0xpc3RWaWV3Q2FyZC5zdG9yaWVzLnRzeA==) | `0.00% <0.00%> (ø)` | |
| [...set-frontend/src/components/ListViewCard/index.tsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXdDYXJkL2luZGV4LnRzeA==) | `100.00% <ø> (+5.45%)` | :arrow_up: |
| [superset-frontend/src/constants.ts](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbnN0YW50cy50cw==) | `100.00% <ø> (ø)` | |
| [...nd/src/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlVmlld0NvbnRhaW5lci5qc3g=) | `2.43% <ø> (-75.75%)` | :arrow_down: |
| [.../explore/components/controls/CollectionControl.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Db2xsZWN0aW9uQ29udHJvbC5qc3g=) | `21.21% <ø> (-20.46%)` | :arrow_down: |
| [.../controls/MetricControl/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIuanN4) | `57.57% <ø> (-21.53%)` | :arrow_down: |
| [...nents/controls/MetricControl/AdhocMetricOption.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljT3B0aW9uLmpzeA==) | `72.72% <ø> (-27.28%)` | :arrow_down: |
| [...ntrols/MetricControl/AdhocMetricPopoverTrigger.tsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljUG9wb3ZlclRyaWdnZXIudHN4) | `68.42% <ø> (-26.32%)` | :arrow_down: |
| [...uperset-frontend/src/explore/controlUtils/index.js](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFV0aWxzL2luZGV4Lmpz) | `92.66% <ø> (ø)` | |
| ... and [547 more](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=footer). Last update [0b114fc...cb1dd58](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on a change in pull request #13221: refactor(explore): convert ControlPanelsContainer to typescript
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #13221:
URL: https://github.com/apache/superset/pull/13221#discussion_r583371682
##########
File path: superset-frontend/.eslintrc.js
##########
@@ -226,6 +227,7 @@ module.exports = {
'no-mixed-operators': 0,
'no-multi-assign': 0,
'no-multi-spaces': 0,
+ 'no-nested-ternary': 0,
Review comment:
`'name' in item` is needed for type inference so to avoid forced type conversion as `item` can be of many types, otherwise this could also be as simple as `item?.name || item || null`.
Here's the error with your approach:
<img width="1143" alt="Screen Shot 2021-02-25 at 6 10 55 PM" src="https://user-images.githubusercontent.com/335541/109253871-95b66580-77a5-11eb-93fc-be914d8fe470.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud edited a comment on pull request #13221: refactor(explore): convert ControlPanelsContainer to typescript
Posted by GitBox <gi...@apache.org>.
ktmud edited a comment on pull request #13221:
URL: https://github.com/apache/superset/pull/13221#issuecomment-788232044
@michael-s-molina Did you run `npm install` or was your `superset-ui/chart-controls` linked to a different version? CI didn't catch it because it was actually working?
I'm pretty sure this was updated here: https://github.com/apache-superset/superset-ui/pull/962/files#diff-efc1b32a915b3738e7689b97eab6576ac7b206bc95d46e1ecaac6c8646287a65R27
The `superset-ui` change was supposed to be added in this PR but [another PR](https://github.com/apache/superset/pull/13210) has upgraded them anyway.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13221: refactor(explore): convert ControlPanelsContainer to typescript
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13221:
URL: https://github.com/apache/superset/pull/13221#issuecomment-784956394
# [Codecov](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=h1) Report
> Merging [#13221](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=desc) (b64f6ea) into [master](https://codecov.io/gh/apache/superset/commit/0b114fcbc58751c84b5e0c1f1a1024e6adf1bed7?el=desc) (0b114fc) will **decrease** coverage by `26.83%`.
> The diff coverage is `71.91%`.
[](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13221 +/- ##
===========================================
- Coverage 77.21% 50.37% -26.84%
===========================================
Files 872 479 -393
Lines 45140 15927 -29213
Branches 5435 4100 -1335
===========================================
- Hits 34854 8024 -26830
+ Misses 10163 7903 -2260
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.37% <71.91%> (-8.16%)` | :arrow_down: |
| javascript | `?` | |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/constants.ts](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbnN0YW50cy50cw==) | `100.00% <ø> (ø)` | |
| [...nd/src/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlVmlld0NvbnRhaW5lci5qc3g=) | `79.50% <ø> (+1.32%)` | :arrow_up: |
| [.../explore/components/controls/CollectionControl.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Db2xsZWN0aW9uQ29udHJvbC5qc3g=) | `45.45% <ø> (+3.78%)` | :arrow_up: |
| [.../controls/MetricControl/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIuanN4) | `77.09% <ø> (-2.01%)` | :arrow_down: |
| [...nents/controls/MetricControl/AdhocMetricOption.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
| [...ntrols/MetricControl/AdhocMetricPopoverTrigger.tsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljUG9wb3ZlclRyaWdnZXIudHN4) | `88.00% <ø> (-6.74%)` | :arrow_down: |
| [...mponents/controls/MetricControl/MetricsControl.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL01ldHJpY3NDb250cm9sLmpzeA==) | `57.05% <0.00%> (-33.06%)` | :arrow_down: |
| [...uperset-frontend/src/explore/controlUtils/index.js](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFV0aWxzL2luZGV4Lmpz) | `74.31% <ø> (ø)` | |
| [superset-frontend/src/explore/controls.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbHMuanN4) | `16.45% <0.00%> (-10.38%)` | :arrow_down: |
| [...et-frontend/src/explore/reducers/exploreReducer.js](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZXhwbG9yZVJlZHVjZXIuanM=) | `33.33% <0.00%> (-11.67%)` | :arrow_down: |
| ... and [771 more](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=footer). Last update [0b114fc...cb1dd58](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13221: refactor(explore): convert ControlPanelsContainer to typescript
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13221:
URL: https://github.com/apache/superset/pull/13221#issuecomment-784956394
# [Codecov](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=h1) Report
> Merging [#13221](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=desc) (cb1dd58) into [master](https://codecov.io/gh/apache/superset/commit/0b114fcbc58751c84b5e0c1f1a1024e6adf1bed7?el=desc) (0b114fc) will **decrease** coverage by `14.79%`.
> The diff coverage is `57.69%`.
[](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13221 +/- ##
===========================================
- Coverage 77.21% 62.42% -14.80%
===========================================
Files 872 573 -299
Lines 45140 20690 -24450
Branches 5435 5433 -2
===========================================
- Hits 34854 12915 -21939
+ Misses 10163 7565 -2598
- Partials 123 210 +87
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `62.42% <57.69%> (+0.08%)` | :arrow_up: |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/constants.ts](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbnN0YW50cy50cw==) | `100.00% <ø> (ø)` | |
| [...nd/src/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlVmlld0NvbnRhaW5lci5qc3g=) | `2.43% <ø> (-75.75%)` | :arrow_down: |
| [.../explore/components/controls/CollectionControl.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Db2xsZWN0aW9uQ29udHJvbC5qc3g=) | `21.21% <ø> (-20.46%)` | :arrow_down: |
| [.../controls/MetricControl/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIuanN4) | `57.57% <ø> (-21.53%)` | :arrow_down: |
| [...nents/controls/MetricControl/AdhocMetricOption.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljT3B0aW9uLmpzeA==) | `72.72% <ø> (-27.28%)` | :arrow_down: |
| [...ntrols/MetricControl/AdhocMetricPopoverTrigger.tsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljUG9wb3ZlclRyaWdnZXIudHN4) | `68.42% <ø> (-26.32%)` | :arrow_down: |
| [...uperset-frontend/src/explore/controlUtils/index.js](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFV0aWxzL2luZGV4Lmpz) | `92.66% <ø> (ø)` | |
| [superset-frontend/src/explore/controls.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbHMuanN4) | `27.16% <0.00%> (+0.33%)` | :arrow_up: |
| [...et-frontend/src/explore/reducers/exploreReducer.js](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZXhwbG9yZVJlZHVjZXIuanM=) | `28.98% <0.00%> (-16.02%)` | :arrow_down: |
| [...s/controls/DateFilterControl/DateFilterControl.tsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC9EYXRlRmlsdGVyQ29udHJvbC50c3g=) | `19.29% <16.66%> (-64.74%)` | :arrow_down: |
| ... and [524 more](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=footer). Last update [0b114fc...cb1dd58](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on a change in pull request #13221: refactor(explore): convert ControlPanelsContainer to typescript
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #13221:
URL: https://github.com/apache/superset/pull/13221#discussion_r578695232
##########
File path: superset-frontend/src/explore/components/ControlPanelsContainer.tsx
##########
@@ -161,29 +178,39 @@ class ControlPanelsContainer extends React.Component {
validationErrors={validationErrors}
actions={actions}
formData={provideFormDataToProps ? formData : null}
- datasource={formData?.datasource}
Review comment:
Remove this exposed `datasource` prop from #12609 since it's already available in `formData`, plus The typing would not conform with `datasource` for `DatasourceControl`, which uses the assigns `datasource` prop with the whole metadata of a datasource in `mapStateToProps`.
cc @pkdotson @zhaoyongjie
##########
File path: superset-frontend/src/explore/controls.jsx
##########
@@ -355,8 +355,9 @@ export const controls = {
"using the engine's local timezone. Note one can explicitly set the timezone " +
'per the ISO 8601 format if specifying either the start and/or end time.',
),
- mapStateToProps: state => ({
- endpoints: state.form_data ? state.form_data.time_range_endpoints : null,
+ provideFormDataToProps: true,
Review comment:
Need to add this in `superset-ui/chart-controls`, too.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13221: refactor(explore): convert ControlPanelsContainer to typescript
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13221:
URL: https://github.com/apache/superset/pull/13221#issuecomment-784956394
# [Codecov](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=h1) Report
> Merging [#13221](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=desc) (a3e6aab) into [master](https://codecov.io/gh/apache/superset/commit/b4ca39ceeba557d4a8dfaa219e62389716cf76e8?el=desc) (b4ca39c) will **decrease** coverage by `4.15%`.
> The diff coverage is `84.76%`.
[](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13221 +/- ##
==========================================
- Coverage 77.12% 72.96% -4.16%
==========================================
Files 894 582 -312
Lines 45672 21080 -24592
Branches 5492 5445 -47
==========================================
- Hits 35223 15382 -19841
+ Misses 10325 5572 -4753
- Partials 124 126 +2
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `58.06% <81.11%> (-0.03%)` | :arrow_down: |
| hive | `?` | |
| javascript | `62.64% <58.09%> (+0.24%)` | :arrow_up: |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `?` | |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/constants.ts](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbnN0YW50cy50cw==) | `100.00% <ø> (ø)` | |
| [...nd/src/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlVmlld0NvbnRhaW5lci5qc3g=) | `78.04% <ø> (-0.14%)` | :arrow_down: |
| [.../explore/components/controls/CollectionControl.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Db2xsZWN0aW9uQ29udHJvbC5qc3g=) | `45.45% <ø> (+3.78%)` | :arrow_up: |
| [.../controls/MetricControl/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIuanN4) | `79.54% <ø> (+0.44%)` | :arrow_up: |
| [...nents/controls/MetricControl/AdhocMetricOption.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
| [...ntrols/MetricControl/AdhocMetricPopoverTrigger.tsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljUG9wb3ZlclRyaWdnZXIudHN4) | `94.73% <ø> (ø)` | |
| [...uperset-frontend/src/explore/controlUtils/index.js](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFV0aWxzL2luZGV4Lmpz) | `95.41% <ø> (ø)` | |
| [superset-frontend/src/explore/controls.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbHMuanN4) | `27.16% <0.00%> (+0.33%)` | :arrow_up: |
| [...et-frontend/src/explore/reducers/exploreReducer.js](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZXhwbG9yZVJlZHVjZXIuanM=) | `36.23% <0.00%> (-8.77%)` | :arrow_down: |
| [...ents/controls/FilterControl/AdhocFilterControl.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyQ29udHJvbC5qc3g=) | `60.00% <50.00%> (+0.90%)` | :arrow_up: |
| ... and [340 more](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=footer). Last update [b4ca39c...430874c](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13221: refactor(explore): convert ControlPanelsContainer to typescript
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13221:
URL: https://github.com/apache/superset/pull/13221#issuecomment-784956394
# [Codecov](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=h1) Report
> Merging [#13221](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=desc) (a700205) into [master](https://codecov.io/gh/apache/superset/commit/d39bc14a0b7808ce7cef20a0565c8d3fd9388ae9?el=desc) (d39bc14) will **increase** coverage by `0.47%`.
> The diff coverage is `84.61%`.
[](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13221 +/- ##
==========================================
+ Coverage 72.26% 72.73% +0.47%
==========================================
Files 876 577 -299
Lines 45409 21019 -24390
Branches 5440 5438 -2
==========================================
- Hits 32815 15289 -17526
+ Misses 12384 5605 -6779
+ Partials 210 125 -85
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `58.14% <80.89%> (?)` | |
| hive | `?` | |
| javascript | `62.35% <57.69%> (+0.08%)` | :arrow_up: |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `?` | |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/constants.ts](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbnN0YW50cy50cw==) | `100.00% <ø> (ø)` | |
| [...nd/src/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlVmlld0NvbnRhaW5lci5qc3g=) | `78.04% <ø> (+75.62%)` | :arrow_up: |
| [.../explore/components/controls/CollectionControl.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Db2xsZWN0aW9uQ29udHJvbC5qc3g=) | `45.45% <ø> (+26.01%)` | :arrow_up: |
| [.../controls/MetricControl/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIuanN4) | `79.54% <ø> (+22.08%)` | :arrow_up: |
| [...nents/controls/MetricControl/AdhocMetricOption.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljT3B0aW9uLmpzeA==) | `100.00% <ø> (+27.27%)` | :arrow_up: |
| [...ntrols/MetricControl/AdhocMetricPopoverTrigger.tsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljUG9wb3ZlclRyaWdnZXIudHN4) | `94.73% <ø> (+26.31%)` | :arrow_up: |
| [...uperset-frontend/src/explore/controlUtils/index.js](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFV0aWxzL2luZGV4Lmpz) | `95.41% <ø> (ø)` | |
| [superset-frontend/src/explore/controls.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbHMuanN4) | `27.16% <0.00%> (+0.33%)` | :arrow_up: |
| [...et-frontend/src/explore/reducers/exploreReducer.js](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZXhwbG9yZVJlZHVjZXIuanM=) | `36.23% <0.00%> (+2.89%)` | :arrow_up: |
| [...ents/controls/FilterControl/AdhocFilterControl.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyQ29udHJvbC5qc3g=) | `60.00% <50.00%> (+0.90%)` | :arrow_up: |
| ... and [523 more](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=footer). Last update [7766857...0e12f5b](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13221: refactor(explore): convert ControlPanelsContainer to typescript
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13221:
URL: https://github.com/apache/superset/pull/13221#issuecomment-784956394
# [Codecov](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=h1) Report
> Merging [#13221](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=desc) (c7bd049) into [master](https://codecov.io/gh/apache/superset/commit/0a00153375fb69891c2a9f0115a33cdf5551b2d6?el=desc) (0a00153) will **decrease** coverage by `24.50%`.
> The diff coverage is `72.50%`.
[](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13221 +/- ##
===========================================
- Coverage 77.19% 52.69% -24.51%
===========================================
Files 872 480 -392
Lines 45101 15873 -29228
Branches 5435 4095 -1340
===========================================
- Hits 34817 8364 -26453
+ Misses 10161 7509 -2652
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `52.69% <72.50%> (-5.84%)` | :arrow_down: |
| javascript | `?` | |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/constants.ts](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbnN0YW50cy50cw==) | `100.00% <ø> (ø)` | |
| [...nd/src/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlVmlld0NvbnRhaW5lci5qc3g=) | `79.50% <ø> (+1.32%)` | :arrow_up: |
| [.../explore/components/controls/CollectionControl.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Db2xsZWN0aW9uQ29udHJvbC5qc3g=) | `21.21% <ø> (-20.46%)` | :arrow_down: |
| [.../controls/MetricControl/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIuanN4) | `77.09% <ø> (-2.01%)` | :arrow_down: |
| [...nents/controls/MetricControl/AdhocMetricOption.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
| [...ntrols/MetricControl/AdhocMetricPopoverTrigger.tsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljUG9wb3ZlclRyaWdnZXIudHN4) | `88.00% <ø> (-6.74%)` | :arrow_down: |
| [...s/controls/MetricControl/MetricDefinitionValue.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL01ldHJpY0RlZmluaXRpb25WYWx1ZS5qc3g=) | `88.23% <ø> (-5.89%)` | :arrow_down: |
| [...uperset-frontend/src/explore/controlUtils/index.js](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFV0aWxzL2luZGV4Lmpz) | `71.55% <ø> (ø)` | |
| [superset-frontend/src/explore/controls.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbHMuanN4) | `16.45% <0.00%> (-10.38%)` | :arrow_down: |
| [...et-frontend/src/explore/reducers/exploreReducer.js](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZXhwbG9yZVJlZHVjZXIuanM=) | `37.09% <0.00%> (-7.91%)` | :arrow_down: |
| ... and [774 more](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=footer). Last update [0a00153...c7bd049](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on a change in pull request #13221: refactor(explore): convert ControlPanelsContainer to typescript
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #13221:
URL: https://github.com/apache/superset/pull/13221#discussion_r578685551
##########
File path: superset-frontend/src/visualizations/FilterBox/FilterBox.jsx
##########
@@ -298,7 +298,6 @@ class FilterBox extends React.PureComponent {
datasourceFilters.push(
<ControlRow
key="sqla-filters"
- className="control-row"
Review comment:
This prop is not used in the `ControlRow` component.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on pull request #13221: refactor(explore): convert ControlPanelsContainer to typescript
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #13221:
URL: https://github.com/apache/superset/pull/13221#issuecomment-788232044
@michael-s-molina Did you run `npm install` or was your `superset-ui/chart-controls` linked to a different version? CI didn't catch it because it was actually working?
I'm pretty sure this was updated here: https://github.com/apache-superset/superset-ui/pull/962/files#diff-efc1b32a915b3738e7689b97eab6576ac7b206bc95d46e1ecaac6c8646287a65R27
The `superset-ui` change was supposed to be added in this PR but [another PR](#13210 ) has upgraded them anyway.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13221: refactor(explore): convert ControlPanelsContainer to typescript
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13221:
URL: https://github.com/apache/superset/pull/13221#issuecomment-784956394
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13221: refactor(explore): convert ControlPanelsContainer to typescript
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13221:
URL: https://github.com/apache/superset/pull/13221#issuecomment-784956394
# [Codecov](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=h1) Report
> Merging [#13221](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=desc) (a700205) into [master](https://codecov.io/gh/apache/superset/commit/0b114fcbc58751c84b5e0c1f1a1024e6adf1bed7?el=desc) (0b114fc) will **decrease** coverage by `6.82%`.
> The diff coverage is `62.67%`.
[](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13221 +/- ##
==========================================
- Coverage 77.21% 70.38% -6.83%
==========================================
Files 872 577 -295
Lines 45140 21019 -24121
Branches 5435 5438 +3
==========================================
- Hits 34854 14794 -20060
+ Misses 10163 6083 -4080
- Partials 123 142 +19
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `52.90% <38.11%> (-5.63%)` | :arrow_down: |
| javascript | `62.35% <57.98%> (+0.01%)` | :arrow_up: |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...et-frontend/src/components/Icons/icons.stories.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbnMvaWNvbnMuc3Rvcmllcy5qc3g=) | `0.00% <0.00%> (ø)` | |
| [...c/components/ListViewCard/ListViewCard.stories.tsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXdDYXJkL0xpc3RWaWV3Q2FyZC5zdG9yaWVzLnRzeA==) | `0.00% <0.00%> (ø)` | |
| [...set-frontend/src/components/ListViewCard/index.tsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXdDYXJkL2luZGV4LnRzeA==) | `100.00% <ø> (+5.45%)` | :arrow_up: |
| [superset-frontend/src/constants.ts](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbnN0YW50cy50cw==) | `100.00% <ø> (ø)` | |
| [...nd/src/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlVmlld0NvbnRhaW5lci5qc3g=) | `76.21% <ø> (-1.97%)` | :arrow_down: |
| [.../explore/components/controls/CollectionControl.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Db2xsZWN0aW9uQ29udHJvbC5qc3g=) | `21.21% <ø> (-20.46%)` | :arrow_down: |
| [.../controls/MetricControl/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIuanN4) | `79.54% <ø> (+0.44%)` | :arrow_up: |
| [...nents/controls/MetricControl/AdhocMetricOption.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
| [...ntrols/MetricControl/AdhocMetricPopoverTrigger.tsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljUG9wb3ZlclRyaWdnZXIudHN4) | `92.98% <ø> (-1.76%)` | :arrow_down: |
| [...uperset-frontend/src/explore/controlUtils/index.js](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFV0aWxzL2luZGV4Lmpz) | `95.41% <ø> (ø)` | |
| ... and [386 more](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=footer). Last update [0b114fc...cb1dd58](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on a change in pull request #13221: refactor(explore): convert ControlPanelsContainer to typescript
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #13221:
URL: https://github.com/apache/superset/pull/13221#discussion_r581534905
##########
File path: superset-frontend/.eslintrc.js
##########
@@ -226,6 +227,7 @@ module.exports = {
'no-mixed-operators': 0,
'no-multi-assign': 0,
'no-multi-spaces': 0,
+ 'no-nested-ternary': 0,
Review comment:
Disabling as we have seen fairly often nested-ternary in TypeScript `extends`. It should not be that hard to understand the code with `prettier`'s help.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on pull request #13221: refactor(explore): convert ControlPanelsContainer to typescript
Posted by GitBox <gi...@apache.org>.
ktmud commented on pull request #13221:
URL: https://github.com/apache/superset/pull/13221#issuecomment-782469807
Moved debounce delay updates to another PR: https://github.com/apache/superset/pull/13250
Will rebase once merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13221: refactor(explore): convert ControlPanelsContainer to typescript
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13221:
URL: https://github.com/apache/superset/pull/13221#issuecomment-784956394
# [Codecov](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=h1) Report
> Merging [#13221](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=desc) (a3e6aab) into [master](https://codecov.io/gh/apache/superset/commit/776685736c7c92942ca551b6d10fdac68a977c2c?el=desc) (7766857) will **increase** coverage by `0.93%`.
> The diff coverage is `82.19%`.
[](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13221 +/- ##
==========================================
+ Coverage 72.03% 72.96% +0.93%
==========================================
Files 876 582 -294
Lines 45409 21080 -24329
Branches 5440 5445 +5
==========================================
- Hits 32712 15382 -17330
+ Misses 12487 5572 -6915
+ Partials 210 126 -84
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `58.06% <61.76%> (?)` | |
| javascript | `62.64% <69.40%> (+0.37%)` | :arrow_up: |
| mysql | `?` | |
| postgres | `?` | |
| python | `?` | |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/chart/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L0NoYXJ0LmpzeA==) | `64.15% <0.00%> (+20.29%)` | :arrow_up: |
| [...rset-frontend/src/components/AsyncSelect/index.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQXN5bmNTZWxlY3QvaW5kZXguanN4) | `96.29% <ø> (ø)` | |
| [...rset-frontend/src/components/DeleteModal/index.tsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRGVsZXRlTW9kYWwvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/components/Label/index.tsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGFiZWwvaW5kZXgudHN4) | `100.00% <ø> (ø)` | |
| [...et-frontend/src/components/Menu/LanguagePicker.tsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9MYW5ndWFnZVBpY2tlci50c3g=) | `64.28% <ø> (ø)` | |
| [superset-frontend/src/components/Menu/SubMenu.tsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTWVudS9TdWJNZW51LnRzeA==) | `100.00% <ø> (ø)` | |
| [...ontend/src/components/URLShortLinkButton/index.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVVJMU2hvcnRMaW5rQnV0dG9uL2luZGV4LmpzeA==) | `100.00% <ø> (ø)` | |
| [superset-frontend/src/constants.ts](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbnN0YW50cy50cw==) | `100.00% <ø> (ø)` | |
| [.../src/dashboard/components/gridComponents/Chart.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0NoYXJ0LmpzeA==) | `86.59% <ø> (+16.49%)` | :arrow_up: |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `82.60% <ø> (+66.66%)` | :arrow_up: |
| ... and [553 more](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=footer). Last update [7766857...caf3b60](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #13221: refactor(explore): convert ControlPanelsContainer to typescript
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #13221:
URL: https://github.com/apache/superset/pull/13221#issuecomment-781631291
yeah, you are getting ready to work on dynamic controls thanks! ♥️
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13221: refactor(explore): convert ControlPanelsContainer to typescript
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13221:
URL: https://github.com/apache/superset/pull/13221#issuecomment-784956394
# [Codecov](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=h1) Report
> Merging [#13221](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=desc) (0af0aab) into [master](https://codecov.io/gh/apache/superset/commit/b4ca39ceeba557d4a8dfaa219e62389716cf76e8?el=desc) (b4ca39c) will **decrease** coverage by `4.39%`.
> The diff coverage is `84.76%`.
[](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13221 +/- ##
==========================================
- Coverage 77.12% 72.73% -4.40%
==========================================
Files 894 595 -299
Lines 45672 21247 -24425
Branches 5492 5490 -2
==========================================
- Hits 35223 15453 -19770
+ Misses 10325 5668 -4657
- Partials 124 126 +2
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.69% <81.11%> (-0.40%)` | :arrow_down: |
| hive | `?` | |
| javascript | `62.48% <58.09%> (+0.08%)` | :arrow_up: |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `?` | |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/constants.ts](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbnN0YW50cy50cw==) | `100.00% <ø> (ø)` | |
| [...nd/src/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlVmlld0NvbnRhaW5lci5qc3g=) | `78.04% <ø> (-0.14%)` | :arrow_down: |
| [.../explore/components/controls/CollectionControl.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Db2xsZWN0aW9uQ29udHJvbC5qc3g=) | `45.45% <ø> (+3.78%)` | :arrow_up: |
| [.../controls/MetricControl/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIuanN4) | `79.54% <ø> (+0.44%)` | :arrow_up: |
| [...nents/controls/MetricControl/AdhocMetricOption.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
| [...ntrols/MetricControl/AdhocMetricPopoverTrigger.tsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljUG9wb3ZlclRyaWdnZXIudHN4) | `94.73% <ø> (ø)` | |
| [...uperset-frontend/src/explore/controlUtils/index.js](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFV0aWxzL2luZGV4Lmpz) | `95.41% <ø> (ø)` | |
| [superset-frontend/src/explore/controls.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbHMuanN4) | `27.16% <0.00%> (+0.33%)` | :arrow_up: |
| [...et-frontend/src/explore/reducers/exploreReducer.js](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZXhwbG9yZVJlZHVjZXIuanM=) | `36.23% <0.00%> (-8.77%)` | :arrow_down: |
| [...ents/controls/FilterControl/AdhocFilterControl.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyQ29udHJvbC5qc3g=) | `60.00% <50.00%> (+0.90%)` | :arrow_up: |
| ... and [318 more](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=footer). Last update [b4ca39c...430874c](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on a change in pull request #13221: refactor(explore): convert ControlPanelsContainer to typescript
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #13221:
URL: https://github.com/apache/superset/pull/13221#discussion_r579570296
##########
File path: superset-frontend/src/explore/components/controls/DateFilterControl/DateFilterControl.tsx
##########
@@ -165,28 +166,26 @@ const IconWrapper = styled.span`
}
`;
-interface DateFilterLabelProps {
+interface DateFilterControlProps {
name: string;
onChange: (timeRange: string) => void;
value?: string;
endpoints?: TimeRangeEndpoints;
- datasource?: string;
+ datasource?: DatasourceMeta;
Review comment:
Will update the shared control to pass in `datasource` object instead of datasource string from form_data.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13221: refactor(explore): convert ControlPanelsContainer to typescript
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13221:
URL: https://github.com/apache/superset/pull/13221#issuecomment-784956394
# [Codecov](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=h1) Report
> Merging [#13221](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=desc) (eaa5c6d) into [master](https://codecov.io/gh/apache/superset/commit/776685736c7c92942ca551b6d10fdac68a977c2c?el=desc) (7766857) will **increase** coverage by `0.70%`.
> The diff coverage is `84.61%`.
[](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13221 +/- ##
==========================================
+ Coverage 72.03% 72.74% +0.70%
==========================================
Files 876 579 -297
Lines 45409 21046 -24363
Branches 5440 5439 -1
==========================================
- Hits 32712 15310 -17402
+ Misses 12487 5611 -6876
+ Partials 210 125 -85
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `58.14% <80.89%> (?)` | |
| javascript | `62.35% <57.69%> (+0.08%)` | :arrow_up: |
| mysql | `?` | |
| postgres | `?` | |
| python | `?` | |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/constants.ts](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbnN0YW50cy50cw==) | `100.00% <ø> (ø)` | |
| [...nd/src/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlVmlld0NvbnRhaW5lci5qc3g=) | `78.04% <ø> (+75.62%)` | :arrow_up: |
| [.../explore/components/controls/CollectionControl.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Db2xsZWN0aW9uQ29udHJvbC5qc3g=) | `45.45% <ø> (+26.01%)` | :arrow_up: |
| [.../controls/MetricControl/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIuanN4) | `79.54% <ø> (+22.08%)` | :arrow_up: |
| [...nents/controls/MetricControl/AdhocMetricOption.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljT3B0aW9uLmpzeA==) | `100.00% <ø> (+27.27%)` | :arrow_up: |
| [...ntrols/MetricControl/AdhocMetricPopoverTrigger.tsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljUG9wb3ZlclRyaWdnZXIudHN4) | `94.73% <ø> (+26.31%)` | :arrow_up: |
| [...uperset-frontend/src/explore/controlUtils/index.js](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFV0aWxzL2luZGV4Lmpz) | `95.41% <ø> (ø)` | |
| [superset-frontend/src/explore/controls.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbHMuanN4) | `27.16% <0.00%> (+0.33%)` | :arrow_up: |
| [...et-frontend/src/explore/reducers/exploreReducer.js](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZXhwbG9yZVJlZHVjZXIuanM=) | `36.23% <0.00%> (+2.89%)` | :arrow_up: |
| [...ents/controls/FilterControl/AdhocFilterControl.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyQ29udHJvbC5qc3g=) | `60.00% <50.00%> (+0.90%)` | :arrow_up: |
| ... and [525 more](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=footer). Last update [7766857...0e12f5b](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io commented on pull request #13221: refactor(explore): convert ControlPanelsContainer to typescript
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #13221:
URL: https://github.com/apache/superset/pull/13221#issuecomment-784956394
# [Codecov](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=h1) Report
> Merging [#13221](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=desc) (c7bd049) into [master](https://codecov.io/gh/apache/superset/commit/0a00153375fb69891c2a9f0115a33cdf5551b2d6?el=desc) (0a00153) will **decrease** coverage by `24.90%`.
> The diff coverage is `72.50%`.
[](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13221 +/- ##
===========================================
- Coverage 77.19% 52.29% -24.91%
===========================================
Files 872 480 -392
Lines 45101 15873 -29228
Branches 5435 4095 -1340
===========================================
- Hits 34817 8300 -26517
+ Misses 10161 7573 -2588
+ Partials 123 0 -123
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `52.29% <72.50%> (-6.25%)` | :arrow_down: |
| javascript | `?` | |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/constants.ts](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbnN0YW50cy50cw==) | `100.00% <ø> (ø)` | |
| [...nd/src/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlVmlld0NvbnRhaW5lci5qc3g=) | `79.50% <ø> (+1.32%)` | :arrow_up: |
| [.../explore/components/controls/CollectionControl.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Db2xsZWN0aW9uQ29udHJvbC5qc3g=) | `21.21% <ø> (-20.46%)` | :arrow_down: |
| [.../controls/MetricControl/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIuanN4) | `77.09% <ø> (-2.01%)` | :arrow_down: |
| [...nents/controls/MetricControl/AdhocMetricOption.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
| [...ntrols/MetricControl/AdhocMetricPopoverTrigger.tsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljUG9wb3ZlclRyaWdnZXIudHN4) | `88.00% <ø> (-6.74%)` | :arrow_down: |
| [...s/controls/MetricControl/MetricDefinitionValue.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL01ldHJpY0RlZmluaXRpb25WYWx1ZS5qc3g=) | `88.23% <ø> (-5.89%)` | :arrow_down: |
| [...uperset-frontend/src/explore/controlUtils/index.js](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFV0aWxzL2luZGV4Lmpz) | `71.55% <ø> (ø)` | |
| [superset-frontend/src/explore/controls.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbHMuanN4) | `16.45% <0.00%> (-10.38%)` | :arrow_down: |
| [...et-frontend/src/explore/reducers/exploreReducer.js](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZXhwbG9yZVJlZHVjZXIuanM=) | `37.09% <0.00%> (-7.91%)` | :arrow_down: |
| ... and [774 more](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=footer). Last update [0a00153...c7bd049](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13221: refactor(explore): convert ControlPanelsContainer to typescript
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13221:
URL: https://github.com/apache/superset/pull/13221#issuecomment-784956394
# [Codecov](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=h1) Report
> Merging [#13221](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=desc) (a700205) into [master](https://codecov.io/gh/apache/superset/commit/0b114fcbc58751c84b5e0c1f1a1024e6adf1bed7?el=desc) (0b114fc) will **decrease** coverage by `4.47%`.
> The diff coverage is `64.55%`.
[](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13221 +/- ##
==========================================
- Coverage 77.21% 72.73% -4.48%
==========================================
Files 872 577 -295
Lines 45140 21019 -24121
Branches 5435 5438 +3
==========================================
- Hits 34854 15289 -19565
+ Misses 10163 5605 -4558
- Partials 123 125 +2
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `58.14% <41.39%> (-0.39%)` | :arrow_down: |
| javascript | `62.35% <57.98%> (+0.01%)` | :arrow_up: |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...et-frontend/src/components/Icons/icons.stories.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbnMvaWNvbnMuc3Rvcmllcy5qc3g=) | `0.00% <0.00%> (ø)` | |
| [...c/components/ListViewCard/ListViewCard.stories.tsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXdDYXJkL0xpc3RWaWV3Q2FyZC5zdG9yaWVzLnRzeA==) | `0.00% <0.00%> (ø)` | |
| [...set-frontend/src/components/ListViewCard/index.tsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXdDYXJkL2luZGV4LnRzeA==) | `100.00% <ø> (+5.45%)` | :arrow_up: |
| [superset-frontend/src/constants.ts](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbnN0YW50cy50cw==) | `100.00% <ø> (ø)` | |
| [...nd/src/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlVmlld0NvbnRhaW5lci5qc3g=) | `78.04% <ø> (-0.14%)` | :arrow_down: |
| [.../explore/components/controls/CollectionControl.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Db2xsZWN0aW9uQ29udHJvbC5qc3g=) | `45.45% <ø> (+3.78%)` | :arrow_up: |
| [.../controls/MetricControl/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIuanN4) | `79.54% <ø> (+0.44%)` | :arrow_up: |
| [...nents/controls/MetricControl/AdhocMetricOption.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
| [...ntrols/MetricControl/AdhocMetricPopoverTrigger.tsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljUG9wb3ZlclRyaWdnZXIudHN4) | `94.73% <ø> (ø)` | |
| [...uperset-frontend/src/explore/controlUtils/index.js](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFV0aWxzL2luZGV4Lmpz) | `95.41% <ø> (ø)` | |
| ... and [336 more](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=footer). Last update [0b114fc...cb1dd58](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud commented on a change in pull request #13221: refactor(explore): convert ControlPanelsContainer to typescript
Posted by GitBox <gi...@apache.org>.
ktmud commented on a change in pull request #13221:
URL: https://github.com/apache/superset/pull/13221#discussion_r583118929
##########
File path: superset-frontend/cypress-base/cypress/integration/explore/annotations.test.ts
##########
@@ -0,0 +1,59 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+describe('Annotations', () => {
+ beforeEach(() => {
+ cy.login();
+ cy.intercept('GET', '/superset/explore_json/**').as('getJson');
+ cy.intercept('POST', '/superset/explore_json/**').as('postJson');
+ });
+
+ it('Create formula annotation y-axis goal line', () => {
+ cy.visitChartByName('Num Births Trend');
+ cy.verifySliceSuccess({ waitAlias: '@postJson' });
+
+ const layerLabel = 'Goal line';
+
+ cy.get('[data-test=annotation_layers] button').click();
+
+ cy.get('[data-test="popover-content"]').within(() => {
+ cy.get('[data-test=annotation-layer-name-header]')
+ .siblings()
+ .first()
+ .within(() => {
+ cy.get('input').type(layerLabel);
+ });
+ cy.get('[data-test=annotation-layer-value-header]')
+ .siblings()
+ .first()
+ .within(() => {
+ cy.get('input').type('y=1400000');
+ });
+ cy.get('button').contains('OK').click();
Review comment:
Moved this test to a separate file. Removed `{ force: true }` to fix the flaky test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] ktmud closed pull request #13221: refactor(explore): convert ControlPanelsContainer to typescript
Posted by GitBox <gi...@apache.org>.
ktmud closed pull request #13221:
URL: https://github.com/apache/superset/pull/13221
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13221: refactor(explore): convert ControlPanelsContainer to typescript
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13221:
URL: https://github.com/apache/superset/pull/13221#issuecomment-784956394
# [Codecov](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=h1) Report
> Merging [#13221](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=desc) (a700205) into [master](https://codecov.io/gh/apache/superset/commit/0b114fcbc58751c84b5e0c1f1a1024e6adf1bed7?el=desc) (0b114fc) will **decrease** coverage by `4.67%`.
> The diff coverage is `64.55%`.
[](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13221 +/- ##
==========================================
- Coverage 77.21% 72.53% -4.68%
==========================================
Files 872 577 -295
Lines 45140 21019 -24121
Branches 5435 5438 +3
==========================================
- Hits 34854 15246 -19608
+ Misses 10163 5644 -4519
- Partials 123 129 +6
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.75% <41.39%> (-0.79%)` | :arrow_down: |
| javascript | `62.35% <57.98%> (+0.01%)` | :arrow_up: |
| python | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...et-frontend/src/components/Icons/icons.stories.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbnMvaWNvbnMuc3Rvcmllcy5qc3g=) | `0.00% <0.00%> (ø)` | |
| [...c/components/ListViewCard/ListViewCard.stories.tsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXdDYXJkL0xpc3RWaWV3Q2FyZC5zdG9yaWVzLnRzeA==) | `0.00% <0.00%> (ø)` | |
| [...set-frontend/src/components/ListViewCard/index.tsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvTGlzdFZpZXdDYXJkL2luZGV4LnRzeA==) | `100.00% <ø> (+5.45%)` | :arrow_up: |
| [superset-frontend/src/constants.ts](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbnN0YW50cy50cw==) | `100.00% <ø> (ø)` | |
| [...nd/src/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlVmlld0NvbnRhaW5lci5qc3g=) | `78.04% <ø> (-0.14%)` | :arrow_down: |
| [.../explore/components/controls/CollectionControl.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Db2xsZWN0aW9uQ29udHJvbC5qc3g=) | `45.45% <ø> (+3.78%)` | :arrow_up: |
| [.../controls/MetricControl/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIuanN4) | `79.54% <ø> (+0.44%)` | :arrow_up: |
| [...nents/controls/MetricControl/AdhocMetricOption.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljT3B0aW9uLmpzeA==) | `100.00% <ø> (ø)` | |
| [...ntrols/MetricControl/AdhocMetricPopoverTrigger.tsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljUG9wb3ZlclRyaWdnZXIudHN4) | `94.73% <ø> (ø)` | |
| [...uperset-frontend/src/explore/controlUtils/index.js](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFV0aWxzL2luZGV4Lmpz) | `95.41% <ø> (ø)` | |
| ... and [341 more](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=footer). Last update [0b114fc...cb1dd58](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #13221: refactor(explore): convert ControlPanelsContainer to typescript
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #13221:
URL: https://github.com/apache/superset/pull/13221#issuecomment-784956394
# [Codecov](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=h1) Report
> Merging [#13221](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=desc) (eaa5c6d) into [master](https://codecov.io/gh/apache/superset/commit/776685736c7c92942ca551b6d10fdac68a977c2c?el=desc) (7766857) will **increase** coverage by `0.70%`.
> The diff coverage is `84.61%`.
[](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13221 +/- ##
==========================================
+ Coverage 72.03% 72.74% +0.70%
==========================================
Files 876 579 -297
Lines 45409 21046 -24363
Branches 5440 5439 -1
==========================================
- Hits 32712 15310 -17402
+ Misses 12487 5611 -6876
+ Partials 210 125 -85
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `58.14% <80.89%> (?)` | |
| javascript | `62.35% <57.69%> (+0.08%)` | :arrow_up: |
| mysql | `?` | |
| postgres | `?` | |
| python | `?` | |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/constants.ts](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbnN0YW50cy50cw==) | `100.00% <ø> (ø)` | |
| [...nd/src/explore/components/ExploreViewContainer.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlVmlld0NvbnRhaW5lci5qc3g=) | `78.04% <ø> (+75.62%)` | :arrow_up: |
| [.../explore/components/controls/CollectionControl.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Db2xsZWN0aW9uQ29udHJvbC5qc3g=) | `45.45% <ø> (+26.01%)` | :arrow_up: |
| [.../controls/MetricControl/AdhocMetricEditPopover.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljRWRpdFBvcG92ZXIuanN4) | `79.54% <ø> (+22.08%)` | :arrow_up: |
| [...nents/controls/MetricControl/AdhocMetricOption.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljT3B0aW9uLmpzeA==) | `100.00% <ø> (+27.27%)` | :arrow_up: |
| [...ntrols/MetricControl/AdhocMetricPopoverTrigger.tsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljUG9wb3ZlclRyaWdnZXIudHN4) | `94.73% <ø> (+26.31%)` | :arrow_up: |
| [...uperset-frontend/src/explore/controlUtils/index.js](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFV0aWxzL2luZGV4Lmpz) | `95.41% <ø> (ø)` | |
| [superset-frontend/src/explore/controls.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbHMuanN4) | `27.16% <0.00%> (+0.33%)` | :arrow_up: |
| [...et-frontend/src/explore/reducers/exploreReducer.js](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvcmVkdWNlcnMvZXhwbG9yZVJlZHVjZXIuanM=) | `36.23% <0.00%> (+2.89%)` | :arrow_up: |
| [...ents/controls/FilterControl/AdhocFilterControl.jsx](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJDb250cm9sL0FkaG9jRmlsdGVyQ29udHJvbC5qc3g=) | `60.00% <50.00%> (+0.90%)` | :arrow_up: |
| ... and [525 more](https://codecov.io/gh/apache/superset/pull/13221/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=footer). Last update [7766857...caf3b60](https://codecov.io/gh/apache/superset/pull/13221?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org