[jira] [Commented] (OFBIZ-4813) ajax autocomplete and dialog during session timeout

["Jacques Le Roux (Commented) (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/OFBIZ-4813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13255311#comment-13255311 ] 

Jacques Le Roux commented on OFBIZ-4813:
----------------------------------------

Wai,

About the point 4: I purposely decided to put the layered Ajax box at top left because it allows an easier "maximisation". When centered, if you want to increase the surface you have 1st to move it to top left, then increase. When in top left one dragging gesture et voilà.

I don't know what others think about that
{code}
     <property key="CommonSessionTimeoutPleaseLogIn">
-        <value xml:lang="de">Sie sind nicht mehr angemeldet. Bitte melden Sie sich erneut an.</value>
-        <value xml:lang="en">You are not logged in. Please login again.</value>
-        <value xml:lang="es">No está conectado. Por favor, vuelva a conectarse.</value>
-        <value xml:lang="vi">Bạn chưa đăng nhập. Vui lòng đăng nhập lại.</value>
+        <value xml:lang="en">Your session has expired.  A login is required.  You can refresh the page or save your data to login.</value>
{code}

Why did you replace this (I don't say it's wrong, just to understand what was wrong)
{code}
-    }    
-    requestUrl = getViewNameWithSeparator(requestUrl) + "presentation=" + presentation;
+    }
{code}

{code}
+            var queryArgs = "presentation=" + presentation;
             if (typeof args == "object" && jQuery.isArray(args)) {
                 for (var i = 0; i < args.length; i++) {
-                    requestUrlAndArgs += "&parm" + i + "=" + jQuery(args[i]).val();
+                    queryArgs += "&parm" + i + "=" + jQuery(args[i]).val();
{code}

If you introduce a timeout, it should be configurable (property)
{code}
+            jQuery.ajax({
+                type: "post",
+                url: requestUrl,
+                data: queryArgs,
+                timeout: 5000,
{code}

Thanks
                
> ajax autocomplete and dialog during session timeout
> ---------------------------------------------------
>
>                 Key: OFBIZ-4813
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-4813
>             Project: OFBiz
>          Issue Type: Bug
>          Components: framework
>            Reporter: Wai
>         Attachments: ofbiz-4813.patch, spinner.gif
>
>
> 1. autocomplete feature shows the message "no records found" during a session timeout.  This could be misleading for the user.
> 2. During a session timeout, clicking on ajax dialog button shows a large frame containing a message indicating session has timeout.  Should show a more detailed message.
> 3. All ajax dialogs are on the left of browser window.
> A number of fixes have been implemented for this issue.
> 1. At session timeout, user enters a character into autocomplete input box results in a alert window popup.
> 2. At session timeout, clicking on ajax dialog button will cause alert window to popup.
> 3. A large round spinner is shown when the ajax dialog is loading.  This spinner image comes from http://mentalized.net/activity-indicators/ and is royalty free.  Note the round spinner does not show in Tomahawk theme as it uses its own spinner.
> 4. Now all ajax dialogs are centered.
> 5. Change session timeout message to something more detailed.
> 6. Server response to ajax request now contain html tags.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira