You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Daniel Shahaf <d....@daniel.shahaf.name> on 2010/12/18 20:36:30 UTC
Re: svn commit: r1049414 -
/subversion/trunk/subversion/tests/svn_test_main.c
hwright@apache.org wrote on Wed, Dec 15, 2010 at 04:21:23 -0000:
> Author: hwright
> Date: Wed Dec 15 04:21:23 2010
> New Revision: 1049414
>
> URL: http://svn.apache.org/viewvc?rev=1049414&view=rev
> Log:
> Allow tests which cause segfaults to not disrupt the other tests in the C
> testsuite. This becomes useful when committing an XFailing test of a
> segfault (which I will shortly do), or when a test starts segfaulting of
> it's own accord.
>
> This behavior is enabled by default, but can be disabled by passing
> --allow-segfaults to the test, which should make for better debugging
> of the cause of the segfault.
...
> - err = (*desc->func_opts)(opts, pool);
> + err = svn_error_create(SVN_ERR_TEST_FAILED, NULL,
> + "Test crashed (unknown reason)");
Perhaps the error message could suggest to pass --allow-segfaults?
Re: svn commit: r1049414 - /subversion/trunk/subversion/tests/svn_test_main.c
Posted by "Hyrum K. Wright" <hy...@mail.utexas.edu>.
On Sat, Dec 18, 2010 at 2:36 PM, Daniel Shahaf <d....@daniel.shahaf.name> wrote:
> hwright@apache.org wrote on Wed, Dec 15, 2010 at 04:21:23 -0000:
>> Author: hwright
>> Date: Wed Dec 15 04:21:23 2010
>> New Revision: 1049414
>>
>> URL: http://svn.apache.org/viewvc?rev=1049414&view=rev
>> Log:
>> Allow tests which cause segfaults to not disrupt the other tests in the C
>> testsuite. This becomes useful when committing an XFailing test of a
>> segfault (which I will shortly do), or when a test starts segfaulting of
>> it's own accord.
>>
>> This behavior is enabled by default, but can be disabled by passing
>> --allow-segfaults to the test, which should make for better debugging
>> of the cause of the segfault.
> ...
>> - err = (*desc->func_opts)(opts, pool);
>> + err = svn_error_create(SVN_ERR_TEST_FAILED, NULL,
>> + "Test crashed (unknown reason)");
>
> Perhaps the error message could suggest to pass --allow-segfaults?
r1050719. Thanks.
-Hyrum
Re: svn commit: r1049414 - /subversion/trunk/subversion/tests/svn_test_main.c
Posted by "Hyrum K. Wright" <hy...@mail.utexas.edu>.
On Sat, Dec 18, 2010 at 2:36 PM, Daniel Shahaf <d....@daniel.shahaf.name> wrote:
> hwright@apache.org wrote on Wed, Dec 15, 2010 at 04:21:23 -0000:
>> Author: hwright
>> Date: Wed Dec 15 04:21:23 2010
>> New Revision: 1049414
>>
>> URL: http://svn.apache.org/viewvc?rev=1049414&view=rev
>> Log:
>> Allow tests which cause segfaults to not disrupt the other tests in the C
>> testsuite. This becomes useful when committing an XFailing test of a
>> segfault (which I will shortly do), or when a test starts segfaulting of
>> it's own accord.
>>
>> This behavior is enabled by default, but can be disabled by passing
>> --allow-segfaults to the test, which should make for better debugging
>> of the cause of the segfault.
> ...
>> - err = (*desc->func_opts)(opts, pool);
>> + err = svn_error_create(SVN_ERR_TEST_FAILED, NULL,
>> + "Test crashed (unknown reason)");
>
> Perhaps the error message could suggest to pass --allow-segfaults?
r1050719. Thanks.
-Hyrum