You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "David Reiss (JIRA)" <ji...@apache.org> on 2009/01/29 04:43:00 UTC
[jira] Created: (THRIFT-289) "make check" no longer runs the Java
tests
"make check" no longer runs the Java tests
------------------------------------------
Key: THRIFT-289
URL: https://issues.apache.org/jira/browse/THRIFT-289
Project: Thrift
Issue Type: Bug
Components: Library (Java), Test Suite
Reporter: David Reiss
Assignee: Bryan Duxbury
Broken by r738695.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-289) "make check" no longer runs the Java
tests
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12668578#action_12668578 ]
David Reiss commented on THRIFT-289:
------------------------------------
Try running make check at the top level. Most of the cpp tests are just under test.
> "make check" no longer runs the Java tests
> ------------------------------------------
>
> Key: THRIFT-289
> URL: https://issues.apache.org/jira/browse/THRIFT-289
> Project: Thrift
> Issue Type: Bug
> Components: Library (Java), Test Suite
> Reporter: David Reiss
> Assignee: Bryan Duxbury
> Attachments: 0001-THRIFT-289.-cpp-Fix-make-check-by-defining-a-comp.patch, 0002-THRIFT-289.-java-Make-make-check-run-the-Java-tes.patch
>
>
> Broken by r738695.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-289) "make check" no longer runs the Java
tests
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12668605#action_12668605 ]
David Reiss commented on THRIFT-289:
------------------------------------
Run ./configure --without-py . The python tests are a bit racy. There are a few fixes tacked on to various issues that mitigate the races. I'll try to get a sign-off from Ben.
> "make check" no longer runs the Java tests
> ------------------------------------------
>
> Key: THRIFT-289
> URL: https://issues.apache.org/jira/browse/THRIFT-289
> Project: Thrift
> Issue Type: Bug
> Components: Library (Java), Test Suite
> Reporter: David Reiss
> Assignee: Bryan Duxbury
> Attachments: 0001-THRIFT-289.-cpp-Fix-make-check-by-defining-a-comp.patch, 0002-THRIFT-289.-java-Make-make-check-run-the-Java-tes.patch
>
>
> Broken by r738695.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-289) "make check" no longer runs the Java
tests
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12668402#action_12668402 ]
David Reiss commented on THRIFT-289:
------------------------------------
As expected, it was a stupid typo (please don't look carefully). Patches attached.
> "make check" no longer runs the Java tests
> ------------------------------------------
>
> Key: THRIFT-289
> URL: https://issues.apache.org/jira/browse/THRIFT-289
> Project: Thrift
> Issue Type: Bug
> Components: Library (Java), Test Suite
> Reporter: David Reiss
> Assignee: Bryan Duxbury
> Attachments: 0001-THRIFT-289.-cpp-Fix-make-check-by-defining-a-comp.patch, 0002-THRIFT-289.-java-Make-make-check-run-the-Java-tes.patch
>
>
> Broken by r738695.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (THRIFT-289) "make check" no longer runs the Java
tests
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Duxbury resolved THRIFT-289.
----------------------------------
Resolution: Fixed
Ok, things seem to run without any error messages. Committed.
> "make check" no longer runs the Java tests
> ------------------------------------------
>
> Key: THRIFT-289
> URL: https://issues.apache.org/jira/browse/THRIFT-289
> Project: Thrift
> Issue Type: Bug
> Components: Library (Java), Test Suite
> Reporter: David Reiss
> Assignee: Bryan Duxbury
> Attachments: 0001-THRIFT-289.-cpp-Fix-make-check-by-defining-a-comp.patch, 0002-THRIFT-289.-java-Make-make-check-run-the-Java-tes.patch
>
>
> Broken by r738695.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-289) "make check" no longer runs the Java
tests
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12668507#action_12668507 ]
Bryan Duxbury commented on THRIFT-289:
--------------------------------------
I applied the patches, and make check does the right thing now in the Java test. I don't really understand how to run the cpp tests, though. "make check" in test/cpp didn't do anything for me. Am I missing something?
> "make check" no longer runs the Java tests
> ------------------------------------------
>
> Key: THRIFT-289
> URL: https://issues.apache.org/jira/browse/THRIFT-289
> Project: Thrift
> Issue Type: Bug
> Components: Library (Java), Test Suite
> Reporter: David Reiss
> Assignee: Bryan Duxbury
> Attachments: 0001-THRIFT-289.-cpp-Fix-make-check-by-defining-a-comp.patch, 0002-THRIFT-289.-java-Make-make-check-run-the-Java-tes.patch
>
>
> Broken by r738695.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-289) "make check" no longer runs the Java
tests
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Reiss updated THRIFT-289:
-------------------------------
Patch Info: [Patch Available]
> "make check" no longer runs the Java tests
> ------------------------------------------
>
> Key: THRIFT-289
> URL: https://issues.apache.org/jira/browse/THRIFT-289
> Project: Thrift
> Issue Type: Bug
> Components: Library (Java), Test Suite
> Reporter: David Reiss
> Assignee: Bryan Duxbury
> Attachments: 0001-THRIFT-289.-cpp-Fix-make-check-by-defining-a-comp.patch, 0002-THRIFT-289.-java-Make-make-check-run-the-Java-tes.patch
>
>
> Broken by r738695.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-289) "make check" no longer runs the Java
tests
Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12668600#action_12668600 ]
Bryan Duxbury commented on THRIFT-289:
--------------------------------------
Hm, the Python tests seem to fail for me. Is that expected? (I have no idea if my python env is set up anywhere remotely close to correct.)
> "make check" no longer runs the Java tests
> ------------------------------------------
>
> Key: THRIFT-289
> URL: https://issues.apache.org/jira/browse/THRIFT-289
> Project: Thrift
> Issue Type: Bug
> Components: Library (Java), Test Suite
> Reporter: David Reiss
> Assignee: Bryan Duxbury
> Attachments: 0001-THRIFT-289.-cpp-Fix-make-check-by-defining-a-comp.patch, 0002-THRIFT-289.-java-Make-make-check-run-the-Java-tes.patch
>
>
> Broken by r738695.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (THRIFT-289) "make check" no longer runs the Java
tests
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-289?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
David Reiss updated THRIFT-289:
-------------------------------
Attachment: 0002-THRIFT-289.-java-Make-make-check-run-the-Java-tes.patch
0001-THRIFT-289.-cpp-Fix-make-check-by-defining-a-comp.patch
> "make check" no longer runs the Java tests
> ------------------------------------------
>
> Key: THRIFT-289
> URL: https://issues.apache.org/jira/browse/THRIFT-289
> Project: Thrift
> Issue Type: Bug
> Components: Library (Java), Test Suite
> Reporter: David Reiss
> Assignee: Bryan Duxbury
> Attachments: 0001-THRIFT-289.-cpp-Fix-make-check-by-defining-a-comp.patch, 0002-THRIFT-289.-java-Make-make-check-run-the-Java-tes.patch
>
>
> Broken by r738695.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (THRIFT-289) "make check" no longer runs the Java
tests
Posted by "David Reiss (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/THRIFT-289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12668312#action_12668312 ]
David Reiss commented on THRIFT-289:
------------------------------------
I can fix this if you give me instructions for running the test manually. When I try "ant test", it cannot find the Apache Commons Lang jar. Among the errors, I get "dropping /home/dreiss/thrift/lib/java/${thrift.extra.cpath} from path as it doesn't exist".
I tried to create the properties file.
{code}
dreiss@dr-mbp:master:dreiss$ cat /home/dreiss/.thrift-build.properties
thift.extra.cpath = /usr/share/java/commons-lang-2.3.jar
{code}
> "make check" no longer runs the Java tests
> ------------------------------------------
>
> Key: THRIFT-289
> URL: https://issues.apache.org/jira/browse/THRIFT-289
> Project: Thrift
> Issue Type: Bug
> Components: Library (Java), Test Suite
> Reporter: David Reiss
> Assignee: Bryan Duxbury
>
> Broken by r738695.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.