You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/03/28 00:14:54 UTC
[GitHub] [lucene-solr] athrog opened a new pull request #1385: SOLR-14370:
Refactor bin/solr to allow external override of Jetty modules
athrog opened a new pull request #1385: SOLR-14370: Refactor bin/solr to allow external override of Jetty modules
URL: https://github.com/apache/lucene-solr/pull/1385
<!--
_(If you are a project committer then you may remove some/all of the following template.)_
Before creating a pull request, please file an issue in the ASF Jira system for Lucene or Solr:
* https://issues.apache.org/jira/projects/LUCENE
* https://issues.apache.org/jira/projects/SOLR
You will need to create an account in Jira in order to create an issue.
The title of the PR should reference the Jira issue number in the form:
* LUCENE-####: <short description of problem or changes>
* SOLR-####: <short description of problem or changes>
LUCENE and SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
# Description
The bin/solr script currently does not allow for externally overriding the modules passed to Jetty on startup.
# Solution
This PR adds the ability to override the Jetty modules on startup by setting `JETTY_MODULES` as an environment variable; when passed, bin/solr will pass through (and not clobber) the string verbatim into `SOLR_JETTY_CONFIG`. For example, you can now run:
```
JETTY_MODULES=--module=foo bin/solr start
```
This PR also allows for external overriding of `SOLR_URL_SCHEME` and `SOLR_SSL_OPTS`.
# Tests
We have been using this change in our internal fork of Solr. When creating this PR, I started Solr with `JETTY_MODULES` set, and unset to verify behavior as expected.
# Checklist
Please review the following and check all that apply:
- [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
- [x] I have created a Jira issue and added the issue ID to my pull request title.
- [x] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
- [x] I have developed this patch against the `master` branch.
- [x] I have run `ant precommit` and the appropriate test suite.
- [ ] I have added tests for my changes.
- [ ] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] athrog commented on issue #1385: SOLR-14370: Refactor
bin/solr to allow external override of Jetty modules
Posted by GitBox <gi...@apache.org>.
athrog commented on issue #1385: SOLR-14370: Refactor bin/solr to allow external override of Jetty modules
URL: https://github.com/apache/lucene-solr/pull/1385#issuecomment-605364740
@dsmiley Let me know if I should add documentation for this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org