You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jmeter.apache.org by pm...@apache.org on 2019/11/15 07:31:01 UTC
[jmeter] branch master updated (7850afb -> 79bda1b)
This is an automated email from the ASF dual-hosted git repository.
pmouawad pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/jmeter.git.
from 7850afb JDBC Connection Configuration: Add connectionProperties
add 79bda1b Add screenshots for new JMESPath elements and update screenshot for jdbc connection configuration
No new revisions were added by this update.
Summary of changes:
.../screenshots/assertion/jmespath_assertion.png | Bin 0 -> 14565 bytes
.../screenshots/extractor/jmespath_extractor.png | Bin 0 -> 14307 bytes
.../screenshots/jdbc-config/jdbc-conn-config.png | Bin 26380 -> 37115 bytes
xdocs/usermanual/component_reference.xml | 6 +++---
4 files changed, 3 insertions(+), 3 deletions(-)
create mode 100644 xdocs/images/screenshots/assertion/jmespath_assertion.png
create mode 100644 xdocs/images/screenshots/extractor/jmespath_extractor.png
Re: [jmeter] branch master updated (7850afb -> 79bda1b)
Posted by Vladimir Sitnikov <si...@gmail.com>.
Ok. I see you've made the screenshot to be much wider (687px -> 1055px):
https://github.com/apache/jmeter/commit/79bda1b4ea1eb9494811ca0c166ccca85bebf818?short_path=10973a0#diff-10973a05c7bd6dbecfcee858f78121b1
Does it help readability? I doubt so.
So, would we please enable force-push and shrink the image?
Vladimir
Re: [jmeter] branch master updated (7850afb -> 79bda1b)
Posted by Philippe Mouawad <ph...@gmail.com>.
Hello,
Yes I did :-)
Regards
On Fri, Nov 15, 2019 at 8:59 AM Vladimir Sitnikov <
sitnikov.vladimir@gmail.com> wrote:
> >Bin 26380 -> 37115 bytes
>
> Philippe, have you compressed the image?
>
> It is yet another reason to enable force-push.
> If a big file suddenly committed, it would be hard to get rid of it.
>
> Vladimir
>
--
Cordialement.
Philippe Mouawad.
Re: [jmeter] branch master updated (7850afb -> 79bda1b)
Posted by Vladimir Sitnikov <si...@gmail.com>.
>Bin 26380 -> 37115 bytes
Philippe, have you compressed the image?
It is yet another reason to enable force-push.
If a big file suddenly committed, it would be hard to get rid of it.
Vladimir