[jira] Assigned: (MAHOUT-48) isConverged() and converge flag OK?

["Jeff Eastman (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/MAHOUT-48?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jeff Eastman reassigned MAHOUT-48:
----------------------------------

    Assignee: Jeff Eastman

> isConverged() and converge flag OK?
> -----------------------------------
>
>                 Key: MAHOUT-48
>                 URL: https://issues.apache.org/jira/browse/MAHOUT-48
>             Project: Mahout
>          Issue Type: Bug
>    Affects Versions: 0.1
>         Environment: All
>            Reporter: Sean Owen
>            Assignee: Jeff Eastman
>            Priority: Trivial
>             Fix For: 0.1
>
>
> Look at KMeansDriver.isConverged() -- we have...
> boolean converged = true;
> while (converged && ...) {
>   converged = converged && ...;
> }
> converged is never false in the loop so the right side's "converged &&" could be removed.
> I'm comparing to KMeansDriver.isConverged() which doesn't use "converged &&" in the while condition and wondering if it's worth a double-check that the logic is in fact different between the two. This came up during some more code inspection.
> Also let me tack on this tiny observation:
> WeightedDistanceMeasure.configure(): weightsPathName is never null and doesn't need to be checked

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.