Re: Whoosh requirements

[Saint Germain <sa...@gmail.com>]

On Wed, 15 Jan 2014 10:53:01 +0100, Andrej Golcov <an...@digiverse.si>
wrote :
> >> > I would suggest to make Bloodhound using Whoosh 2.5 (and removing
> >> > aforementioned workarounds) with search index rebuild when
> >> > upgrading from setup that uses indexes created with Whoosh 2.4.
> >> >
> >>
> >> Hello,
> >>
> >> I have created the ticket #741 to manage this point:
> >> https://issues.apache.org/bloodhound/ticket/741
> >>
> >> I added a tentative patch to remove the workaround and
> >> remove/modify the tests accordingly.
> >>
> >> I have no experience on Bloodhound upgrade, so I haven't touched
> >> anything on this part.
> >> I also intend to manually test the search features of Bloodhound
> >> in the next days to check if anything is broken by this Whoosh
> >> upgrade (but having read the 2.5 changelog, it seems that there
> >> are no big changes).
> >>
> >> Best regards,
> >>
> >
> > Should we add Whoosh (and it's version) as a requirement in
> > `requirements.txt` and `requirements-dev.txt`, since
> > BloodhoundSearch is specified in that file? For other packages such
> > as Trac we've included the dependencies in the pip requirements
> > file.
> 
> requirements.txt references bloodhound_search that declares dependency
> on whoosh==2.4.1.
> See bloodhound_search/setup.py:
> In order to upgrade whoosh version, this define should be changed:
> 
> install_requires = [
>         'setuptools>=0.6b1',
>         'Trac>=0.11',
>         'whoosh==2.4.1'
> 

Hello !

I have uploaded a patch to ticket #741 against the current Bloodhound
svn trunk revision r1562687.

I have not modified requirements.txt and requirements-dev.txt as Andrej
explained that it should be modified only in bloodhound_search/setup.py.

Can someone review the patch and check that it is correct ?
In particular I have a question on how to handle exceptions coming from
Whoosh (currently it also "breaks" Bloodhound).

It would be good if it could be included in the next Bloodhound release.

Thanks in advance,

Re: Whoosh requirements

[Anže Starič <an...@gmail.com>]

> Can someone review the patch and check that it is correct ?

The patch looks ok. As far as I am concerned, you can commit it.