You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@trafficserver.apache.org by Leif Hedstrom <zw...@apache.org> on 2018/06/06 10:16:57 UTC

[INFO] Don't merge PRs with missing information

Hi all,

I’m going through all the PRs landed for 8.0.0, and there’s an alarming number of PRs without fields such as

	Milestone
	Author
	Label


This is not cool! Please, if you are a committer, and merging your own, or others, PRs, you are responsible for making sure that all this information is updated, and correct, before you merge such PRs.

Thanks,

— Leif

Github example query:  is:pr is:merged no:milestone

Re: [INFO] Don't merge PRs with missing information

Posted by CrazyCow <zh...@gmail.com>.

Could we add these requirements to the checklist where we check
milestones/labels as we check review approval/autest/build?

2018-06-06 3:16 GMT-07:00 Leif Hedstrom <zw...@apache.org>:

> Hi all,
>
> I’m going through all the PRs landed for 8.0.0, and there’s an alarming
> number of PRs without fields such as
>
>         Milestone
>         Author
>         Label
>
>
> This is not cool! Please, if you are a committer, and merging your own, or
> others, PRs, you are responsible for making sure that all this information
> is updated, and correct, before you merge such PRs.
>
> Thanks,
>
> — Leif
>
> Github example query:  is:pr is:merged no:milestone
>
>