You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "frankvicky (via GitHub)" <gi...@apache.org> on 2024/09/11 06:03:27 UTC

[PR] KAFKA-17253: Deprecate Leaking Getter Methods in Joined Helper Class [kafka]

frankvicky opened a new pull request, #17164:
URL: https://github.com/apache/kafka/pull/17164

   JIRA: [KAFKA-17253](https://issues.apache.org/jira/browse/KAFKA-17253)
   > The helper class `Joined` has four getter methods `gracePeriod()`, `keySerde()`, `valueSerde()` and `otherValueSerde()` which don't belong to this class.
   We should deprecate them for future removal – all four are already available via JoinedInternal where they belong to.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] KAFKA-17253: Deprecate Leaking Getter Methods in Joined Helper Class [kafka]

Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax merged PR #17164:
URL: https://github.com/apache/kafka/pull/17164


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] KAFKA-17253: Deprecate Leaking Getter Methods in Joined Helper Class [kafka]

Posted by "mjsax (via GitHub)" <gi...@apache.org>.
mjsax commented on PR #17164:
URL: https://github.com/apache/kafka/pull/17164#issuecomment-2346832177

   Thanks for the KIP and PR. Merged to `trunk`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org