You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by GitBox <gi...@apache.org> on 2020/03/20 11:17:48 UTC
[GitHub] [beam] iemejia commented on a change in pull request #11178:
[BEAM-9430] Update CHANGES.md to reflect removal of
ProcessContext#updateWatermark
iemejia commented on a change in pull request #11178: [BEAM-9430] Update CHANGES.md to reflect removal of ProcessContext#updateWatermark
URL: https://github.com/apache/beam/pull/11178#discussion_r395572143
##########
File path: CHANGES.md
##########
@@ -58,6 +58,7 @@
## Breaking Changes
* HBaseIO.ReadAll now requires a PCollection of HBaseIO.Read objects instead of HBaseQuery objects ([BEAM-9279](https://issues.apache.org/jira/browse/BEAM-9279)).
+* ProcessContext.updateWatermark has been removed in favor of using a WatermarkEstimator ([BEAM-9430](https://issues.apache.org/jira/browse/BEAM-9430)).
Review comment:
Oh sorry it was just obviously good so I proceeded. Next time I will wait.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services