You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/06/20 19:46:59 UTC
[GitHub] [superset] prosdev0107 opened a new pull request, #20442: fix(db): Show the only db install guide when the db is already installed and error is existed while importing file.
prosdev0107 opened a new pull request, #20442:
URL: https://github.com/apache/superset/pull/20442
### SUMMARY
Add error message when user tries to import without having db driver installed
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE:
AFTER:
### TESTING INSTRUCTIONS
1. Import a file (dashboard, chart, dataset, database) that contains a database where the user doesn't have the database driver installed
2. Current behavior:
The db driver is installed and the error has nothing to do with the database, so the user getting this error text doesn't make sense.
3. Expected behavior:
User sees an error message when they don't have the db driver installed
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #20442: fix(db): Show the only db install guide when the db is already installed and error is existed while importing file.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #20442:
URL: https://github.com/apache/superset/pull/20442#issuecomment-1168685803
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] yousoph commented on pull request #20442: fix(db): Show the only db install guide when the db is already installed and error is existed while importing file.
Posted by GitBox <gi...@apache.org>.
yousoph commented on PR #20442:
URL: https://github.com/apache/superset/pull/20442#issuecomment-1164675663
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #20442: fix(db): Show the only db install guide when the db is already installed and error is existed while importing file.
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #20442:
URL: https://github.com/apache/superset/pull/20442#issuecomment-1160818627
# [Codecov](https://codecov.io/gh/apache/superset/pull/20442?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#20442](https://codecov.io/gh/apache/superset/pull/20442?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5fff274) into [master](https://codecov.io/gh/apache/superset/commit/b7eb23544077aa867bb17694e8a050b868e3b9a2?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (b7eb235) will **decrease** coverage by `0.00%`.
> The diff coverage is `33.33%`.
> :exclamation: Current head 5fff274 differs from pull request most recent head 63eebfd. Consider uploading reports for the commit 63eebfd to get more accurate results
```diff
@@ Coverage Diff @@
## master #20442 +/- ##
==========================================
- Coverage 66.58% 66.58% -0.01%
==========================================
Files 1738 1738
Lines 65162 65163 +1
Branches 6895 6896 +1
==========================================
Hits 43387 43387
- Misses 20026 20027 +1
Partials 1749 1749
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `51.76% <33.33%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/20442?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...rset-frontend/src/components/ImportModal/index.tsx](https://codecov.io/gh/apache/superset/pull/20442/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW1wb3J0TW9kYWwvaW5kZXgudHN4) | `73.17% <0.00%> (ø)` | |
| [...frontend/src/components/ImportModal/ErrorAlert.tsx](https://codecov.io/gh/apache/superset/pull/20442/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSW1wb3J0TW9kYWwvRXJyb3JBbGVydC50c3g=) | `33.33% <50.00%> (-6.67%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/20442?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/20442?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [b7eb235...63eebfd](https://codecov.io/gh/apache/superset/pull/20442?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] stephenLYZ merged pull request #20442: fix(db): Show the only db install guide when the db is already installed and error is existed while importing file.
Posted by GitBox <gi...@apache.org>.
stephenLYZ merged PR #20442:
URL: https://github.com/apache/superset/pull/20442
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #20442: fix(db): Show the only db install guide when the db is already installed and error is existed while importing file.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #20442:
URL: https://github.com/apache/superset/pull/20442#issuecomment-1164680569
@yousoph Ephemeral environment spinning up at http://34.221.18.69:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] diegomedina248 commented on a diff in pull request #20442: fix(db): Show the only db install guide when the db is already installed and error is existed while importing file.
Posted by GitBox <gi...@apache.org>.
diegomedina248 commented on code in PR #20442:
URL: https://github.com/apache/superset/pull/20442#discussion_r903036487
##########
superset-frontend/src/components/ImportModal/ErrorAlert.tsx:
##########
@@ -31,31 +31,36 @@ export const DOCUMENTATION_LINK = supersetTextDocs
export interface IProps {
errorMessage: string;
+ dbInstall: boolean;
}
-const ErrorAlert: FunctionComponent<IProps> = ({ errorMessage }) => (
+const ErrorAlert: FunctionComponent<IProps> = ({ errorMessage, dbInstall }) => (
<Alert
closable={false}
css={(theme: SupersetTheme) => antdWarningAlertStyles(theme)}
type="error"
showIcon
message={errorMessage}
description={
- <>
- <br />
- {t(
- 'Database driver for importing maybe not installed. Visit the Superset documentation page for installation instructions:',
- )}
- <a
- href={DOCUMENTATION_LINK}
- target="_blank"
- rel="noopener noreferrer"
- className="additional-fields-alert-description"
- >
- {t('here')}
- </a>
- .
- </>
+ dbInstall ? (
Review Comment:
`showDbInstallInstructions` or something similar? The name seems a bit cryptic to me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org