[jira] [Commented] (IGNITE-5607) HttpSessionBindingListener is not supported for clustered web session

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/IGNITE-5607?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16074562#comment-16074562 ] 

ASF GitHub Bot commented on IGNITE-5607:
----------------------------------------

GitHub user yucigou opened a pull request:

    https://github.com/apache/ignite/pull/2243

    IGNITE-5607: HttpSessionBindingListener is not supported for clustere…

    Ignite WebSessionV2 uses genuineSes as the original HttpSession.
    
    Therefore, when setting an attribute or setting the maxInactiveInterval, Ignite should tell the original HttpSession about it.
    
    Otherwise, when the web container (such as Tomcat) thinks that a session expires, or is invalidated, or a session attribute gets removed, etc., session attributes' HttpSessionBindingListener's valueUnbound callback function will not get fired.
    
    So once the original HttpSession gets updated with the session attributes and the maxInactiveInterval, the web container will transitively trigger the session attributes' HttpSessionBindingListener's valueUnbound callback function when a session expires, etc.
    
    (By the way, tested with our app, and our issue is fixed:
    http://apache-ignite-developers.2346864.n4.nabble.com/It-seems-WebSession-s-removeAttribute-does-not-support-HttpSessionBindingListener-td19184.html)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/EuropePMC/ignite master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/ignite/pull/2243.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2243
    
----
commit eaaee978d37c5a66dff2d59515ddb70c40d5e31b
Author: Yuci Gou <yg...@ebi.ac.uk>
Date:   2017-07-05T10:26:57Z

    IGNITE-5607: HttpSessionBindingListener is not supported for clustered web session

----


> HttpSessionBindingListener is not supported for clustered web session
> ---------------------------------------------------------------------
>
>                 Key: IGNITE-5607
>                 URL: https://issues.apache.org/jira/browse/IGNITE-5607
>             Project: Ignite
>          Issue Type: Bug
>          Components: websession
>    Affects Versions: 2.0
>            Reporter: Valentin Kulichenko
>             Fix For: 2.1
>
>
> Ignite's implementation of {{HttpSession}} ignores values implementing {{HttpSessionBindingListener}}.
> {{WebSession#setAttribute}} and {{WebSession#removeAttribute}} should be modified accordingly.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)