You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by "liugddx (via GitHub)" <gi...@apache.org> on 2023/04/10 17:08:36 UTC
[GitHub] [incubator-seatunnel] liugddx opened a new pull request, #4540: [Improve][Catalog] refactor catalog
liugddx opened a new pull request, #4540:
URL: https://github.com/apache/incubator-seatunnel/pull/4540
<!--
Thank you for contributing to SeaTunnel! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
## Contribution Checklist
- Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
- Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
- Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
-->
## Purpose of this pull request
<!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If any new Jar binary package adding in your PR, please add License Notice according
[New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
* [ ] If you are contributing the connector code, please check that the following files are updated:
1. Update change log that in connector document. For more details you can refer to [connector-v2](https://github.com/apache/incubator-seatunnel/tree/dev/docs/en/connector-v2)
2. Update [plugin-mapping.properties](https://github.com/apache/incubator-seatunnel/blob/dev/plugin-mapping.properties) and add new connector information in it
3. Update the pom file of [seatunnel-dist](https://github.com/apache/incubator-seatunnel/blob/dev/seatunnel-dist/pom.xml)
* [ ] Update the [`release-note`](https://github.com/apache/incubator-seatunnel/blob/dev/release-note.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] liugddx commented on pull request #4540: [Improve][Catalog] refactor catalog
Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx commented on PR #4540:
URL: https://github.com/apache/incubator-seatunnel/pull/4540#issuecomment-1502707717
@hailin0 @Hisoka-X @ashulin PTAL.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] EricJoy2048 merged pull request #4540: [Improve][Catalog] refactor catalog
Posted by "EricJoy2048 (via GitHub)" <gi...@apache.org>.
EricJoy2048 merged PR #4540:
URL: https://github.com/apache/incubator-seatunnel/pull/4540
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ashulin commented on a diff in pull request #4540: [Improve][Catalog] refactor catalog
Posted by "ashulin (via GitHub)" <gi...@apache.org>.
ashulin commented on code in PR #4540:
URL: https://github.com/apache/incubator-seatunnel/pull/4540#discussion_r1163518218
##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/JdbcDialect.java:
##########
@@ -193,4 +195,40 @@ default ResultSetMetaData getResultSetMetaData(
PreparedStatement ps = conn.prepareStatement(jdbcSourceConfig.getQuery());
return ps.getMetaData();
}
+
+ default String listDatabases() {
+ return "SHOW DATABASES;";
+ }
+
+ default String getUrlFromDatabaseName(String baseUrl, String databaseName, String suffix) {
+ return baseUrl + databaseName + suffix;
+ }
+
+ default String createDatabaseSql(String databaseName) {
+ return String.format("CREATE DATABASE IF NOT EXISTS %s;", quoteIdentifier(databaseName));
+ }
+
+ default String dropDatabaseSql(String databaseName) {
+ return String.format("DROP DATABASE IF EXISTS %s;", quoteIdentifier(databaseName));
+ }
+
+ default String getTableName(ResultSet rs) throws SQLException {
+ return rs.getString(1);
Review Comment:
because Missing context, `1` is a Magic number
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] ashulin commented on a diff in pull request #4540: [Improve][Catalog] refactor catalog
Posted by "ashulin (via GitHub)" <gi...@apache.org>.
ashulin commented on code in PR #4540:
URL: https://github.com/apache/incubator-seatunnel/pull/4540#discussion_r1163518218
##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/JdbcDialect.java:
##########
@@ -193,4 +195,40 @@ default ResultSetMetaData getResultSetMetaData(
PreparedStatement ps = conn.prepareStatement(jdbcSourceConfig.getQuery());
return ps.getMetaData();
}
+
+ default String listDatabases() {
+ return "SHOW DATABASES;";
+ }
+
+ default String getUrlFromDatabaseName(String baseUrl, String databaseName, String suffix) {
+ return baseUrl + databaseName + suffix;
+ }
+
+ default String createDatabaseSql(String databaseName) {
+ return String.format("CREATE DATABASE IF NOT EXISTS %s;", quoteIdentifier(databaseName));
+ }
+
+ default String dropDatabaseSql(String databaseName) {
+ return String.format("DROP DATABASE IF EXISTS %s;", quoteIdentifier(databaseName));
+ }
+
+ default String getTableName(ResultSet rs) throws SQLException {
+ return rs.getString(1);
Review Comment:
Because missing context, `1` is a Magic number
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] liugddx commented on a diff in pull request #4540: [Improve][Catalog] refactor catalog
Posted by "liugddx (via GitHub)" <gi...@apache.org>.
liugddx commented on code in PR #4540:
URL: https://github.com/apache/incubator-seatunnel/pull/4540#discussion_r1163523479
##########
seatunnel-connectors-v2/connector-jdbc/src/main/java/org/apache/seatunnel/connectors/seatunnel/jdbc/internal/dialect/JdbcDialect.java:
##########
@@ -193,4 +195,40 @@ default ResultSetMetaData getResultSetMetaData(
PreparedStatement ps = conn.prepareStatement(jdbcSourceConfig.getQuery());
return ps.getMetaData();
}
+
+ default String listDatabases() {
+ return "SHOW DATABASES;";
+ }
+
+ default String getUrlFromDatabaseName(String baseUrl, String databaseName, String suffix) {
+ return baseUrl + databaseName + suffix;
+ }
+
+ default String createDatabaseSql(String databaseName) {
+ return String.format("CREATE DATABASE IF NOT EXISTS %s;", quoteIdentifier(databaseName));
+ }
+
+ default String dropDatabaseSql(String databaseName) {
+ return String.format("DROP DATABASE IF EXISTS %s;", quoteIdentifier(databaseName));
+ }
+
+ default String getTableName(ResultSet rs) throws SQLException {
+ return rs.getString(1);
Review Comment:
> Because missing context, `1` is a Magic number
I set mysql as the default, and other catalogs can override this method. do you have a good suggestion?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org