You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by aljoscha <gi...@git.apache.org> on 2018/02/28 10:54:47 UTC
[GitHub] flink pull request #5595: [FLINK-8778] Migrate queryable state ITCases to us...
GitHub user aljoscha opened a pull request:
https://github.com/apache/flink/pull/5595
[FLINK-8778] Migrate queryable state ITCases to use MiniClusterResource
This sits on top of #5589.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aljoscha/flink jira-8778-port-qs-it-case-to-flip-6
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5595.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5595
----
commit 54d43a35e30f5df181fba19bbfb18043301b4a9e
Author: Aljoscha Krettek <al...@...>
Date: 2018-02-26T09:12:44Z
[FLINK-8758] Add getters to JobDetailsInfo
commit 637878bda7899874e2ddb544b77549eb6e5f9aa5
Author: Aljoscha Krettek <al...@...>
Date: 2018-02-26T11:29:23Z
Add proper toString() on JsonResponse in RestClient
commit 18c849f30cddccb42b2ffa2b41829aae711401f1
Author: Aljoscha Krettek <al...@...>
Date: 2018-02-26T10:44:57Z
[FLINK-8757] Add MiniClusterResource.getClusterClient()
commit cd877000fac823bb15653b7401cbaecd17fb6371
Author: Aljoscha Krettek <al...@...>
Date: 2018-02-26T10:52:50Z
[FLINK-8758] Make non-blocking ClusterClient.submitJob() public
commit 73daf169640bef252c084ac4a45935ae2bcaf509
Author: Aljoscha Krettek <al...@...>
Date: 2018-02-26T10:53:47Z
[FLINK-8758] Add ClusterClient.getJobStatus()
commit 7fedaaf25e01345792cdcf6473de769a2c72caa3
Author: Aljoscha Krettek <al...@...>
Date: 2018-02-27T12:40:51Z
[FLINK-8758] Add FutureUtils.retrySuccessfulWithDelay()
This retries getting a result until it matches a given predicate or
until we run out of retries.
commit c2332b9caa1f7fa8cea2834fb08e849351b46309
Author: Aljoscha Krettek <al...@...>
Date: 2018-02-27T12:42:09Z
[FLINK-8797] Port AbstractOperatorRestoreTestBase to MiniClusterResource
commit 52abd4005d82de4a5ba902af5c836b5592e485f7
Author: Aljoscha Krettek <al...@...>
Date: 2018-02-26T10:55:14Z
[FLINK-8778] Migrate queryable state ITCases to use MiniClusterResource
----
---
[GitHub] flink issue #5595: [FLINK-8778] Migrate queryable state ITCases to use MiniC...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/5595
Closing in favour of #5589.
---
[GitHub] flink issue #5595: [FLINK-8778] Migrate queryable state ITCases to use MiniC...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on the issue:
https://github.com/apache/flink/pull/5595
@zentol I'm fixing things on #5589 because this PR is only about the last commit.
---
[GitHub] flink pull request #5595: [FLINK-8778] Migrate queryable state ITCases to us...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/5595#discussion_r171209982
--- Diff: flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/MiniClusterResource.java ---
@@ -75,6 +82,10 @@ public MiniClusterResource(
this.miniClusterType = Preconditions.checkNotNull(miniClusterType);
}
+ public ClusterClient getClusterClient() {
--- End diff --
fixing
---
[GitHub] flink pull request #5595: [FLINK-8778] Migrate queryable state ITCases to us...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/5595#discussion_r171209859
--- Diff: flink-clients/src/main/java/org/apache/flink/client/program/ClusterClient.java ---
@@ -981,7 +981,7 @@ public Configuration getFlinkConfiguration() {
* @param jobGraph The JobGraph to be submitted
* @return JobSubmissionResult
*/
- protected abstract JobSubmissionResult submitJob(JobGraph jobGraph, ClassLoader classLoader)
+ public abstract JobSubmissionResult submitJob(JobGraph jobGraph, ClassLoader classLoader)
--- End diff --
Should do, but is that in the scope of this PR?
---
[GitHub] flink pull request #5595: [FLINK-8778] Migrate queryable state ITCases to us...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5595#discussion_r171221624
--- Diff: flink-clients/src/main/java/org/apache/flink/client/program/ClusterClient.java ---
@@ -981,7 +981,7 @@ public Configuration getFlinkConfiguration() {
* @param jobGraph The JobGraph to be submitted
* @return JobSubmissionResult
*/
- protected abstract JobSubmissionResult submitJob(JobGraph jobGraph, ClassLoader classLoader)
+ public abstract JobSubmissionResult submitJob(JobGraph jobGraph, ClassLoader classLoader)
--- End diff --
well...i guess wrong usages will be catched by the tests....
---
[GitHub] flink pull request #5595: [FLINK-8778] Migrate queryable state ITCases to us...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5595#discussion_r171208315
--- Diff: flink-test-utils-parent/flink-test-utils/src/main/java/org/apache/flink/test/util/MiniClusterResource.java ---
@@ -75,6 +82,10 @@ public MiniClusterResource(
this.miniClusterType = Preconditions.checkNotNull(miniClusterType);
}
+ public ClusterClient getClusterClient() {
--- End diff --
return `ClusterClient<?>`?
---
[GitHub] flink pull request #5595: [FLINK-8778] Migrate queryable state ITCases to us...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5595#discussion_r171208805
--- Diff: flink-clients/src/main/java/org/apache/flink/client/program/ClusterClient.java ---
@@ -981,7 +981,7 @@ public Configuration getFlinkConfiguration() {
* @param jobGraph The JobGraph to be submitted
* @return JobSubmissionResult
*/
- protected abstract JobSubmissionResult submitJob(JobGraph jobGraph, ClassLoader classLoader)
+ public abstract JobSubmissionResult submitJob(JobGraph jobGraph, ClassLoader classLoader)
--- End diff --
we could deprecate all other submit-like methods that the `RestClusterClient` doesn't override.
---
[GitHub] flink pull request #5595: [FLINK-8778] Migrate queryable state ITCases to us...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha closed the pull request at:
https://github.com/apache/flink/pull/5595
---