You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by Vladimir Rodionov <vl...@gmail.com> on 2015/03/17 18:36:23 UTC
What happened to SnapshotHFileCleaner?
Literally?
in master and current 0.98 it always says "file is not deletable"
@Override
protected boolean isFileDeletable(FileStatus fStat) {
return false;
}
This is from 0.98.6 (CDH 5.3.0)
@Override
public synchronized boolean isFileDeletable(FileStatus fStat) {
try {
return !cache.contains(fStat.getPath().getName());
} catch (IOException e) {
LOG.error("Exception while checking if:" + fStat.getPath()
+ " was valid, keeping it just in case.", e);
return false;
}
}
Any thoughts, folks?
-Vlad
Re: What happened to SnapshotHFileCleaner?
Posted by Andrew Purtell <ap...@apache.org>.
See
HBASE-13267
On Tue, Mar 17, 2015 at 11:11 AM, Vladimir Rodionov <vl...@gmail.com>
wrote:
> OK, makes sense. Should be deprecated or even removed.
>
> -Vlad
>
> On Tue, Mar 17, 2015 at 10:54 AM, Andrew Purtell <ap...@apache.org>
> wrote:
>
> > "git blame"?
> >
> > Says c32e7651, which is
> >
> > commit c32e76518f832566bd67c80588cd99d6ad315641
> > Author: rahulgidwani <ra...@flurry.com>
> > Date: Mon Jan 26 18:44:25 2015 -0800
> >
> > HBASE-12627 Add back snapshot batching facility
> >
> > Signed-off-by: Andrew Purtell <ap...@apache.org>
> >
> > How files are determined to be deletable changed. We could clean this up
> > further, though, since isFileDeletable became vestigial, it should be
> > deprecated or removed.
> >
> >
> > On Tue, Mar 17, 2015 at 10:36 AM, Vladimir Rodionov <
> > vladrodionov@gmail.com>
> > wrote:
> >
> > > Literally?
> > >
> > > in master and current 0.98 it always says "file is not deletable"
> > >
> > > @Override
> > >
> > > protected boolean isFileDeletable(FileStatus fStat) {
> > >
> > > return false;
> > >
> > > }
> > >
> > >
> > > This is from 0.98.6 (CDH 5.3.0)
> > >
> > > @Override
> > >
> > > public synchronized boolean isFileDeletable(FileStatus fStat) {
> > >
> > > try {
> > >
> > > return !cache.contains(fStat.getPath().getName());
> > >
> > > } catch (IOException e) {
> > >
> > > LOG.error("Exception while checking if:" + fStat.getPath()
> > >
> > > + " was valid, keeping it just in case.", e);
> > >
> > > return false;
> > >
> > > }
> > >
> > > }
> > >
> > >
> > > Any thoughts, folks?
> > >
> > >
> > > -Vlad
> > >
> >
> >
> >
> > --
> > Best regards,
> >
> > - Andy
> >
> > Problems worthy of attack prove their worth by hitting back. - Piet Hein
> > (via Tom White)
> >
>
--
Best regards,
- Andy
Problems worthy of attack prove their worth by hitting back. - Piet Hein
(via Tom White)
Re: What happened to SnapshotHFileCleaner?
Posted by Vladimir Rodionov <vl...@gmail.com>.
OK, makes sense. Should be deprecated or even removed.
-Vlad
On Tue, Mar 17, 2015 at 10:54 AM, Andrew Purtell <ap...@apache.org>
wrote:
> "git blame"?
>
> Says c32e7651, which is
>
> commit c32e76518f832566bd67c80588cd99d6ad315641
> Author: rahulgidwani <ra...@flurry.com>
> Date: Mon Jan 26 18:44:25 2015 -0800
>
> HBASE-12627 Add back snapshot batching facility
>
> Signed-off-by: Andrew Purtell <ap...@apache.org>
>
> How files are determined to be deletable changed. We could clean this up
> further, though, since isFileDeletable became vestigial, it should be
> deprecated or removed.
>
>
> On Tue, Mar 17, 2015 at 10:36 AM, Vladimir Rodionov <
> vladrodionov@gmail.com>
> wrote:
>
> > Literally?
> >
> > in master and current 0.98 it always says "file is not deletable"
> >
> > @Override
> >
> > protected boolean isFileDeletable(FileStatus fStat) {
> >
> > return false;
> >
> > }
> >
> >
> > This is from 0.98.6 (CDH 5.3.0)
> >
> > @Override
> >
> > public synchronized boolean isFileDeletable(FileStatus fStat) {
> >
> > try {
> >
> > return !cache.contains(fStat.getPath().getName());
> >
> > } catch (IOException e) {
> >
> > LOG.error("Exception while checking if:" + fStat.getPath()
> >
> > + " was valid, keeping it just in case.", e);
> >
> > return false;
> >
> > }
> >
> > }
> >
> >
> > Any thoughts, folks?
> >
> >
> > -Vlad
> >
>
>
>
> --
> Best regards,
>
> - Andy
>
> Problems worthy of attack prove their worth by hitting back. - Piet Hein
> (via Tom White)
>
Re: What happened to SnapshotHFileCleaner?
Posted by Andrew Purtell <ap...@apache.org>.
"git blame"?
Says c32e7651, which is
commit c32e76518f832566bd67c80588cd99d6ad315641
Author: rahulgidwani <ra...@flurry.com>
Date: Mon Jan 26 18:44:25 2015 -0800
HBASE-12627 Add back snapshot batching facility
Signed-off-by: Andrew Purtell <ap...@apache.org>
How files are determined to be deletable changed. We could clean this up
further, though, since isFileDeletable became vestigial, it should be
deprecated or removed.
On Tue, Mar 17, 2015 at 10:36 AM, Vladimir Rodionov <vl...@gmail.com>
wrote:
> Literally?
>
> in master and current 0.98 it always says "file is not deletable"
>
> @Override
>
> protected boolean isFileDeletable(FileStatus fStat) {
>
> return false;
>
> }
>
>
> This is from 0.98.6 (CDH 5.3.0)
>
> @Override
>
> public synchronized boolean isFileDeletable(FileStatus fStat) {
>
> try {
>
> return !cache.contains(fStat.getPath().getName());
>
> } catch (IOException e) {
>
> LOG.error("Exception while checking if:" + fStat.getPath()
>
> + " was valid, keeping it just in case.", e);
>
> return false;
>
> }
>
> }
>
>
> Any thoughts, folks?
>
>
> -Vlad
>
--
Best regards,
- Andy
Problems worthy of attack prove their worth by hitting back. - Piet Hein
(via Tom White)