You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by André Malo <nd...@perlig.de> on 2003/03/05 16:49:13 UTC

Re: cvs commit: httpd-2.0/server/mpm/winnt child.c mpm_winnt.c mpm_winnt.h

* ake@apache.org wrote:

>   +AP_INIT_TAKE1("WindowsSocketsWorkaround", set_sockets_workaround, NULL, RSRC_CONF,
>   +  "Set \"on\" to work around buggy Winsock provider implementations of certain VPN or Firewall software"),
>   +

hey, no need to double code. AP_INIT_FLAG exists ;-)

nd
-- 
print "Just Another Perl Hacker";

# André Malo, <http://pub.perlig.de/> #

Re: cvs commit: httpd-2.0/server/mpm/winnt child.c mpm_winnt.c mpm_winnt.h

Posted by Allan Edwards <ak...@us.ibm.com>.
> probably. My opinion in this case isn't strong either. Actually I wanted to 
> exclude an oversight of the INIT_FLAG macro :)

OK, point taken, thanks for the feedback Andre!

Allan


Re: cvs commit: httpd-2.0/server/mpm/winnt child.c mpm_winnt.c mpm_winnt.h

Posted by André Malo <nd...@perlig.de>.
* Allan Edwards wrote:

>>>  +AP_INIT_TAKE1("WindowsSocketsWorkaround", set_sockets_workaround, NULL, RSRC_CONF,
>>>  +  "Set \"on\" to work around buggy Winsock provider implementations of certain VPN or Firewall software"),
>>>  +
>> hey, no need to double code. AP_INIT_FLAG exists ;-)
> 
> Well I guess that's just a matter of personal preference,

probably. My opinion in this case isn't strong either. Actually I wanted to 
exclude an oversight of the INIT_FLAG macro :)

nd
-- 
Wenn nur Ingenieure mit Diplom programmieren würden, hätten wir
wahrscheinlich weniger schlechte Software.
Wir hätten allerdings auch weniger gute Software.
                                   -- Felix von Leitner in dasr

Re: cvs commit: httpd-2.0/server/mpm/winnt child.c mpm_winnt.c mpm_winnt.h

Posted by Allan Edwards <ak...@us.ibm.com>.
>>  +AP_INIT_TAKE1("WindowsSocketsWorkaround", set_sockets_workaround, NULL, RSRC_CONF,
>>  +  "Set \"on\" to work around buggy Winsock provider implementations of certain VPN or Firewall software"),
>>  +
> 
> 
> hey, no need to double code. AP_INIT_FLAG exists ;-)

Well I guess that's just a matter of personal preference,
I don't have strong feelings either way... took the cue from
OtherBill. You might argue there is precedence for his style
with Keepalive on|off. Any others think on|off is better
dispensed with?

Allan