You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@couchdb.apache.org by robertkowalski <gi...@git.apache.org> on 2015/04/01 12:38:16 UTC
[GitHub] couchdb-fauxton pull request: build: don't hardcode environments
GitHub user robertkowalski opened a pull request:
https://github.com/apache/couchdb-fauxton/pull/351
build: don't hardcode environments
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robertkowalski/couchdb-fauxton gruntfile-fix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/couchdb-fauxton/pull/351.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #351
----
commit 00c737a5044227c8253632aa661472a03a846686
Author: Robert Kowalski <ro...@apache.org>
Date: 2015-04-01T10:27:49Z
build: don't hardcode environments
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: build: don't hardcode environments
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/couchdb-fauxton/pull/351
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: build: don't hardcode environments
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/351#issuecomment-88488704
@ksnavely I don't actually think so.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: build: don't hardcode environments
Posted by garrensmith <gi...@git.apache.org>.
Github user garrensmith commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/351#issuecomment-88488931
merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: build: don't hardcode environments
Posted by ksnavely <gi...@git.apache.org>.
Github user ksnavely commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/351#issuecomment-88449293
Do you need to add `couchapp` to [this](https://github.com/apache/couchdb-fauxton/pull/351/files#diff-35b4a816e0441e6a375cd925af50752cR102)?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] couchdb-fauxton pull request: build: don't hardcode environments
Posted by robertkowalski <gi...@git.apache.org>.
Github user robertkowalski commented on the pull request:
https://github.com/apache/couchdb-fauxton/pull/351#issuecomment-88672167
@ksnavely no, as these are just default values - `settings.template` is set in https://github.com/apache/couchdb-fauxton/blob/d7641f16e7a12faff896136826b43f7affb0a393/tasks/helper.js#L21
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---