You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@iota.apache.org by shiv4nsh <gi...@git.apache.org> on 2016/09/28 06:43:23 UTC
[GitHub] incubator-iota pull request #20: [IOTA-23] Rebased the Code and converted th...
GitHub user shiv4nsh opened a pull request:
https://github.com/apache/incubator-iota/pull/20
[IOTA-23] Rebased the Code and converted the spray Routes to the play Routes
In this PR in have incorporated the changes so that the Play routes will be used instead of the spray Routes.
This PR along with #19 will have all the changes for #6 and #8 . Hence we can close #6 and #8 .
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shiv4nsh/incubator-iota IOTA-23
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-iota/pull/20.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #20
----
commit d2f10b70612de0ceeaec18f341fe485b399b9fe9
Author: Shivansh <sh...@gmail.com>
Date: 2016-09-28T04:04:56Z
Added the play-netty dependencies
commit ba8eb4d2c12257bdaceaa2d3b3251d50c690398f
Author: Shivansh <sh...@gmail.com>
Date: 2016-09-28T04:05:30Z
Added the play dependency to the fey core
commit fe606d70daf76f3de761223b3d44dcb9ab11f172
Author: Shivansh <sh...@gmail.com>
Date: 2016-09-28T06:38:20Z
converted the spray framework routes to the play routes
commit c9bf4474c608e1b2d091e018027bd865ab444abd
Author: Shivansh <sh...@gmail.com>
Date: 2016-09-28T06:38:58Z
Added the configuration settings for the port and the URL
commit 1bc453c44aea315d72c38c5ffc70f73301e5b59b
Author: Shivansh <sh...@gmail.com>
Date: 2016-09-28T06:39:34Z
Refactored the code for the calling of FeyUIService
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-iota issue #20: [IOTA-23] Rebased the Code and converted the spray...
Posted by shiv4nsh <gi...@git.apache.org>.
Github user shiv4nsh commented on the issue:
https://github.com/apache/incubator-iota/pull/20
@tonyfaustini : Nice Catch ! I have made the required changes and now it looks like this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-iota issue #20: [IOTA-23] Rebased the Code and converted the spray...
Posted by barbaragomes <gi...@git.apache.org>.
Github user barbaragomes commented on the issue:
https://github.com/apache/incubator-iota/pull/20
@shiv4nsh Everything looks good to me. Thank you for the fixes.
@tonyLitBit Could you please merge this PR?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-iota issue #20: [IOTA-23] Rebased the Code and converted the spray...
Posted by shiv4nsh <gi...@git.apache.org>.
Github user shiv4nsh commented on the issue:
https://github.com/apache/incubator-iota/pull/20
@tonyLitBit : I have done the Changes , please review it Thanks !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-iota issue #20: [IOTA-23] Rebased the Code and converted the spray...
Posted by tonyLitBit <gi...@git.apache.org>.
Github user tonyLitBit commented on the issue:
https://github.com/apache/incubator-iota/pull/20
Can you please add the configuration to the utils.scala file in the config object
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-iota issue #20: [IOTA-23] Rebased the Code and converted the spray...
Posted by shiv4nsh <gi...@git.apache.org>.
Github user shiv4nsh commented on the issue:
https://github.com/apache/incubator-iota/pull/20
@tonyfaustini : Can we merge this now ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-iota issue #20: [IOTA-23] Rebased the Code and converted the spray...
Posted by tonyLitBit <gi...@git.apache.org>.
Github user tonyLitBit commented on the issue:
https://github.com/apache/incubator-iota/pull/20
The end point monitoringevents is not working as expected it is supposed to render the html table but instead it is displaying the source code
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-iota pull request #20: [IOTA-23] Rebased the Code and converted th...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-iota/pull/20
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---