You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/08/11 15:58:02 UTC
[GitHub] [arrow] bkietz opened a new pull request #10914: ARROW-9616: [C++][R] Remove templated base classes named `/.*ConcurrencyWrapper/`
bkietz opened a new pull request #10914:
URL: https://github.com/apache/arrow/pull/10914
This is a guess; Windows assumptions about linkage + templated base classes have been problematic in the past
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] bkietz closed pull request #10914: ARROW-9616: [C++][R] Remove templated base classes named `/.*ConcurrencyWrapper/`
Posted by GitBox <gi...@apache.org>.
bkietz closed pull request #10914:
URL: https://github.com/apache/arrow/pull/10914
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jeroen commented on pull request #10914: ARROW-9616: [C++][R] Remove templated base classes named `/.*ConcurrencyWrapper/`
Posted by GitBox <gi...@apache.org>.
jeroen commented on pull request #10914:
URL: https://github.com/apache/arrow/pull/10914#issuecomment-963354970
No the issue still exists for arrow 6.0.0. The fix by @bkietz had fixed the problem for 90%, there was only [1 remaining lto error](https://gist.github.com/jeroen/0c8bbfcdc51c6ac6d0672a3ca164e532)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jeroen edited a comment on pull request #10914: ARROW-9616: [C++][R] Remove templated base classes named `/.*ConcurrencyWrapper/`
Posted by GitBox <gi...@apache.org>.
jeroen edited a comment on pull request #10914:
URL: https://github.com/apache/arrow/pull/10914#issuecomment-897481964
@bkietz seems to have solved most errors, but still 1 remaining: https://gist.github.com/jeroen/0c8bbfcdc51c6ac6d0672a3ca164e532
Btw I am testing this with the new upcoming gcc-10 toolchain, I don't think it is needed to enable this in your CI with rtools4 at this point.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] bkietz commented on pull request #10914: ARROW-9616: [C++][R] Remove templated base classes named `/.*ConcurrencyWrapper/`
Posted by GitBox <gi...@apache.org>.
bkietz commented on pull request #10914:
URL: https://github.com/apache/arrow/pull/10914#issuecomment-897608698
@pitrou [it's actually a compiler error](https://github.com/apache/arrow/pull/10914/checks?check_run_id=3303114278#step:13:188). Still a problem, though
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jeroen edited a comment on pull request #10914: ARROW-9616: [C++][R] Remove templated base classes named `/.*ConcurrencyWrapper/`
Posted by GitBox <gi...@apache.org>.
jeroen edited a comment on pull request #10914:
URL: https://github.com/apache/arrow/pull/10914#issuecomment-963354970
No the issue still exists for arrow 6.0.0. The fix by @bkietz had fixed the problem for 90%, there was only [1 remaining lto error](https://gist.github.com/jeroen/0c8bbfcdc51c6ac6d0672a3ca164e532). However this is not very important, I use an experimental next-gen toolchain to test this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jeroen commented on pull request #10914: ARROW-9616: [C++][R] Remove templated base classes named `/.*ConcurrencyWrapper/`
Posted by GitBox <gi...@apache.org>.
jeroen commented on pull request #10914:
URL: https://github.com/apache/arrow/pull/10914#issuecomment-897481964
@bkietz seems to have solved most errors, but still 1 remaining: https://gist.github.com/jeroen/0c8bbfcdc51c6ac6d0672a3ca164e532
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #10914: ARROW-9616: [C++][R] Remove templated base classes named `/.*ConcurrencyWrapper/`
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #10914:
URL: https://github.com/apache/arrow/pull/10914#issuecomment-896947875
https://issues.apache.org/jira/browse/ARROW-9616
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] bkietz commented on pull request #10914: ARROW-9616: [C++][R] Remove templated base classes named `/.*ConcurrencyWrapper/`
Posted by GitBox <gi...@apache.org>.
bkietz commented on pull request #10914:
URL: https://github.com/apache/arrow/pull/10914#issuecomment-896948288
@jeroen does this fix https://gist.github.com/jeroen/fb83a191ebc90e7e867c5e1bb7465645 ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #10914: ARROW-9616: [C++][R] Remove templated base classes named `/.*ConcurrencyWrapper/`
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #10914:
URL: https://github.com/apache/arrow/pull/10914#issuecomment-963328693
What is the status on this, I'm assuming the underlying issue has been fixed otherwise?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org