You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2019/02/05 06:17:39 UTC
[GitHub] Klaster1 commented on a change in pull request #6021: IGNITE-11035
Updates in queries page.
Klaster1 commented on a change in pull request #6021: IGNITE-11035 Updates in queries page.
URL: https://github.com/apache/ignite/pull/6021#discussion_r253739370
##########
File path: modules/web-console/frontend/app/components/cluster-selector/controller.js
##########
@@ -63,8 +64,13 @@ export default class {
this.clusters$.unsubscribe();
}
- change() {
- this.agentMgr.switchCluster(this.cluster);
+ change(item) {
+ this.agentMgr.switchCluster(this.cluster)
+ .then(() => this.cluster = item)
Review comment:
Updated `AgentManager.switchCluster` returns `true` if cluster was successful switched, did you check that assigning `true` to `this.cluster` doesn't break cluster-selector?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services