You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "martin-g (via GitHub)" <gi...@apache.org> on 2023/11/15 14:00:05 UTC
[PR] AVRO-3904: [Rust] Change the return type of SchemaCompatibility::can_read() from `bool` to `AvroResult<()>` [avro]
martin-g opened a new pull request, #2585:
URL: https://github.com/apache/avro/pull/2585
AVRO-3904
**API break**
## What is the purpose of the change
* Do not panic when schemata are incompatible. Return Err and let the user deal with it.
## Verifying this change
* Run the build and test
## Documentation
- Does this pull request introduce a new feature? no
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-3904: [Rust] Change the return type of SchemaCompatibility::can_read() from `bool` to `AvroResult<()>` [avro]
Posted by "marcosschroh (via GitHub)" <gi...@apache.org>.
marcosschroh commented on PR #2585:
URL: https://github.com/apache/avro/pull/2585#issuecomment-1812627401
This looks really similar to https://github.com/apache/avro/compare/main...marcosschroh:avro:fix/compatibility-read-when-field-is-subset?expand=1. I push literal an hour ago, I stopped to solve an issue in my personal work and I see this... I have never seen such a thing... incredible
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-3904: [Rust] Change the return type of SchemaCompatibility::can_read() from `bool` to `AvroResult<()>` [avro]
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on PR #2585:
URL: https://github.com/apache/avro/pull/2585#issuecomment-1812674816
@marcosschroh You can still review and approve the PR! Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-3904: [Rust] Change the return type of SchemaCompatibility::can_read() from `bool` to `AvroResult<()>` [avro]
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on PR #2585:
URL: https://github.com/apache/avro/pull/2585#issuecomment-1812654055
> Next time I will make sure to create a PR a microsecond after pushing to my fork to avoid people stealing things. This one would have been my first contribution to a project using `rust` as I am a newie in `rust` , thanks a lot @martin-g really appreciate it.
Sorry for stealing your joy! :-)
I had free time and decided to work on this...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-3904: [Rust] Change the return type of SchemaCompatibility::can_read() from `bool` to `AvroResult<()>` [avro]
Posted by "marcosschroh (via GitHub)" <gi...@apache.org>.
marcosschroh commented on PR #2585:
URL: https://github.com/apache/avro/pull/2585#issuecomment-1812645347
Next time I will make sure to create a PR a microsecond after pushing to my fork to avoid people stealing things. This one would have been my first contribution to a project using `rust` as I am a newie in `rust` , thanks a lot @martin-g really appreciate it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-3904: [Rust] Change the return type of SchemaCompatibility::can_read() from `bool` to `AvroResult<()>` [avro]
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on PR #2585:
URL: https://github.com/apache/avro/pull/2585#issuecomment-1813982388
I have no time for drama!
I will close the PR and let you open a new one!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-3904: [Rust] Change the return type of SchemaCompatibility::can_read() from `bool` to `AvroResult<()>` [avro]
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g closed pull request #2585: AVRO-3904: [Rust] Change the return type of SchemaCompatibility::can_read() from `bool` to `AvroResult<()>`
URL: https://github.com/apache/avro/pull/2585
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-3904: [Rust] Change the return type of SchemaCompatibility::can_read() from `bool` to `AvroResult<()>` [avro]
Posted by "martin-g (via GitHub)" <gi...@apache.org>.
martin-g commented on PR #2585:
URL: https://github.com/apache/avro/pull/2585#issuecomment-1812587469
The unit tests still fail! Needs debugging!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] AVRO-3904: [Rust] Change the return type of SchemaCompatibility::can_read() from `bool` to `AvroResult<()>` [avro]
Posted by "marcosschroh (via GitHub)" <gi...@apache.org>.
marcosschroh commented on PR #2585:
URL: https://github.com/apache/avro/pull/2585#issuecomment-1812776708
As I mentioned: `I am a newbie in rust`, so another person with more experience should look at it. Despite my lack of knowledge on `rust`, yesterday we agreed in the [jira ticket](https://issues.apache.org/jira/browse/AVRO-3904) that I had to send a PR and then you (@martin-g ) would look at it (not the other way around). Involve another developer with rust experience to get feedback.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@avro.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org