[GitHub] [netbeans] lkishalmi edited a comment on issue #1703: [NETBEANS-3428] FlatLaf: Fixed colors of categories buttons in Options dialog

[GitBox <gi...@apache.org>]

lkishalmi edited a comment on issue #1703: [NETBEANS-3428] FlatLaf: Fixed colors of categories buttons in Options dialog
URL: https://github.com/apache/netbeans/pull/1703#issuecomment-559978459
 
 
   The fields shall be not static as eventually we might support on the fly LaF changes.
   isNativeLookAndFeel() is a kind of problematic it only returns true for Windows and probably Mac. On Linux the GtkLookAndFeel is based on Synth, so it is a kind of non-native native LaF.
   
   I agree with Neil that there shall be no LaF specific hack in the code, especially no had coded colors. Though I would not vote against this change as this is the least intrusive to support Flatlaf based Look and Feels. On the other hand I'd create a JIRA issue to mark it to be sort out later.
   We have several places where we patch the LaF all around the code base we shall mark them, and probably came up with a plan/guideline how to fix them. But that's another story.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists