You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/11/04 22:52:25 UTC

[GitHub] [incubator-superset] riahk commented on a change in pull request #11540: feat: annotation delete modal, bulk delete and empty state

riahk commented on a change in pull request #11540:
URL: https://github.com/apache/incubator-superset/pull/11540#discussion_r517676844



##########
File path: superset-frontend/src/views/CRUD/annotation/AnnotationList.tsx
##########
@@ -186,6 +243,24 @@ function AnnotationList({ addDangerToast }: AnnotationListProps) {
     hasHistory = false;
   }
 
+  const EmptyStateButton = (
+    <Button
+      buttonStyle="primary"
+      onClick={() => {
+        handleAnnotationEdit(null);
+      }}
+    >
+      <>
+        <i className="fa fa-plus" /> {t('Annotation Layer')}

Review comment:
       I believe we want this to just be `Annotation`

##########
File path: superset-frontend/src/views/CRUD/annotation/AnnotationList.tsx
##########
@@ -186,6 +243,24 @@ function AnnotationList({ addDangerToast }: AnnotationListProps) {
     hasHistory = false;
   }
 
+  const EmptyStateButton = (
+    <Button
+      buttonStyle="primary"
+      onClick={() => {
+        handleAnnotationEdit(null);
+      }}
+    >
+      <>
+        <i className="fa fa-plus" /> {t('Annotation Layer')}
+      </>
+    </Button>
+  );
+
+  const emptyState = {
+    message: 'No annotation yet',

Review comment:
       `No annotations yet`, also we should be wrapping this in `t(...)`
   
   Just realized we aren't doing that for the message on `AnnotationLayersList`, any chance we can get that updated as well?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org