You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2022/11/28 08:24:17 UTC
[GitHub] [shardingsphere] ICannerxy opened a new pull request, #22481: Add t_merchant standard table in encrypt scenario
ICannerxy opened a new pull request, #22481:
URL: https://github.com/apache/shardingsphere/pull/22481
Ref https://github.com/apache/shardingsphere/issues/21286.
Changes proposed in this pull request:
- add t_merchant standard table structure for encrypt scenario
- add t_merchant init data for encrypt scenario
- adjust test case
---
Before committing this PR, I'm sure that I have checked the following options:
- [x] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [x] I have self-reviewed the commit code.
- [x] I have (or in comment I request) added corresponding labels for the pull request.
- [x] I have passed maven check locally : `mvn clean install -B -T2C -DskipTests -Dmaven.javadoc.skip=true -e`.
- [ ] I have made corresponding changes to the documentation.
- [x] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] ICannerxy closed pull request #22481: Add t_merchant standard table in encrypt scenario
Posted by GitBox <gi...@apache.org>.
ICannerxy closed pull request #22481: Add t_merchant standard table in encrypt scenario
URL: https://github.com/apache/shardingsphere/pull/22481
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu merged pull request #22481: Add t_merchant standard table in encrypt scenario
Posted by GitBox <gi...@apache.org>.
strongduanmu merged PR #22481:
URL: https://github.com/apache/shardingsphere/pull/22481
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on a diff in pull request #22481: Add t_merchant standard table in encrypt scenario
Posted by GitBox <gi...@apache.org>.
strongduanmu commented on code in PR #22481:
URL: https://github.com/apache/shardingsphere/pull/22481#discussion_r1033422533
##########
test/integration-test/test-suite/src/test/resources/env/scenario/encrypt/proxy/conf/postgresql/config-encrypt.yaml:
##########
@@ -52,3 +52,13 @@ rules:
plainColumn: number_new_plain
cipherColumn: number_new_cipher
encryptorName: aes_encryptor
+ t_merchant:
+ columns:
+ business_code:
+ plainColumn: business_code_plain
+ cipherColumn: business_code_cipher
+ encryptorName: aes_encryptor
+ telephone:
+ plainColumn: telephone_plain
+ cipherColumn: telephone_cipher
+ encryptorName: aes_encryptor
Review Comment:
Please add new line here.
##########
test/integration-test/test-suite/src/test/resources/env/scenario/encrypt/rules.yaml:
##########
@@ -39,3 +39,13 @@ rules:
plainColumn: number_new_plain
cipherColumn: number_new_cipher
encryptorName: aes_encryptor
+ t_merchant:
+ columns:
+ business_code:
+ plainColumn: business_code_plain
+ cipherColumn: business_code_cipher
+ encryptorName: aes_encryptor
+ telephone:
+ plainColumn: telephone_plain
+ cipherColumn: telephone_cipher
+ encryptorName: aes_encryptor
Review Comment:
Please add new line here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org