You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/02/09 13:34:48 UTC

[GitHub] [nifi-minifi-cpp] fgerlits commented on pull request #999: MINIFICPP-1485 Improve 'exclusive property' error message (mini-PR)

fgerlits commented on pull request #999:
URL: https://github.com/apache/nifi-minifi-cpp/pull/999#issuecomment-775939342


   > Looks good to me. However, I think readibility could be further improved with an error message like:
   > 
   > > The property "SSL Context Service" can only be used for "Remote URL" values that do not start with "http:".
   
   Yes, that would be better.  But our current `->withExclusiveProperty()` allows any regular expression, and parsing the regex to check whether it is of the form `^something.*$` would be overkill, I think.
   
   I would have done this the other way round, eg. `->withOtherPropertyMatchingRegex()` so we can say "property X must match regex ... if property Y is set" -- but changing this would break our yaml API, so I don't think we can do it.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org