You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by remibergsma <gi...@git.apache.org> on 2016/04/07 21:59:28 UTC
[GitHub] cloudstack pull request: When no zone name is available display a ...
GitHub user remibergsma opened a pull request:
https://github.com/apache/cloudstack/pull/1477
When no zone name is available display a default
When a zone name is available, the previous behaviour is still there:
When there is no zone name, it used to display an empty name (where you had to click on to see details):
With this change, a default name `All` is displayed (because this happens when S3 storage is used that is region wide aka all zones):
Region wide S3:
FYI: Screenshot shows 'All', later renamed to 'All Zones', see code.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/remibergsma/cloudstack 47_default_zone_name_s3
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1477.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1477
----
commit aead9f4ff43ea79107e2b870ab49fcf2f3fd7a0d
Author: Remi Bergsma <gi...@remi.nl>
Date: 2016-04-07T19:57:17Z
When no zone name is available display a default
Backport from Cosmic
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: When no zone name is available display a ...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1477#issuecomment-218365520
I am going to merge this one. I am confident with the change and I have verification from @remibergsma, so I think we are good to go on this one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: When no zone name is available display a ...
Posted by pdube <gi...@git.apache.org>.
Github user pdube commented on the pull request:
https://github.com/apache/cloudstack/pull/1477#issuecomment-213822378
LGTM. Do you think we should translate this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: When no zone name is available display a ...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1477#issuecomment-216233168
@rhtyd in general, I agree with you. The main blocker with that is the fact that very few people have the ability to test regional templates. The code is pretty straight forward too, so that helps our confidence in the change...
@pdube do you have the ability to test this PR with our swift setup to verify it works as expected?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: When no zone name is available display a ...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1477#issuecomment-216228565
I think this is ready to merge. @remibergsma has shown screenshots to verify the UI change does what it is supposed to and we have the LGTMs required.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: When no zone name is available display a ...
Posted by swill <gi...@git.apache.org>.
Github user swill commented on the pull request:
https://github.com/apache/cloudstack/pull/1477#issuecomment-217471150
Unless someone is able to verify this, I think we have to take the screenshots from @remibergsma as verification. Not very many people have the ability to test regional templates, so we have a very limited group of users who can give us verification on this. If we don't have any verification by Monday, I will likely merge this and count on @remibergsma's verification as proof that it works...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: When no zone name is available display a ...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1477#issuecomment-216232227
@swill apart from the PR author, it would be great if at least one more reviewer can share a screenshot; please proceed as per your discretion
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: When no zone name is available display a ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1477
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: When no zone name is available display a ...
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the pull request:
https://github.com/apache/cloudstack/pull/1477#issuecomment-216227415
LGTM
A manual UI testing is needed
tag:mergeready
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---