You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by aliokan <gi...@git.apache.org> on 2015/11/05 19:06:50 UTC
[GitHub] cordova-plugin-camera pull request: Browser - Camera on top of all...
GitHub user aliokan opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/134
Browser - Camera on top of all!
add CSS style {position: 'relative', z-index: 99999} on DOM appended element
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aliokan/cordova-plugin-camera aliokan-patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-camera/pull/134.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #134
----
commit b2069b67210b68ce39a70e00d0e2513deb6b376c
Author: Laurent Deketelaere <la...@geturl.net>
Date: 2015-11-05T18:04:34Z
Browser - Camera on top of all!
add CSS style {position: 'relative', z-index: 99999} on DOM appended element
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Browser - Camera on top of all...
Posted by aliokan <gi...@git.apache.org>.
Github user aliokan commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/134#issuecomment-158002551
I have signed Apache Individual Contributor License Agreement :)
https://people.apache.org/committer-index.html#unlistedclas Laurent Deketelaere
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: CB-10113 - Browser - Camera on...
Posted by shprink <gi...@git.apache.org>.
Github user shprink commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/134#issuecomment-164321840
+1 for this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: CB-10113 - Browser - Camera on...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/134
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: CB-10113 - Browser - Camera on...
Posted by TimBarham <gi...@git.apache.org>.
Github user TimBarham commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/134#issuecomment-178412993
Thanks for this @aliokan. I've tweaked the commit a bit to store the magic number in a constant, and I'll merge it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: Browser - Camera on top of all...
Posted by riknoll <gi...@git.apache.org>.
Github user riknoll commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/134#issuecomment-160817757
@aliokan Thanks for doing that! Does this have a corresponding JIRA issue? Also, is there a reason you chose not to use the maximum value for the z-index? We recently merged in a similar fix for windows (see [here](https://github.com/apache/cordova-plugin-camera/pull/140))
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: CB-10113 - Browser - Camera on...
Posted by aliokan <gi...@git.apache.org>.
Github user aliokan commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/134#issuecomment-161247566
@riknoll I create a JIRA issue and change patch name and increase z-index value.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org