You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "baldimir (via GitHub)" <gi...@apache.org> on 2023/09/19 13:12:48 UTC
[GitHub] [incubator-kie-drools] baldimir opened a new pull request, #5530: [kie-issues#511] Migrate from jboss-parent to apache parent pom.
baldimir opened a new pull request, #5530:
URL: https://github.com/apache/incubator-kie-drools/pull/5530
This is part of an effort from issue https://github.com/kiegroup/kie-issues/issues/511.
- Changes root parent pom from jboss-parent to apache parent pom.xml.
- Fixes the build by adding missing Java module names.
- Aligns version property names with apache parent pom.
- Adds missing version properties.
- Adds JavaDoc plugin configuration so the JavaDoc generation is the same as before the migration.
Sorry for some formatting changes, the formatting was wrong in those files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
[GitHub] [incubator-kie-drools] baldimir merged pull request #5530: [kie-issues#511] Migrate from jboss-parent to apache parent pom.
Posted by "baldimir (via GitHub)" <gi...@apache.org>.
baldimir merged PR #5530:
URL: https://github.com/apache/incubator-kie-drools/pull/5530
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
[GitHub] [incubator-kie-drools] porcelli commented on a diff in pull request #5530: [kie-issues#511] Migrate from jboss-parent to apache parent pom.
Posted by "porcelli (via GitHub)" <gi...@apache.org>.
porcelli commented on code in PR #5530:
URL: https://github.com/apache/incubator-kie-drools/pull/5530#discussion_r1331743584
##########
drools-drl-quarkus-extension/drools-drl-quarkus/pom.xml:
##########
Review Comment:
isn't anything missing here?
##########
efesto/efesto-dependencies/pom.xml:
##########
@@ -38,7 +38,8 @@
</description>
<properties>
- <skip.jdepend>true</skip.jdepend>
+ <java.module.name>org.drools.efesto.dependencies</java.module.name>
+ <skip.jdepend>false</skip.jdepend>
Review Comment:
why this change from true to false?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
[GitHub] [incubator-kie-drools] baldimir commented on a diff in pull request #5530: [kie-issues#511] Migrate from jboss-parent to apache parent pom.
Posted by "baldimir (via GitHub)" <gi...@apache.org>.
baldimir commented on code in PR #5530:
URL: https://github.com/apache/incubator-kie-drools/pull/5530#discussion_r1332824225
##########
efesto/efesto-dependencies/pom.xml:
##########
@@ -38,7 +38,8 @@
</description>
<properties>
- <skip.jdepend>true</skip.jdepend>
+ <java.module.name>org.drools.efesto.dependencies</java.module.name>
+ <skip.jdepend>false</skip.jdepend>
Review Comment:
Oh my mistake, I will fix.
##########
efesto/efesto-dependencies/pom.xml:
##########
@@ -38,7 +38,8 @@
</description>
<properties>
- <skip.jdepend>true</skip.jdepend>
+ <java.module.name>org.drools.efesto.dependencies</java.module.name>
+ <skip.jdepend>false</skip.jdepend>
Review Comment:
Oh my mistake, I will fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
[GitHub] [incubator-kie-drools] baldimir commented on a diff in pull request #5530: [kie-issues#511] Migrate from jboss-parent to apache parent pom.
Posted by "baldimir (via GitHub)" <gi...@apache.org>.
baldimir commented on code in PR #5530:
URL: https://github.com/apache/incubator-kie-drools/pull/5530#discussion_r1332830441
##########
drools-drl-quarkus-extension/drools-drl-quarkus/pom.xml:
##########
Review Comment:
I will revert this file, as there are only formatting changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
[GitHub] [incubator-kie-drools] baldimir commented on pull request #5530: [kie-issues#511] Migrate from jboss-parent to apache parent pom.
Posted by "baldimir (via GitHub)" <gi...@apache.org>.
baldimir commented on PR #5530:
URL: https://github.com/apache/incubator-kie-drools/pull/5530#issuecomment-1729284395
@porcelli I added fixes based on your comments. Please rereview.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org