You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Harikrishna Patnala <ha...@citrix.com> on 2013/06/20 11:42:48 UTC
Review Request: Fix for CLOUDSTACK-2916,
CLOUDSTACK-2457: validation for weight based configuration parameters
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11989/
-----------------------------------------------------------
Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.
Description
-------
CLOUDSTACK-2916: admin is not able to login through UI after setting GP "cluster.cpu.allocated.capacity.notificationthreshold" to some string
CLOUDSTACK-2457: No check for input values,special character,-ive values can be assigne to GLobal parameter "cluster.cpu.allocated.capacity.disablethreshold"
Added validation for float values and checking limit for weight based parameters by creating a set of parameters.
This addresses bugs CLOUDSTACK-2457 and CLOUDSTACK-2916.
Diffs
-----
server/src/com/cloud/configuration/ConfigurationManagerImpl.java 131d340
Diff: https://reviews.apache.org/r/11989/diff/
Testing
-------
Tested locally
Thanks,
Harikrishna Patnala
Re: Review Request: Fix for CLOUDSTACK-2916,
CLOUDSTACK-2457: validation for weight based configuration parameters
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11989/#review22322
-----------------------------------------------------------
Commit f7b1d3d8d5be58a8032fc79eec4dd5711226b93a in branch refs/heads/master from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=f7b1d3d ]
CLOUDSTACK-2916: admin is not able to login through UI after setting GP "cluster.cpu.allocated.capacity.notificationthreshold" to some string
CLOUDSTACK-2457: No check for input values,special character,-ive values can be assigne to GLobal parameter "cluster.cpu.allocated.capacity.disablethreshold"
Added validation for float values and checking limit for weight based parameters by creating a set of parameters.
Signed off by : nitin mehta<ni...@citrix.com>
- ASF Subversion and Git Services
On June 20, 2013, 9:42 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11989/
> -----------------------------------------------------------
>
> (Updated June 20, 2013, 9:42 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.
>
>
> Description
> -------
>
> CLOUDSTACK-2916: admin is not able to login through UI after setting GP "cluster.cpu.allocated.capacity.notificationthreshold" to some string
> CLOUDSTACK-2457: No check for input values,special character,-ive values can be assigne to GLobal parameter "cluster.cpu.allocated.capacity.disablethreshold"
>
> Added validation for float values and checking limit for weight based parameters by creating a set of parameters.
>
>
> This addresses bugs CLOUDSTACK-2457 and CLOUDSTACK-2916.
>
>
> Diffs
> -----
>
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java 131d340
>
> Diff: https://reviews.apache.org/r/11989/diff/
>
>
> Testing
> -------
>
> Tested locally
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request: Fix for CLOUDSTACK-2916,
CLOUDSTACK-2457: validation for weight based configuration parameters
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11989/#review22323
-----------------------------------------------------------
Commit f7b1d3d8d5be58a8032fc79eec4dd5711226b93a in branch refs/heads/master from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=f7b1d3d ]
CLOUDSTACK-2916: admin is not able to login through UI after setting GP "cluster.cpu.allocated.capacity.notificationthreshold" to some string
CLOUDSTACK-2457: No check for input values,special character,-ive values can be assigne to GLobal parameter "cluster.cpu.allocated.capacity.disablethreshold"
Added validation for float values and checking limit for weight based parameters by creating a set of parameters.
Signed off by : nitin mehta<ni...@citrix.com>
- ASF Subversion and Git Services
On June 20, 2013, 9:42 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11989/
> -----------------------------------------------------------
>
> (Updated June 20, 2013, 9:42 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.
>
>
> Description
> -------
>
> CLOUDSTACK-2916: admin is not able to login through UI after setting GP "cluster.cpu.allocated.capacity.notificationthreshold" to some string
> CLOUDSTACK-2457: No check for input values,special character,-ive values can be assigne to GLobal parameter "cluster.cpu.allocated.capacity.disablethreshold"
>
> Added validation for float values and checking limit for weight based parameters by creating a set of parameters.
>
>
> This addresses bugs CLOUDSTACK-2457 and CLOUDSTACK-2916.
>
>
> Diffs
> -----
>
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java 131d340
>
> Diff: https://reviews.apache.org/r/11989/diff/
>
>
> Testing
> -------
>
> Tested locally
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request: Fix for CLOUDSTACK-2916,
CLOUDSTACK-2457: validation for weight based configuration parameters
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11989/#review22321
-----------------------------------------------------------
Commit 3c214aba97fc5e7507fe2e175f5f7a0f745557fe in branch refs/heads/master-6-17-stable from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=3c214ab ]
CLOUDSTACK-2916: admin is not able to login through UI after setting GP "cluster.cpu.allocated.capacity.notificationthreshold" to some string
CLOUDSTACK-2457: No check for input values,special character,-ive values can be assigne to GLobal parameter "cluster.cpu.allocated.capacity.disablethreshold"
Added validation for float values and checking limit for weight based parameters by creating a set of parameters.
Signed off by : nitin mehta<ni...@citrix.com>
- ASF Subversion and Git Services
On June 20, 2013, 9:42 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11989/
> -----------------------------------------------------------
>
> (Updated June 20, 2013, 9:42 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.
>
>
> Description
> -------
>
> CLOUDSTACK-2916: admin is not able to login through UI after setting GP "cluster.cpu.allocated.capacity.notificationthreshold" to some string
> CLOUDSTACK-2457: No check for input values,special character,-ive values can be assigne to GLobal parameter "cluster.cpu.allocated.capacity.disablethreshold"
>
> Added validation for float values and checking limit for weight based parameters by creating a set of parameters.
>
>
> This addresses bugs CLOUDSTACK-2457 and CLOUDSTACK-2916.
>
>
> Diffs
> -----
>
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java 131d340
>
> Diff: https://reviews.apache.org/r/11989/diff/
>
>
> Testing
> -------
>
> Tested locally
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request: Fix for CLOUDSTACK-2916,
CLOUDSTACK-2457: validation for weight based configuration parameters
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11989/#review22320
-----------------------------------------------------------
Commit 3c214aba97fc5e7507fe2e175f5f7a0f745557fe in branch refs/heads/master-6-17-stable from Harikrishna Patnala
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=3c214ab ]
CLOUDSTACK-2916: admin is not able to login through UI after setting GP "cluster.cpu.allocated.capacity.notificationthreshold" to some string
CLOUDSTACK-2457: No check for input values,special character,-ive values can be assigne to GLobal parameter "cluster.cpu.allocated.capacity.disablethreshold"
Added validation for float values and checking limit for weight based parameters by creating a set of parameters.
Signed off by : nitin mehta<ni...@citrix.com>
- ASF Subversion and Git Services
On June 20, 2013, 9:42 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11989/
> -----------------------------------------------------------
>
> (Updated June 20, 2013, 9:42 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.
>
>
> Description
> -------
>
> CLOUDSTACK-2916: admin is not able to login through UI after setting GP "cluster.cpu.allocated.capacity.notificationthreshold" to some string
> CLOUDSTACK-2457: No check for input values,special character,-ive values can be assigne to GLobal parameter "cluster.cpu.allocated.capacity.disablethreshold"
>
> Added validation for float values and checking limit for weight based parameters by creating a set of parameters.
>
>
> This addresses bugs CLOUDSTACK-2457 and CLOUDSTACK-2916.
>
>
> Diffs
> -----
>
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java 131d340
>
> Diff: https://reviews.apache.org/r/11989/diff/
>
>
> Testing
> -------
>
> Tested locally
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request: Fix for CLOUDSTACK-2916,
CLOUDSTACK-2457: validation for weight based configuration parameters
Posted by Nitin Mehta <ni...@citrix.com>.
> On June 20, 2013, 10:12 a.m., Nitin Mehta wrote:
> > Ship It!
Please rebase
Nitins-MacBook-Air:cloudstack nitinmehta$ git apply ../0001-CLOUDSTACK-2916-admin-is-not-able-to-login-through-U.patch
error: patch failed: server/src/com/cloud/configuration/ConfigurationManagerImpl.java:336
error: server/src/com/cloud/configuration/ConfigurationManagerImpl.java: patch does not apply
- Nitin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11989/#review22161
-----------------------------------------------------------
On June 20, 2013, 9:42 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11989/
> -----------------------------------------------------------
>
> (Updated June 20, 2013, 9:42 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.
>
>
> Description
> -------
>
> CLOUDSTACK-2916: admin is not able to login through UI after setting GP "cluster.cpu.allocated.capacity.notificationthreshold" to some string
> CLOUDSTACK-2457: No check for input values,special character,-ive values can be assigne to GLobal parameter "cluster.cpu.allocated.capacity.disablethreshold"
>
> Added validation for float values and checking limit for weight based parameters by creating a set of parameters.
>
>
> This addresses bugs CLOUDSTACK-2457 and CLOUDSTACK-2916.
>
>
> Diffs
> -----
>
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java 131d340
>
> Diff: https://reviews.apache.org/r/11989/diff/
>
>
> Testing
> -------
>
> Tested locally
>
>
> Thanks,
>
> Harikrishna Patnala
>
>
Re: Review Request: Fix for CLOUDSTACK-2916,
CLOUDSTACK-2457: validation for weight based configuration parameters
Posted by Nitin Mehta <ni...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11989/#review22161
-----------------------------------------------------------
Ship it!
Ship It!
- Nitin Mehta
On June 20, 2013, 9:42 a.m., Harikrishna Patnala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11989/
> -----------------------------------------------------------
>
> (Updated June 20, 2013, 9:42 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and Nitin Mehta.
>
>
> Description
> -------
>
> CLOUDSTACK-2916: admin is not able to login through UI after setting GP "cluster.cpu.allocated.capacity.notificationthreshold" to some string
> CLOUDSTACK-2457: No check for input values,special character,-ive values can be assigne to GLobal parameter "cluster.cpu.allocated.capacity.disablethreshold"
>
> Added validation for float values and checking limit for weight based parameters by creating a set of parameters.
>
>
> This addresses bugs CLOUDSTACK-2457 and CLOUDSTACK-2916.
>
>
> Diffs
> -----
>
> server/src/com/cloud/configuration/ConfigurationManagerImpl.java 131d340
>
> Diff: https://reviews.apache.org/r/11989/diff/
>
>
> Testing
> -------
>
> Tested locally
>
>
> Thanks,
>
> Harikrishna Patnala
>
>