You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/06/18 08:38:07 UTC
[GitHub] [airflow] potiuk opened a new pull request #9370: Prepare backport release candidate for 2020.06.23rc1
potiuk opened a new pull request #9370:
URL: https://github.com/apache/airflow/pull/9370
---
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Unit tests coverage for changes (not needed for documentation changes)
- [x] Target Github ISSUE in description if exists
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #9370: Prepare backport release candidate for 2020.6.23rc1
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #9370:
URL: https://github.com/apache/airflow/pull/9370
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #9370: Prepare backport release candidate for 2020.6.23rc1
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #9370:
URL: https://github.com/apache/airflow/pull/9370#discussion_r442071534
##########
File path: airflow/providers/amazon/README.md
##########
@@ -95,7 +95,7 @@ pip install apache-airflow-backport-providers-amazon[apache.hive]
| [apache-airflow-backport-providers-postgres](https://github.com/apache/airflow/tree/master/airflow/providers/postgres) | postgres |
| [apache-airflow-backport-providers-ssh](https://github.com/apache/airflow/tree/master/airflow/providers/ssh) | ssh |
-# Provider class summary
+# Provider classes summary
All classes in Airflow 2.0 are in `airflow.providers.amazon` package.
Review comment:
```suggestion
All operator/hook/sensor classes in Airflow 2.0 are in `airflow.providers.amazon` package.
```
WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #9370: Prepare backport release candidate for 2020.6.23rc1
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #9370:
URL: https://github.com/apache/airflow/pull/9370#discussion_r442126446
##########
File path: airflow/providers/amazon/README.md
##########
@@ -95,7 +95,7 @@ pip install apache-airflow-backport-providers-amazon[apache.hive]
| [apache-airflow-backport-providers-postgres](https://github.com/apache/airflow/tree/master/airflow/providers/postgres) | postgres |
| [apache-airflow-backport-providers-ssh](https://github.com/apache/airflow/tree/master/airflow/providers/ssh) | ssh |
-# Provider class summary
+# Provider classes summary
All classes in Airflow 2.0 are in `airflow.providers.amazon` package.
Review comment:
Yep. I updated the description and also reviewed and cleaned up documentation for the backport packages in README.md to explain a bit better what the packages are for and how to install them and about the watchout for installing the backport packages in the same namespace as 'apache-airflow'.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] turbaszek commented on a change in pull request #9370: Prepare backport release candidate for 2020.6.23rc1
Posted by GitBox <gi...@apache.org>.
turbaszek commented on a change in pull request #9370:
URL: https://github.com/apache/airflow/pull/9370#discussion_r442071534
##########
File path: airflow/providers/amazon/README.md
##########
@@ -95,7 +95,7 @@ pip install apache-airflow-backport-providers-amazon[apache.hive]
| [apache-airflow-backport-providers-postgres](https://github.com/apache/airflow/tree/master/airflow/providers/postgres) | postgres |
| [apache-airflow-backport-providers-ssh](https://github.com/apache/airflow/tree/master/airflow/providers/ssh) | ssh |
-# Provider class summary
+# Provider classes summary
All classes in Airflow 2.0 are in `airflow.providers.amazon` package.
Review comment:
```suggestion
All operator classes in Airflow 2.0 are in `airflow.providers.amazon` package.
```
WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org