You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/04/27 11:17:14 UTC

[GitHub] [incubator-doris] pingchunzhang commented on a diff in pull request #9096: [Enhancement](regression-test) support exclude suite/group/directory

pingchunzhang commented on code in PR #9096:
URL: https://github.com/apache/incubator-doris/pull/9096#discussion_r859544449


##########
regression-test/framework/src/main/groovy/org/apache/doris/regression/ConfigOptions.groovy:
##########
@@ -141,6 +162,15 @@ class ConfigOptions {
                 .longOpt("directories")
                 .desc("only the use cases in these directories can be executed")
                 .build()
+        excludeDirectoriesOpt = Option.builder("xd")
+                .argName("directories")
+                .required(false)
+                .hasArg(true)
+                .optionalArg(true)
+                .type(String.class)
+                .longOpt("directories")

Review Comment:
   same problem, line 171:
                   .longOpt("excludeDirectories")



##########
regression-test/framework/src/main/groovy/org/apache/doris/regression/ConfigOptions.groovy:
##########
@@ -132,6 +144,15 @@ class ConfigOptions {
                 .longOpt("groups")
                 .desc("the suite group to be test")
                 .build()
+        excludeGroupsOpt = Option.builder("xg")
+                .argName("excludeGroups")
+                .required(false)
+                .hasArg(true)
+                .optionalArg(true)
+                .type(String.class)
+                .longOpt("groups")
+                .desc("the suite group will not be tested")

Review Comment:
   line 151 should be like:
                   .longOpt("excludeGroups")



##########
run-regression-test.sh:
##########
@@ -56,7 +36,11 @@ Usage: $0 <shell_options> <framework_options>
   Optional framework_options:
      -s                                run a specified suite
      -g                                run a specified group
+     -d                                run a specified directory
      -h                                **print all framework options usage**
+     -xs                               exclude the specified suite
+     -xg                               exclude the specified group
+     -xd                               exclude the specified directory

Review Comment:
   by the way, what does x mean, why did not choose -es -eg -ed to exclude the specific suite/group/directory



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org