You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/04/14 11:23:09 UTC
[GitHub] [flink] wangyang0918 opened a new pull request #11733:
[FLINK-15790][k8s] Make some interfaces in FlinkKubeClient asynchronous
which potentially blocks the execution of RpcEndpoint's main thread
wangyang0918 opened a new pull request #11733: [FLINK-15790][k8s] Make some interfaces in FlinkKubeClient asynchronous which potentially blocks the execution of RpcEndpoint's main thread
URL: https://github.com/apache/flink/pull/11733
Backport #11427 to release-1.10
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wangyang0918 commented on issue #11733: [Backport to
1.10][FLINK-15790][k8s] Make some interfaces in FlinkKubeClient
asynchronous which potentially blocks the execution of RpcEndpoint's main
thread
Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on issue #11733: [Backport to 1.10][FLINK-15790][k8s] Make some interfaces in FlinkKubeClient asynchronous which potentially blocks the execution of RpcEndpoint's main thread
URL: https://github.com/apache/flink/pull/11733#issuecomment-613997629
cc @azagrebin, this PR is to backport #11427 to release-1.10.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11733: [Backport to
1.10][FLINK-15790][k8s] Make some interfaces in FlinkKubeClient
asynchronous which potentially blocks the execution of RpcEndpoint's main
thread
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11733: [Backport to 1.10][FLINK-15790][k8s] Make some interfaces in FlinkKubeClient asynchronous which potentially blocks the execution of RpcEndpoint's main thread
URL: https://github.com/apache/flink/pull/11733#issuecomment-613396159
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b524ffcfb67324c2b77329f527780ab111e1b318",
"status" : "PENDING",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160198121",
"triggerID" : "b524ffcfb67324c2b77329f527780ab111e1b318",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b524ffcfb67324c2b77329f527780ab111e1b318 Travis: [PENDING](https://travis-ci.com/github/flink-ci/flink/builds/160198121)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot edited a comment on issue #11733: [Backport to
1.10][FLINK-15790][k8s] Make some interfaces in FlinkKubeClient
asynchronous which potentially blocks the execution of RpcEndpoint's main
thread
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on issue #11733: [Backport to 1.10][FLINK-15790][k8s] Make some interfaces in FlinkKubeClient asynchronous which potentially blocks the execution of RpcEndpoint's main thread
URL: https://github.com/apache/flink/pull/11733#issuecomment-613396159
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b524ffcfb67324c2b77329f527780ab111e1b318",
"status" : "SUCCESS",
"url" : "https://travis-ci.com/github/flink-ci/flink/builds/160198121",
"triggerID" : "b524ffcfb67324c2b77329f527780ab111e1b318",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b524ffcfb67324c2b77329f527780ab111e1b318 Travis: [SUCCESS](https://travis-ci.com/github/flink-ci/flink/builds/160198121)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11733: [Backport to
1.10][FLINK-15790][k8s] Make some interfaces in FlinkKubeClient
asynchronous which potentially blocks the execution of RpcEndpoint's main
thread
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11733: [Backport to 1.10][FLINK-15790][k8s] Make some interfaces in FlinkKubeClient asynchronous which potentially blocks the execution of RpcEndpoint's main thread
URL: https://github.com/apache/flink/pull/11733#issuecomment-613386048
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit b524ffcfb67324c2b77329f527780ab111e1b318 (Tue Apr 14 11:28:07 UTC 2020)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] azagrebin closed pull request #11733: [Backport to
1.10][FLINK-15790][k8s] Make some interfaces in FlinkKubeClient
asynchronous which potentially blocks the execution of RpcEndpoint's main
thread
Posted by GitBox <gi...@apache.org>.
azagrebin closed pull request #11733: [Backport to 1.10][FLINK-15790][k8s] Make some interfaces in FlinkKubeClient asynchronous which potentially blocks the execution of RpcEndpoint's main thread
URL: https://github.com/apache/flink/pull/11733
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] wangyang0918 removed a comment on issue #11733: [Backport
to 1.10][FLINK-15790][k8s] Make some interfaces in FlinkKubeClient
asynchronous which potentially blocks the execution of RpcEndpoint's main
thread
Posted by GitBox <gi...@apache.org>.
wangyang0918 removed a comment on issue #11733: [Backport to 1.10][FLINK-15790][k8s] Make some interfaces in FlinkKubeClient asynchronous which potentially blocks the execution of RpcEndpoint's main thread
URL: https://github.com/apache/flink/pull/11733#issuecomment-613997629
cc @azagrebin, this PR is to backport #11427 to release-1.10.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] azagrebin commented on issue #11733: [Backport to
1.10][FLINK-15790][k8s] Make some interfaces in FlinkKubeClient
asynchronous which potentially blocks the execution of RpcEndpoint's main
thread
Posted by GitBox <gi...@apache.org>.
azagrebin commented on issue #11733: [Backport to 1.10][FLINK-15790][k8s] Make some interfaces in FlinkKubeClient asynchronous which potentially blocks the execution of RpcEndpoint's main thread
URL: https://github.com/apache/flink/pull/11733#issuecomment-614696034
merged into 1.10 by 035453fb1472b917972daafcd552b7648b34eb31
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [flink] flinkbot commented on issue #11733: [Backport to
1.10][FLINK-15790][k8s] Make some interfaces in FlinkKubeClient
asynchronous which potentially blocks the execution of RpcEndpoint's main
thread
Posted by GitBox <gi...@apache.org>.
flinkbot commented on issue #11733: [Backport to 1.10][FLINK-15790][k8s] Make some interfaces in FlinkKubeClient asynchronous which potentially blocks the execution of RpcEndpoint's main thread
URL: https://github.com/apache/flink/pull/11733#issuecomment-613396159
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "b524ffcfb67324c2b77329f527780ab111e1b318",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "b524ffcfb67324c2b77329f527780ab111e1b318",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* b524ffcfb67324c2b77329f527780ab111e1b318 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run travis` re-run the last Travis build
- `@flinkbot run azure` re-run the last Azure build
</details>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services